[jira] [Commented] (WICKET-5820) improve StringResourceModel's resource key interpolation for null

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-5820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296994#comment-14296994 ] 

ASF subversion and git services commented on WICKET-5820:
---------------------------------------------------------

Commit e910b592e08f31505510fa00f31ed0f485b8b95a in wicket's branch refs/heads/master from [~svenmeier]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=e910b59 ]

WICKET-5820 interpolate null with 'null' in resourceKey

> improve StringResourceModel's resource key interpolation for null
> -----------------------------------------------------------------
>
>                 Key: WICKET-5820
>                 URL: https://issues.apache.org/jira/browse/WICKET-5820
>             Project: Wicket
>          Issue Type: Improvement
>            Reporter: Kamil
>            Assignee: Sven Meier
>            Priority: Minor
>         Attachments: TestCase_WICKET_5820.java, fix-WICKET-5820.patch, fix-WICKET-5820_other_approach.patch
>
>
> When using StringResourceModel one can add property expression into the resourceKey. 
> As documentation states: expression will be evaluated if the model parameter is not null.
> But when parameter *is null*, with given example:
> {code}
> new StringResourceModel("my.resource.${my.propertyValue}"), myModel);
> {code}
> one can expect the need to provide 
> {code}
> my.resource.null
> {code} resource key (same case as with DropDownChoice). 
> In fact, Wicket is searching for 
> {code}
> my.resource.${my.propertyValue}
> {code} (*literarily*) instead which is just wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)