You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/01 12:48:04 UTC
[GitHub] [airflow] edeNFed opened a new pull request #11222: Add UniqueConnIdRule rule and unittest
edeNFed opened a new pull request #11222:
URL: https://github.com/apache/airflow/pull/11222
Adds UniqueConnIdRule rule to upgrade/rules as per:
https://github.com/apache/airflow/blob/master/UPDATING.md#unique-conn_id-in-connection-table
Closes: #11037
---
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11222: Add UniqueConnIdRule rule and unittest
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11222:
URL: https://github.com/apache/airflow/pull/11222#issuecomment-703081258
> @edeNFed please get tests to pass and then I'll merge
@dimberman do you have an idea how to do this? I can see that tests were skipped in every PR opened to v1-10-test...
https://github.com/apache/airflow/pull/11132
https://github.com/apache/airflow/pull/11185
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #11222: Add UniqueConnIdRule rule and unittest
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #11222:
URL: https://github.com/apache/airflow/pull/11222#discussion_r499239027
##########
File path: airflow/upgrade/rules/conn_id_is_unique.py
##########
@@ -0,0 +1,45 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from __future__ import absolute_import
+
+from sqlalchemy import func
+from airflow.models import Connection
+from airflow.upgrade.rules.base_rule import BaseRule
+from airflow.utils.db import provide_session
+
+
+class UniqueConnIdRule(BaseRule):
+ title = "Connection.conn_id is not unique"
+
+ description = """\
+ The `id` column in the `connection` table must be unique. Previously, this rule was \
+ enforced by application logic, but was not enforced by the database schema.
+
+ If you made any modifications to the table directly, make sure you don't have \
+ duplicate values in conn_id column.
+ """
Review comment:
```suggestion
The `id` column in the `connection` table must be unique. Previously, this rule was \
enforced by application logic, but was not enforced by the database schema.
If you made any modifications to the table directly, make sure you don't have \
duplicate values in conn_id column.
"""
```
Please avoid unnecessary indentation:
```
Connection.conn_id is not unique
--------------------------------
The `id` column in the `connection` table must be unique. Previously, this rule was enforced by application logic, but was not enforced by the database schema.
If you made any modifications to the table directly, make sure you don't have duplicate values in conn_id column.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #11222: Add UniqueConnIdRule rule and unittest
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #11222:
URL: https://github.com/apache/airflow/pull/11222#issuecomment-702339873
@edeNFed please get tests to pass and then I'll merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] edeNFed commented on pull request #11222: Add UniqueConnIdRule rule and unittest
Posted by GitBox <gi...@apache.org>.
edeNFed commented on pull request #11222:
URL: https://github.com/apache/airflow/pull/11222#issuecomment-703227669
@dimberman @turbaszek all tests passed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11222: Add UniqueConnIdRule rule and unittest
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #11222:
URL: https://github.com/apache/airflow/pull/11222#issuecomment-702110666
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11222: Add UniqueConnIdRule rule and unittest
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11222:
URL: https://github.com/apache/airflow/pull/11222#issuecomment-703448631
The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow,
that you will not see in the list of checks (you will see "Wait for images" jobs instead).
You can checks the status of those images in [The workflow run](https://github.com/apache/airflow/actions/runs/288916857)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #11222: Add UniqueConnIdRule rule and unittest
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #11222:
URL: https://github.com/apache/airflow/pull/11222
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11222: Add UniqueConnIdRule rule and unittest
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11222:
URL: https://github.com/apache/airflow/pull/11222#issuecomment-703165008
@edeNFed Can you please rebase to latest v1-10-test ? It should work now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11222: Add UniqueConnIdRule rule and unittest
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #11222:
URL: https://github.com/apache/airflow/pull/11222#issuecomment-703479953
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org