You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/08/28 05:56:28 UTC
[Bug 120730] New: [From Symphony] Table changes to multiple shapes
after saved in AOO
https://issues.apache.org/ooo/show_bug.cgi?id=120730
Priority: P3
Bug ID: 120730
Assignee: ooo-issues@incubator.apache.org
Summary: [From Symphony] Table changes to multiple shapes after
saved in AOO
Severity: normal
Issue Type: DEFECT
Classification: Application
OS: All
Reporter: doneyourself@gmail.com
Hardware: All
Status: CONFIRMED
Version: AOO350-dev
Component: save-export
Product: presentation
Created attachment 79181
--> https://issues.apache.org/ooo/attachment.cgi?id=79181&action=edit
1.ppt
Build: AOO 3.5 rev. 1377620
OS: Windows7-64bit
Reproduce steps:
1. Open the sample file.
2. Check the table in the document, It works correctly.
3. Save the document to another ppt format file.
4. Open the saved file, then check the table.
Expected Result: Saved file reopen in AOO should same as original file
Actual Result: The table changes to multiple shapes, although it seems same as
original file.
Note: save to odp format file, it's ok.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120730] [From Symphony] Table changes to multiple shapes after
saved in AOO
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120730
--- Comment #1 from liupingtan <do...@gmail.com> ---
Created attachment 79182
--> https://issues.apache.org/ooo/attachment.cgi?id=79182&action=edit
capture.jpg
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120730] [From Symphony] Table changes to multiple shapes after
saved in AOO
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120730
sunying <su...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sunying@apache.org
--- Comment #3 from sunying <su...@apache.org> ---
Actually, It is two defect:
1. The position of some merged cell's line display error when exported by AOO.
root cause :
The position of some merged cell's line have been changed when import,
and write a error position when export.
e.g:
2*2 table,merged 1 & 2 cell. imported by AOO.
_ _ _ _ _ _ _ _ _ _ _ _ _ _
|_ 1_ _|_ _2 _| |_ _1 _ _2 _ _|
|_ _ 3_|_ _4 _| |_ _3 _|_ 4_ _|
in funciton SdrPowerPointImport::CreateTable at
"main\filter\source\msfilter\svdfppt.cxx"
line 7785: initialize pMergedCellIndexTable[] = {0,1,2,3},
line 7811: processed it, become {0,0,2,3}.
line 7842: change the positon of cell's line, the position of 2rd cell's line
is same with 1rd cell .
in function PPTWriter::ImplCreateTable at file
"\main\sd\source\filter\eppt\epptso.cxx"
line 5804, get the position of 2rd cell's line error, so display error when
open by MS.
solution:
the cell's position should not changed.the var pMergedCellIndexTable is
unnecessary. so remove it.
2. The table which include merged cell become a group shape exported by AOO.
root cause :
Merged cell's border was export to two or more lines.see detail in attachment
"root cause of become group shape.png"
solution
merged cell's line should be merged to a whole line,not separated line,
rewrite the filter part that export cell's line.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120730] [From Symphony] Table changes to multiple shapes after
saved in AOO
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120730
Jianyuan Li <li...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lijianyuan1983@gmail.com
--- Comment #7 from Jianyuan Li <li...@gmail.com> ---
Reviewed OK.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120730] [From Symphony] Table changes to multiple shapes after
saved in AOO
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120730
--- Comment #4 from sunying <su...@apache.org> ---
Created attachment 79360
--> https://issues.apache.org/ooo/attachment.cgi?id=79360&action=edit
UT sample file
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120730] [From Symphony] Table changes to multiple shapes after
saved in AOO
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120730
--- Comment #8 from SVN Robot <sv...@dev.null.org> ---
"sunying" committed SVN revision 1383738 into trunk:
#120730# fix table with merged cell become group shape when export ppt file
b...
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120730] [From Symphony] Table changes to multiple shapes after
saved in AOO
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120730
--- Comment #6 from sunying <su...@apache.org> ---
modify the solution of defect 1:
solution:
the core function may be depend on these position,so restore these position
when export,and does not remove the var pMergedCellIndexTable.
(In reply to comment #3)
> Actually, It is two defect:
1. The position of some merged cell's line
> display error when exported by AOO.
root cause :
The position of some
> merged cell's line have been changed when import,
and write a error
> position when export.
e.g:
2*2 table,merged 1 & 2 cell. imported by
> AOO.
_ _ _ _ _ _ _ _ _ _ _ _ _ _
|_ 1_ _|_ _2 _|
> |_ _1 _ _2 _ _|
|_ _ 3_|_ _4 _| |_ _3 _|_ 4_ _|
in funciton
> SdrPowerPointImport::CreateTable at
> "main\filter\source\msfilter\svdfppt.cxx"
line 7785: initialize
> pMergedCellIndexTable[] = {0,1,2,3},
line 7811: processed it, become
> {0,0,2,3}.
line 7842: change the positon of cell's line, the position of 2rd
> cell's line is same with 1rd cell .
in function PPTWriter::ImplCreateTable
> at file "\main\sd\source\filter\eppt\epptso.cxx"
line 5804, get the position
> of 2rd cell's line error, so display error when open by MS.
solution:
the
> cell's position should not changed.the var pMergedCellIndexTable is
> unnecessary. so remove it.
2. The table which include merged cell become a
> group shape exported by AOO.
root cause :
Merged cell's border was export
> to two or more lines.see detail in attachment "root cause of become group
> shape.png"
solution
merged cell's line should be merged to a whole
> line,not separated line,
rewrite the filter part that export cell's line.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120730] [From Symphony] Table changes to multiple shapes after
saved in AOO
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120730
sunying <su...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #9 from sunying <su...@apache.org> ---
fixed
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120730] [From Symphony] Table changes to multiple shapes after
saved in AOO
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120730
louqle <lo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
CC| |louqingle@gmail.com
--- Comment #10 from louqle <lo...@gmail.com> ---
verified on XP SP3,Win7 64 bit, mac 10.8, Ubuntu 12.04 against build r1384699
verified on RHEL 6.1 64 bit against build 1386464
fixed. Close thid bug
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120730] [From Symphony] Table changes to multiple shapes after
saved in AOO
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120730
sunying <su...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79361| |review?
Flags| |
--- Comment #5 from sunying <su...@apache.org> ---
Created attachment 79361
--> https://issues.apache.org/ooo/attachment.cgi?id=79361&action=edit
patch for export table with merged cell error
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120730] [From Symphony] Table changes to multiple shapes after
saved in AOO
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120730
Shenfeng Liu <li...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |liushenf@gmail.com
Target Milestone|--- |AOO 3.5.0
--- Comment #11 from Shenfeng Liu <li...@gmail.com> ---
Update Target Milestone to AOO 3.5.0.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120730] [From Symphony] Table changes to multiple shapes after
saved in AOO
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120730
--- Comment #2 from sunying <su...@apache.org> ---
Created attachment 79316
--> https://issues.apache.org/ooo/attachment.cgi?id=79316&action=edit
root cause of become group shape
--
You are receiving this mail because:
You are the assignee for the bug.