You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2016/02/11 00:44:38 UTC
Review Request 43456: Prevented linux fs isolator mounting rootfs for
command executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43456/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Prevented linux fs isolator mounting rootfs for command executor.
Diffs
-----
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp b9615becc87e6c69c5c56b6ae76ccae180c26917
Diff: https://reviews.apache.org/r/43456/diff/
Testing
-------
make check (ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
Re: Review Request 43456: Prevented linux fs isolator mounting rootfs
for command executor.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43456/#review118768
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 281)
<https://reviews.apache.org/r/43456/#comment180075>
Please add comments in 'ContainerConfig' stating that 'rootfs' and 'docker' is for the executor in custom executor case, and is for the task in command task case.
- Jie Yu
On Feb. 10, 2016, 11:44 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43456/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 11:44 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prevented linux fs isolator mounting rootfs for command executor.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp b9615becc87e6c69c5c56b6ae76ccae180c26917
>
> Diff: https://reviews.apache.org/r/43456/diff/
>
>
> Testing
> -------
>
> make check (ubuntu14.04 + clang-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 43456: Prevented linux fs isolator mounting rootfs
for command executor.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43456/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 4:43 p.m.)
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Prevented linux fs isolator mounting rootfs for command executor.
Diffs (updated)
-----
include/mesos/slave/isolator.proto 5a44b687253ac848e8c0a9cb97be33b61d57e215
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp b9615becc87e6c69c5c56b6ae76ccae180c26917
Diff: https://reviews.apache.org/r/43456/diff/
Testing
-------
make check (ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song