You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by yi...@apache.org on 2022/10/31 08:22:29 UTC

[doris] branch branch-1.1-lts updated: [cherry-pick](profile) Change some profile warning log to debug log (#13539) (#13813)

This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch branch-1.1-lts
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-1.1-lts by this push:
     new 263652ef9d [cherry-pick](profile) Change some profile warning log to debug log (#13539) (#13813)
263652ef9d is described below

commit 263652ef9d9ccaf7041a66bc6bda27e22588ac2a
Author: luozenglin <37...@users.noreply.github.com>
AuthorDate: Mon Oct 31 16:22:23 2022 +0800

    [cherry-pick](profile) Change some profile warning log to debug log (#13539) (#13813)
---
 .../org/apache/doris/common/profile/ProfileTreeBuilder.java    | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/common/profile/ProfileTreeBuilder.java b/fe/fe-core/src/main/java/org/apache/doris/common/profile/ProfileTreeBuilder.java
index da621b3d6a..f88961ddd5 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/common/profile/ProfileTreeBuilder.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/common/profile/ProfileTreeBuilder.java
@@ -230,12 +230,16 @@ public class ProfileTreeBuilder {
             }
         }
         if (senderNode == null || execNode == null) {
-            // TODO(cmy): This shouldn't happen, but there are sporadic errors. So I add a log to observe this error.
+            // FE will constantly update the total profile after receiving the instance profile reported by BE.
+            // Writing a profile will result in an empty instance profile until all instance profiles are received
+            // at least once.
             // Issue: https://github.com/apache/doris/issues/10095
             StringBuilder sb = new StringBuilder();
             instanceProfile.prettyPrint(sb, "");
-            LOG.warn("Invalid instance profile, sender is null: {}, execNode is null: {}, instance profile: {}",
-                    (senderNode == null), (execNode == null), sb.toString());
+            if (LOG.isDebugEnabled()) {
+                LOG.debug("Invalid instance profile, sender is null: {}, execNode is null: {}, instance profile: {}",
+                        (senderNode == null), (execNode == null), sb.toString());
+            }
             throw new UserException("Invalid instance profile, without sender or exec node: " + instanceProfile);
         }
         senderNode.addChild(execNode);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org