You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/04 12:50:46 UTC

[GitHub] [calcite] hsyuan commented on a change in pull request #2003: [CALCITE-4043] Improve IllegalArgumentException message in RelBuilder#field

hsyuan commented on a change in pull request #2003:
URL: https://github.com/apache/calcite/pull/2003#discussion_r435227331



##########
File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java
##########
@@ -487,8 +487,8 @@ public RexNode field(int inputCount, String alias, String fieldName) {
                 p.e.right.getName()));
       }
     }
-    throw new IllegalArgumentException("no aliased field found; fields are: "
-        + fields);
+    throw new IllegalArgumentException("{alias=" + alias + ",fieldName=" + fieldName + "} "

Review comment:
       nit: space after `,` in `,fieldName=`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org