You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "aleksraiden (via GitHub)" <gi...@apache.org> on 2024/04/18 19:40:14 UTC
[PR] Bump rocksdb to v9.1.0 [kvrocks]
aleksraiden opened a new pull request, #2254:
URL: https://github.com/apache/kvrocks/pull/2254
Bump rocksdb to 9.1.0. Full release notes - https://github.com/facebook/rocksdb/releases/tag/v9.1.0
**Key features**:
- On file systems that support storage level data checksum and reconstruction, retry SST block reads for point lookups, scans, and flush and compaction if there's a checksum mismatch on the initial read
- Some enhancements and fixes to experimental Temperature handling features
- WriteBatchWithIndex now supports wide-column point lookups via the GetEntityFromBatch API
- Best-effort recovery (best_efforts_recovery == true) may now be used together with atomic flush (atomic_flush == true). The all-or-nothing recovery guarantee for atomically flushed data will be upheld.
- Remove deprecated option bottommost_temperature, already replaced by last_level_temperature
- Added new PerfContext counters for block cache bytes read - block_cache_index_read_byte, block_cache_filter_read_byte, block_cache_compression_dict_read_byte, and block_cache_read_byte.
- Deprecate experimental Remote Compaction APIs
- Defined a new PerfLevel kEnableWait to measure time spent by user threads blocked in RocksDB other than mutex, such as a write thread waiting to be added to a write group, a write thread delayed or stalled etc.
- RateLimiter's API no longer requires the burst size to be the refill size
- Fixed kBlockCacheTier reads to return Status::Incomplete
- Fixed a data race in WalManager
- Re-enable the recycle_log_file_num option in DBOptions for kPointInTimeRecovery WAL recovery mode, which was previously disabled due to a bug in the recovery logic. This option is incompatible with WriteOptions::disableWAL. A Status::InvalidArgument() will be returned if disableWAL is specified.
- Java API multiGet() variants now take advantage of the underlying batched multiGet() performance improvements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump rocksdb to v9.1.1 [kvrocks]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #2254:
URL: https://github.com/apache/kvrocks/pull/2254#issuecomment-2105728502
https://github.com/apache/kvrocks/pull/2298#issuecomment-2105726276
I've meet this issue in rocksdb, sigh...Maybe we should shift to a new version later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump rocksdb to v9.1.1 [kvrocks]
Posted by "aleksraiden (via GitHub)" <gi...@apache.org>.
aleksraiden commented on PR #2254:
URL: https://github.com/apache/kvrocks/pull/2254#issuecomment-2092449573
Now we can try update from upstream and check it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump rocksdb to v9.1.1 [kvrocks]
Posted by "torwig (via GitHub)" <gi...@apache.org>.
torwig commented on PR #2254:
URL: https://github.com/apache/kvrocks/pull/2254#issuecomment-2084333565
@git-hulk @PragmaTwice I need your superpower here when you have time. Please take a look at the build error. I tried to figure out the reason but failed. Just a regular RocksDB code was changed between 9.1.0 and 9.1.1 but the error somehow appeared.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump rocksdb to v9.1.1 [kvrocks]
Posted by "aleksraiden (via GitHub)" <gi...@apache.org>.
aleksraiden commented on PR #2254:
URL: https://github.com/apache/kvrocks/pull/2254#issuecomment-2091121598
I'am fixed this bug, create at separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump rocksdb to v9.1.1 [kvrocks]
Posted by "aleksraiden (via GitHub)" <gi...@apache.org>.
aleksraiden commented on PR #2254:
URL: https://github.com/apache/kvrocks/pull/2254#issuecomment-2071692607
Update: bump rocksdb to 9.1.1 (bugfix release - https://github.com/facebook/rocksdb/releases/tag/v9.1.1)
- Fixed a regression when ColumnFamilyOptions::max_successive_merges > 0 where the CPU overhead for deciding whether to merge could have increased unless the user had set the option ColumnFamilyOptions::strict_max_successive_merges
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump rocksdb to v9.1.1 [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice closed pull request #2254: Bump rocksdb to v9.1.1
URL: https://github.com/apache/kvrocks/pull/2254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump rocksdb to v9.1.1 [kvrocks]
Posted by "aleksraiden (via GitHub)" <gi...@apache.org>.
aleksraiden commented on PR #2254:
URL: https://github.com/apache/kvrocks/pull/2254#issuecomment-2089864314
Maybe can help us - https://github.com/jemalloc/jemalloc/issues/778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump rocksdb to v9.1.1 [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #2254:
URL: https://github.com/apache/kvrocks/pull/2254#issuecomment-2142300442
succeeded by #2327.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump rocksdb to v9.1.1 [kvrocks]
Posted by "aleksraiden (via GitHub)" <gi...@apache.org>.
aleksraiden commented on PR #2254:
URL: https://github.com/apache/kvrocks/pull/2254#issuecomment-2106193627
> [#2298 (comment)](https://github.com/apache/kvrocks/pull/2298#issuecomment-2105726276)
>
> I've meet this issue in rocksdb, sigh...Maybe we should shift to a new version later?
Yeah, I'am waiting an next release of rocksdb at a week... and update PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump rocksdb to v9.1.1 [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #2254:
URL: https://github.com/apache/kvrocks/pull/2254#issuecomment-2084341797
@torwig Sure, thanks for your investigation. I'm not sure if it's related to the musl library since other CI cases are good. Will take a look when I get time, maybe @PragmaTwice is an expert on this 😎
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump rocksdb to v9.1.1 [kvrocks]
Posted by "aleksraiden (via GitHub)" <gi...@apache.org>.
aleksraiden commented on PR #2254:
URL: https://github.com/apache/kvrocks/pull/2254#issuecomment-2093479339
Hmm, not working, like a mystic )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org