You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/10/27 02:10:40 UTC

[GitHub] [iotdb] SilverNarcissus commented on a change in pull request #1337: [IOTDB-746] Add async insertion interfaces in Session and SessionPool

SilverNarcissus commented on a change in pull request #1337:
URL: https://github.com/apache/iotdb/pull/1337#discussion_r512373335



##########
File path: session/src/main/java/org/apache/iotdb/session/Session.java
##########
@@ -68,7 +68,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public class Session {
+public class Session extends AsyncSession {

Review comment:
       Session extends AsyncSession violate the LSP. Consider to use combination rather than inherit
   
   
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org