You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jerryshao <gi...@git.apache.org> on 2015/09/04 08:11:10 UTC
[GitHub] spark pull request: [SPARK-5681][Streaming] Move 'stopReceivers' t...
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/6294#issuecomment-137656481
Hi @tdas and @zsxwing , is it feasible to back port this patch to branch 1.4? This patch fixes a restart issue here by updating the state before calling `receiver.onStart()`.
```scala
if (onReceiverStart()) {
logInfo("Starting receiver")
receiverState = Started
receiver.onStart()
logInfo("Called receiver onStart")
```
Previously this state is updated after calling `recevier.onStart()`, still will introduce annoying bug in `SocketReceiver` when `restart()` is called.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org