You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "oliveigah (via GitHub)" <gi...@apache.org> on 2023/05/06 08:38:01 UTC
[GitHub] [kafka] oliveigah opened a new pull request, #13680: MINOR: Add "versions" tag to recently added ReplicaState field on Fetch Request
oliveigah opened a new pull request, #13680:
URL: https://github.com/apache/kafka/pull/13680
While running a parser for the new version of kafka commons in order to generate some assets for a kafka protocol library in other language. I've noticed that the recently added `ReplicaState` attribute on Fetch request is the only one that does not have a `versions` tag.
Since my parser was relying on the existence of this tag for every field, it failed. I wonder if it is the expected state or if it is indeed a mistake.
Anyway I've update the parser in order to use `taggedVersions` as a fallback when `versions` are not found. It works for me now.
If this is the proper state of the file, please let me know!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] oliveigah commented on a diff in pull request #13680: MINOR: Add "versions" tag to recently added ReplicaState field on Fetch Request
Posted by "oliveigah (via GitHub)" <gi...@apache.org>.
oliveigah commented on code in PR #13680:
URL: https://github.com/apache/kafka/pull/13680#discussion_r1214190810
##########
clients/src/main/resources/common/message/FetchRequest.json:
##########
@@ -61,7 +61,7 @@
"about": "The clusterId if known. This is used to validate metadata fetches prior to broker registration." },
{ "name": "ReplicaId", "type": "int32", "versions": "0-14", "default": "-1", "entityType": "brokerId",
"about": "The broker ID of the follower, of -1 if this request is from a consumer." },
- { "name": "ReplicaState", "type": "ReplicaState", "taggedVersions":"15+", "tag": 1, "fields": [
+ { "name": "ReplicaState", "type": "ReplicaState", "versions": "15+", "taggedVersions":"15+", "tag": 1, "fields": [
Review Comment:
Typo fixed! Thanks for the explanation @dajac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on a diff in pull request #13680: MINOR: Add "versions" tag to recently added ReplicaState field on Fetch Request
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #13680:
URL: https://github.com/apache/kafka/pull/13680#discussion_r1214151118
##########
clients/src/main/resources/common/message/FetchRequest.json:
##########
@@ -61,7 +61,7 @@
"about": "The clusterId if known. This is used to validate metadata fetches prior to broker registration." },
{ "name": "ReplicaId", "type": "int32", "versions": "0-14", "default": "-1", "entityType": "brokerId",
"about": "The broker ID of the follower, of -1 if this request is from a consumer." },
- { "name": "ReplicaState", "type": "ReplicaState", "taggedVersions":"15+", "tag": 1, "fields": [
+ { "name": "ReplicaState", "type": "ReplicaState", "versions": "15+", "taggedVersions":"15+", "tag": 1, "fields": [
Review Comment:
While we are here, there is a small type. A space is missing here `"taggedVersions": "15+"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac merged pull request #13680: MINOR: Add "versions" tag to recently added ReplicaState field on Fetch Request
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac merged PR #13680:
URL: https://github.com/apache/kafka/pull/13680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #13680: MINOR: Add "versions" tag to recently added ReplicaState field on Fetch Request
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #13680:
URL: https://github.com/apache/kafka/pull/13680#issuecomment-1560795936
@CalvinConfluent thoughts on this one? I am not very much familiar with difference between taggedVersions and versions field and am looking forward to understand the difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org