You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/27 10:59:36 UTC

[GitHub] [airflow] potiuk opened a new pull request #9545: Make Production Dockerfile OpenShift-compatible

potiuk opened a new pull request #9545:
URL: https://github.com/apache/airflow/pull/9545


   OpenShift (and other Kubernetes platforms) often use the approach
   that they start containers with random user and root group. This is
   described in the https://docs.openshift.com/container-platform/3.7/creating_images/guidelines.html
   
   All the files created by the "airflow" user are now belonging to
   'root' group and the root group has the same access to those
   files as the Airflow user.
   
   Additionally, the random user gets automatically added
   /etc/passwd entry which is name 'default'. The name of the user
   can be set by setting the USER_NAME variable when starting the
   container.
   
   Closes #9248
   Closes #8706
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Target Github ISSUE in description if exists
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk edited a comment on pull request #9545: Make Production Dockerfile OpenShift-compatible

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #9545:
URL: https://github.com/apache/airflow/pull/9545#issuecomment-650543567


   cc @altunbaratli @flymg 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #9545: Make Production Dockerfile OpenShift-compatible

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9545:
URL: https://github.com/apache/airflow/pull/9545#issuecomment-650710311


   @NBardelot  @flymg Can you look at it Does it meet your expectations?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #9545: Make Production Dockerfile OpenShift-compatible

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #9545:
URL: https://github.com/apache/airflow/pull/9545


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj removed a comment on pull request #9545: Make Production Dockerfile OpenShift-compatible

Posted by GitBox <gi...@apache.org>.
mik-laj removed a comment on pull request #9545:
URL: https://github.com/apache/airflow/pull/9545#issuecomment-650710311


   @NBardelot  @flymg Can you look at it Does it meet your expectations?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #9545: Make Production Dockerfile OpenShift-compatible

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9545:
URL: https://github.com/apache/airflow/pull/9545#issuecomment-650543567


   cc @altunbarati @flymg 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org