You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2020/10/09 11:55:40 UTC
[kudu-CR] KUDU-3198: fix encodeRow() when encoding delete operations
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16571
Change subject: KUDU-3198: fix encodeRow() when encoding delete operations
......................................................................
KUDU-3198: fix encodeRow() when encoding delete operations
Before this patch, not all non-key columns are cleared when
encoding delete row operations. If users delele with full row
from a 64 column table, the operation would fail.
Change-Id: I144e1998b99be3e660b7f320c55e4b1c9753a61f
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
2 files changed, 50 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/16571/1
--
To view, visit http://gerrit.cloudera.org:8080/16571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I144e1998b99be3e660b7f320c55e4b1c9753a61f
Gerrit-Change-Number: 16571
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[kudu-CR] KUDU-3198: fix encodeRow() when encoding delete operations
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16571 )
Change subject: KUDU-3198: fix encodeRow() when encoding delete operations
......................................................................
KUDU-3198: fix encodeRow() when encoding delete operations
Before this patch, not all non-key columns are cleared when
encoding delete row operations. If users delele with full row
from a 64 column table, the operation would fail.
Change-Id: I144e1998b99be3e660b7f320c55e4b1c9753a61f
Reviewed-on: http://gerrit.cloudera.org:8080/16571
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
2 files changed, 50 insertions(+), 2 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I144e1998b99be3e660b7f320c55e4b1c9753a61f
Gerrit-Change-Number: 16571
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3198: fix encodeRow() when encoding delete operations
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16571 )
Change subject: KUDU-3198: fix encodeRow() when encoding delete operations
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I144e1998b99be3e660b7f320c55e4b1c9753a61f
Gerrit-Change-Number: 16571
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 09 Oct 2020 19:06:31 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3198: fix encodeRow() when encoding delete operations
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: KUDU-3198: fix encodeRow() when encoding delete operations
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I144e1998b99be3e660b7f320c55e4b1c9753a61f
Gerrit-Change-Number: 16571
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3198: fix encodeRow() when encoding delete operations
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16571 )
Change subject: KUDU-3198: fix encodeRow() when encoding delete operations
......................................................................
Patch Set 1: Verified+1 Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16571/1/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
File java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java:
http://gerrit.cloudera.org:8080/#/c/16571/1/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java@369
PS1, Line 369: columnsBitSet.clear(schema.getPrimaryKeyColumnCount(), columnsBitSet.size());
Good catch, the docs on BitSet say that `toIndex` on `Bitset.clear(fromIndex, toIndex)` should be the "index after the last bit to be cleared"
--
To view, visit http://gerrit.cloudera.org:8080/16571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I144e1998b99be3e660b7f320c55e4b1c9753a61f
Gerrit-Change-Number: 16571
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 09 Oct 2020 18:55:54 +0000
Gerrit-HasComments: Yes