You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "AlenkaF (via GitHub)" <gi...@apache.org> on 2025/03/25 13:00:20 UTC
[PR] GH-45922: [C++][Flight] Remove deprecated Authenticate and StartCall [arrow]
AlenkaF opened a new pull request, #45932:
URL: https://github.com/apache/arrow/pull/45932
### Rationale for this change
[Authenticate](https://github.com/apache/arrow/blob/c124bb55d993daca93742ce896869ab3101dccbb/cpp/src/arrow/flight/server_auth.h#L76) and [StartCall](https://github.com/apache/arrow/blob/c124bb55d993daca93742ce896869ab3101dccbb/cpp/src/arrow/flight/server_middleware.h#L94) have been deprecated in 13.0.0 and can now be removed.
### What changes are included in this PR?
`ServerAuthHandler.Authenticate` and `ServerMiddlewareFactory.StartCall` versions without `ServerCallContext` are removed.
### Are these changes tested?
Existing tests should pass.
### Are there any user-facing changes?
Deprecated Flight functionality is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45922: [C++][Flight] Remove deprecated Authenticate and StartCall [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #45932:
URL: https://github.com/apache/arrow/pull/45932#discussion_r2016720006
##########
python/pyarrow/src/arrow/python/flight.cc:
##########
@@ -37,7 +37,8 @@ PyServerAuthHandler::PyServerAuthHandler(PyObject* handler,
handler_.reset(handler);
}
-Status PyServerAuthHandler::Authenticate(arrow::flight::ServerAuthSender* outgoing,
+Status PyServerAuthHandler::Authenticate(const arrow::flight::ServerCallContext& context,
+ arrow::flight::ServerAuthSender* outgoing,
Review Comment:
Ok, I am a little confused. What is wrong with the current code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45922: [C++][Flight] Remove deprecated Authenticate and StartCall [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #45932:
URL: https://github.com/apache/arrow/pull/45932#issuecomment-2758427602
@github-actions crossbow submit -g cpp -g python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45922: [C++][Flight] Remove deprecated Authenticate and StartCall [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #45932:
URL: https://github.com/apache/arrow/pull/45932#discussion_r2016608178
##########
python/pyarrow/src/arrow/python/flight.cc:
##########
@@ -37,7 +37,8 @@ PyServerAuthHandler::PyServerAuthHandler(PyObject* handler,
handler_.reset(handler);
}
-Status PyServerAuthHandler::Authenticate(arrow::flight::ServerAuthSender* outgoing,
+Status PyServerAuthHandler::Authenticate(const arrow::flight::ServerCallContext& context,
+ arrow::flight::ServerAuthSender* outgoing,
Review Comment:
Is it not possible to update the C++ binding without updating the Python part?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45922: [C++][Flight] Remove deprecated Authenticate and StartCall [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF merged PR #45932:
URL: https://github.com/apache/arrow/pull/45932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45922: [C++][Flight] Remove deprecated Authenticate and StartCall [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #45932:
URL: https://github.com/apache/arrow/pull/45932#discussion_r2016756675
##########
python/pyarrow/src/arrow/python/flight.cc:
##########
@@ -37,7 +37,8 @@ PyServerAuthHandler::PyServerAuthHandler(PyObject* handler,
handler_.reset(handler);
}
-Status PyServerAuthHandler::Authenticate(arrow::flight::ServerAuthSender* outgoing,
+Status PyServerAuthHandler::Authenticate(const arrow::flight::ServerCallContext& context,
+ arrow::flight::ServerAuthSender* outgoing,
Review Comment:
Aha, sorry, misunderstood. Will merge as is then. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45922: [C++][Flight] Remove deprecated Authenticate and StartCall [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #45932:
URL: https://github.com/apache/arrow/pull/45932#discussion_r2016708226
##########
python/pyarrow/src/arrow/python/flight.cc:
##########
@@ -37,7 +37,8 @@ PyServerAuthHandler::PyServerAuthHandler(PyObject* handler,
handler_.reset(handler);
}
-Status PyServerAuthHandler::Authenticate(arrow::flight::ServerAuthSender* outgoing,
+Status PyServerAuthHandler::Authenticate(const arrow::flight::ServerCallContext& context,
+ arrow::flight::ServerAuthSender* outgoing,
Review Comment:
No, I get errors when building PyArrow:
```
In file included from /Users/alenkafrim/Repos/arrow/python/pyarrow/src/arrow/python/flight.cc:21:
/Users/alenkafrim/Repos/arrow/python/pyarrow/src/arrow/python/flight.h:118:66: error: non-virtual member function marked 'override' hides virtual member function
arrow::flight::ServerAuthReader* incoming) override;
^
/Users/alenkafrim/Repos/dist/include/arrow/flight/server_auth.h:63:18: note: hidden overloaded virtual function 'arrow::flight::ServerAuthHandler::Authenticate' declared here: different number of parameters (3 vs 2)
virtual Status Authenticate(const ServerCallContext& context,
^
In file included from /Users/alenkafrim/Repos/arrow/python/pyarrow/src/arrow/python/flight.cc:21:
/Users/alenkafrim/Repos/arrow/python/pyarrow/src/arrow/python/flight.h:229:82: error: non-virtual member function marked 'override' hides virtual member function
std::shared_ptr<arrow::flight::ServerMiddleware>* middleware) override;
^
/Users/alenkafrim/Repos/dist/include/arrow/flight/server_middleware.h:77:18: note: hidden overloaded virtual function 'arrow::flight::ServerMiddlewareFactory::StartCall' declared here: type mismatch at 2nd parameter ('const ServerCallContext &' vs 'const arrow::flight::CallHeaders &' (aka 'const multimap<basic_string_view<char>, basic_string_view<char>> &'))
virtual Status StartCall(const CallInfo& info, const ServerCallContext& context,
^
/Users/alenkafrim/Repos/arrow/python/pyarrow/src/arrow/python/flight.cc:40:29: error: out-of-line definition of 'Authenticate' does not match any declaration in 'arrow::py::flight::PyServerAuthHandler'
Status PyServerAuthHandler::Authenticate(const arrow::flight::ServerCallContext& context,
^~~~~~~~~~~~
3 errors generated.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45922: [C++][Flight] Remove deprecated Authenticate and StartCall [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #45932:
URL: https://github.com/apache/arrow/pull/45932#issuecomment-2761337472
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 618ef501a21375abfaeee19e393eb64dee83ef0d.
None of the specified runs were found on the Conbench server.
The [full Conbench report](https://github.com/apache/arrow/runs/39587008254) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45922: [C++][Flight] Remove deprecated Authenticate and StartCall [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #45932:
URL: https://github.com/apache/arrow/pull/45932#issuecomment-2760848697
Emscripten and AppVeyor failures are not related. Plan to merge later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45922: [C++][Flight] Remove deprecated Authenticate and StartCall [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #45932:
URL: https://github.com/apache/arrow/pull/45932#discussion_r2013046793
##########
python/pyarrow/src/arrow/python/flight.cc:
##########
@@ -37,7 +37,8 @@ PyServerAuthHandler::PyServerAuthHandler(PyObject* handler,
handler_.reset(handler);
}
-Status PyServerAuthHandler::Authenticate(arrow::flight::ServerAuthSender* outgoing,
+Status PyServerAuthHandler::Authenticate(const arrow::flight::ServerCallContext& context,
+ arrow::flight::ServerAuthSender* outgoing,
Review Comment:
Yeah, we would have to update the Python API as well (and do a similar deprecation cycle)
##########
python/pyarrow/src/arrow/python/flight.cc:
##########
@@ -37,7 +37,8 @@ PyServerAuthHandler::PyServerAuthHandler(PyObject* handler,
handler_.reset(handler);
}
-Status PyServerAuthHandler::Authenticate(arrow::flight::ServerAuthSender* outgoing,
+Status PyServerAuthHandler::Authenticate(const arrow::flight::ServerCallContext& context,
+ arrow::flight::ServerAuthSender* outgoing,
Review Comment:
That said if there's not demand for it we can just leave it as-is for now...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45922: [C++][Flight] Remove deprecated Authenticate and StartCall [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45932:
URL: https://github.com/apache/arrow/pull/45932#issuecomment-2758437691
Revision: c6d4f821ed0f58584cfa41e9234d134306a8d4a0
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d78175be76](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d78175be76)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166165/job/39526509691)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/14110165579/job/39526505179)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/14110165756/job/39526505680)|
|example-python-minimal-build-fedora-conda|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166353/job/39526511801)|
|example-python-minimal-build-ubuntu-venv|[](https://github.com/ursacomputing/crossbow/actions/runs/14110165818/job/39526506553)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14110165710/job/39526504962)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/14110167264/job/39526519829)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166445/job/39526511835)|
|test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14110165809/job/39526506403)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/14110165328/job/39526503230)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166049/job/39526507921)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/14110165400/job/39526504237)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/14110165813/job/39526505072)|
|test-conda-python-3.10-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/14110165745/job/39526505806)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/14110165865/job/39526506444)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/14110167260/job/39526516848)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/14110165265/job/39526502138)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166758/job/39526514727)|
|test-conda-python-3.11-pandas-latest-numpy-1.26|[](https://github.com/ursacomputing/crossbow/actions/runs/14110165278/job/39526502109)|
|test-conda-python-3.11-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/14110165137/job/39526501985)|
|test-conda-python-3.11-pandas-nightly-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166869/job/39526516783)|
|test-conda-python-3.11-pandas-upstream_devel-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166781/job/39526515159)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166382/job/39526511854)|
|test-conda-python-3.12|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166828/job/39526516339)|
|test-conda-python-3.12-cpython-debug|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166115/job/39526507982)|
|test-conda-python-3.13|[](https://github.com/ursacomputing/crossbow/actions/runs/14110165903/job/39526506869)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/14110165310/job/39526502091)|
|test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166350/job/39526510328)|
|test-conda-python-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/14110167348/job/39526519842)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166147/job/39526509765)|
|test-cuda-python-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166782/job/39526516321)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166050/job/39526507931)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166169/job/39526509816)|
|test-debian-12-python-3-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14110165390/job/39526504296)|
|test-debian-12-python-3-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166813/job/39526516318)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166291/job/39526509825)|
|test-fedora-39-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166472/job/39526512262)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166784/job/39526515259)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166803/job/39526515873)|
|test-ubuntu-22.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/14110165928/job/39526506860)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166817/job/39526516330)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/14110165616/job/39526506437)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166800/job/39526515835)|
|test-ubuntu-22.04-python-313-freethreading|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166788/job/39526515269)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166789/job/39526514736)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166448/job/39526511885)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/14110165665/job/39526505371)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166776/job/39526515266)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/14110165369/job/39526503252)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166778/job/39526515813)|
|test-ubuntu-24.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/14110166798/job/39526515755)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45922: [C++][Flight] Remove deprecated Authenticate and StartCall [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #45932:
URL: https://github.com/apache/arrow/pull/45932#issuecomment-2760559258
@github-actions crossbow submit test-debian-12-python-3-i386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45922: [C++][Flight] Remove deprecated Authenticate and StartCall [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45932:
URL: https://github.com/apache/arrow/pull/45932#issuecomment-2760563559
Revision: f1d71f486670ad939f5e3bcc3fca81bf7c4ab61d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f95b9094b7](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f95b9094b7)
|Task|Status|
|----|------|
|test-debian-12-python-3-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/14125083215/job/39572324177)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45922: [C++][Flight] Remove deprecated Authenticate and StartCall [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #45932:
URL: https://github.com/apache/arrow/pull/45932#discussion_r2016546565
##########
python/pyarrow/src/arrow/python/flight.cc:
##########
@@ -37,7 +37,8 @@ PyServerAuthHandler::PyServerAuthHandler(PyObject* handler,
handler_.reset(handler);
}
-Status PyServerAuthHandler::Authenticate(arrow::flight::ServerAuthSender* outgoing,
+Status PyServerAuthHandler::Authenticate(const arrow::flight::ServerCallContext& context,
+ arrow::flight::ServerAuthSender* outgoing,
Review Comment:
Leaving it as-is for now (the Python part) makes sense. The issue is that the `Authenticate` method in `PyServerAuthHandler` is overriding the one in C++ and so the signatures have to match already, _I think_. Maybe I can do a deprecation cycle for the Python part and leave this PR open till we are ready to remove it all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45922: [C++][Flight] Remove deprecated Authenticate and StartCall [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #45932:
URL: https://github.com/apache/arrow/pull/45932#discussion_r2016720673
##########
python/pyarrow/src/arrow/python/flight.cc:
##########
@@ -37,7 +37,8 @@ PyServerAuthHandler::PyServerAuthHandler(PyObject* handler,
handler_.reset(handler);
}
-Status PyServerAuthHandler::Authenticate(arrow::flight::ServerAuthSender* outgoing,
+Status PyServerAuthHandler::Authenticate(const arrow::flight::ServerCallContext& context,
+ arrow::flight::ServerAuthSender* outgoing,
Review Comment:
I am saying we just leave things as-is in this PR. THe Python side can't use the full ServerCallContext, that's OK for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45922: [C++][Flight] Remove deprecated Authenticate and StartCall [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #45932:
URL: https://github.com/apache/arrow/pull/45932#discussion_r2012274359
##########
python/pyarrow/src/arrow/python/flight.cc:
##########
@@ -37,7 +37,8 @@ PyServerAuthHandler::PyServerAuthHandler(PyObject* handler,
handler_.reset(handler);
}
-Status PyServerAuthHandler::Authenticate(arrow::flight::ServerAuthSender* outgoing,
+Status PyServerAuthHandler::Authenticate(const arrow::flight::ServerCallContext& context,
+ arrow::flight::ServerAuthSender* outgoing,
Review Comment:
I am not sure about the changes in Python C++. We are not using the server call context and probably should?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org