[jira] [Comment Edited] (KAFKA-3346) Rename "Mode" to "SslMode"

["Ismael Juma (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184069#comment-15184069 ] 

Ismael Juma edited comment on KAFKA-3346 at 3/8/16 12:13 AM:
-------------------------------------------------------------

That's true, it's also used to decide whether to create a `SaslClientAuthenticator` or `SaslServerAuthenticator` (and SSL mode for SASL_SSL). `ConnectionMode` may be better, not sure. Whatever we do, we should at least document it. :)


was (Author: ijuma):
That's true, it's also used to decide whether to create a `SaslClientAuthenticator` or `SaslServerAuthenticator` (and for SASL_SSL, for the SSL part as well). `ConnectionMode` may be better, not sure. Whatever we do, we should at least document it. :)

> Rename "Mode" to "SslMode"
> --------------------------
>
>                 Key: KAFKA-3346
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3346
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Gwen Shapira
>
> In the channel builders, the Mode enum is undocumented, so it is unclear that it is used to signify whether the connection is for SSL client or SSL server.
> I suggest renaming to SslMode (although adding documentation will be ok too, if people object to the rename)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)