You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2019/10/10 21:28:13 UTC
[GitHub] [lucene-solr] msokolov commented on a change in pull request #935:
LUCENE-4056: Japanese Tokenizer (Kuromoji) cannot build UniDic dictionary
msokolov commented on a change in pull request #935: LUCENE-4056: Japanese Tokenizer (Kuromoji) cannot build UniDic dictionary
URL: https://github.com/apache/lucene-solr/pull/935#discussion_r333743311
##########
File path: lucene/analysis/kuromoji/ivy.xml
##########
@@ -19,19 +19,23 @@
<ivy-module version="2.0">
<info organisation="org.apache.lucene" module="analyzers-kuromoji"/>
- <configurations defaultconfmapping="ipadic->default;naist->default"> <!-- 'master' conf not available to map to -->
+ <configurations defaultconfmapping="ipadic->default;naist->default;unidic->default"> <!-- 'master' conf not available to map to -->
<conf name="default" description="explicitly declare this configuration in order to not download dictionaries unless explicitly called for"/>
<conf name="ipadic" description="ipadic dictionary" transitive="false"/>
<conf name="naist" description="naist-jdic dictionary" transitive="false"/>
+ <conf name="unidic" description="unidic dictionary" transitive="false"/>
</configurations>
<dependencies>
- <dependency org="mecab" name="mecab-ipadic" rev="${/mecab/mecab-ipadic}" conf="ipadic">
+ <dependency org="mecab" name="mecab-ipadic" rev="${/mecab/mecab-ipadic}" conf="ipadic">
<artifact name="ipadic" type=".tar.gz" url="https://jaist.dl.sourceforge.net/project/mecab/mecab-ipadic/2.7.0-20070801/mecab-ipadic-2.7.0-20070801.tar.gz"/>
</dependency>
<dependency org="mecab" name="mecab-naist-jdic" rev="${/mecab/mecab-naist-jdic}" conf="naist">
<artifact name="mecab-naist-jdic" type=".tar.gz" url=" https://rwthaachen.dl.osdn.jp/naist-jdic/53500/mecab-naist-jdic-0.6.3b-20111013.tar.gz"/>
</dependency>
+ <dependency org="mecab" name="mecab-unidic" rev="${/mecab/mecab-unidic}" conf="unidic">
+ <artifact name="unidic" type=".zip" url=" http://ja.osdn.net/frs/redir.php?m=iij&f=unidic%2F58338%2Funidic-mecab-2.1.2_src.zip"/>
Review comment:
If we download external files we must somewhere include a license demonstrating that those files are positively licensed for re-use, ideally with some recognized open source license. Do you know what the status is of this source for unidic? What is osdn.net?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org