You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ableegoldman (via GitHub)" <gi...@apache.org> on 2023/01/23 23:34:02 UTC

[GitHub] [kafka] ableegoldman commented on a diff in pull request #13155: [DO NOT MERGE] KAFKA-14533: re-enable the 'false' parameter of SmokeTestDriverIntegrationTest

ableegoldman commented on code in PR #13155:
URL: https://github.com/apache/kafka/pull/13155#discussion_r1084678438


##########
streams/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java:
##########
@@ -96,9 +96,8 @@ SmokeTestDriver.VerificationResult result() {
 
     private static Stream<Boolean> parameters() {
         return Stream.of(
-            // TODO KAFKA-14533: debug and re-enable both parameters
-            Boolean.TRUE
-            //Boolean.FALSE
+            Boolean.FALSE,

Review Comment:
   For some additional data I also swapped the order of the two parameters, in case that happens to reveal something about the underlying source of failure here 🤷‍♀️ 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org