You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/06/10 20:11:42 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4289:
Cleaning up getTableName() for segment metadata
codecov-io edited a comment on issue #4289: Cleaning up getTableName() for segment metadata
URL: https://github.com/apache/incubator-pinot/pull/4289#issuecomment-499923396
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4289?src=pr&el=h1) Report
> Merging [#4289](https://codecov.io/gh/apache/incubator-pinot/pull/4289?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/75667900a7ad4739069aa2220b778ab7d7b12a6b?src=pr&el=desc) will **decrease** coverage by `0.2%`.
> The diff coverage is `84.48%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4289?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4289 +/- ##
============================================
- Coverage 67.29% 67.09% -0.21%
Complexity 20 20
============================================
Files 1040 1041 +1
Lines 51662 51713 +51
Branches 7238 7247 +9
============================================
- Hits 34767 34696 -71
- Misses 14507 14651 +144
+ Partials 2388 2366 -22
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4289?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...re/segment/virtualcolumn/VirtualColumnContext.java](https://codecov.io/gh/apache/incubator-pinot/pull/4289/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vVmlydHVhbENvbHVtbkNvbnRleHQuamF2YQ==) | `100% <ø> (+8.33%)` | `0 <0> (ø)` | :arrow_down: |
| [...helix/core/sharding/BucketizedSegmentStrategy.java](https://codecov.io/gh/apache/incubator-pinot/pull/4289/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3NoYXJkaW5nL0J1Y2tldGl6ZWRTZWdtZW50U3RyYXRlZ3kuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../pinot/controller/api/upload/SegmentValidator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4289/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvdXBsb2FkL1NlZ21lbnRWYWxpZGF0b3IuamF2YQ==) | `65.38% <100%> (-0.66%)` | `0 <0> (ø)` | |
| [...indexsegment/immutable/ImmutableSegmentLoader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4289/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvaW1tdXRhYmxlL0ltbXV0YWJsZVNlZ21lbnRMb2FkZXIuamF2YQ==) | `92.15% <100%> (-0.16%)` | `0 <0> (ø)` | |
| [.../core/indexsegment/mutable/MutableSegmentImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4289/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvbXV0YWJsZS9NdXRhYmxlU2VnbWVudEltcGwuamF2YQ==) | `81.04% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...apache/pinot/controller/api/upload/ZKOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4289/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvdXBsb2FkL1pLT3BlcmF0b3IuamF2YQ==) | `72.52% <100%> (-0.3%)` | `0 <0> (ø)` | |
| [.../sharding/BalanceNumSegmentAssignmentStrategy.java](https://codecov.io/gh/apache/incubator-pinot/pull/4289/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3NoYXJkaW5nL0JhbGFuY2VOdW1TZWdtZW50QXNzaWdubWVudFN0cmF0ZWd5LmphdmE=) | `90.62% <100%> (-0.29%)` | `0 <0> (ø)` | |
| [...harding/ReplicaGroupSegmentAssignmentStrategy.java](https://codecov.io/gh/apache/incubator-pinot/pull/4289/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3NoYXJkaW5nL1JlcGxpY2FHcm91cFNlZ21lbnRBc3NpZ25tZW50U3RyYXRlZ3kuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ntroller/helix/core/PinotHelixResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4289/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1Bpbm90SGVsaXhSZXNvdXJjZU1hbmFnZXIuamF2YQ==) | `62.51% <100%> (-0.7%)` | `0 <0> (ø)` | |
| [...pache/pinot/minion/executor/PurgeTaskExecutor.java](https://codecov.io/gh/apache/incubator-pinot/pull/4289/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhlY3V0b3IvUHVyZ2VUYXNrRXhlY3V0b3IuamF2YQ==) | `69.56% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [37 more](https://codecov.io/gh/apache/incubator-pinot/pull/4289/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4289?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4289?src=pr&el=footer). Last update [7566790...2cb74a1](https://codecov.io/gh/apache/incubator-pinot/pull/4289?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org