[GitHub] [iotdb] jixuan1989 commented on a diff in pull request #7462: Add new sampling algorithm largest triangle to sample UDF

[GitBox <gi...@apache.org>]

jixuan1989 commented on code in PR #7462:
URL: https://github.com/apache/iotdb/pull/7462#discussion_r990637666


##########
library-udf/pom.xml:
##########
@@ -27,6 +27,23 @@
     </parent>
     <modelVersion>4.0.0</modelVersion>
     <artifactId>library-udf</artifactId>
+    <repositories>
+        <repository>
+            <id>apache.snapshots</id>
+            <name>Apache Development Snapshot Repository</name>
+            <url>https://repository.apache.org/content/repositories/snapshots/</url>
+            <releases>
+                <enabled>false</enabled>
+            </releases>
+            <snapshots>
+                <enabled>true</enabled>
+            </snapshots>
+        </repository>
+        <repository>
+            <id>jitpack.io</id>
+            <url>https://jitpack.io</url>
+        </repository>
+    </repositories>

Review Comment:
   well, we must add comments to show which dependency uses this repository.
   If it is really necessary, it is ok.
   BUT,  apache nexus snapshot repo should not be included.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org