You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/08/03 10:15:26 UTC

Re: Review Request 36990: LENS-681: add partitions api is returning SUCCESS when a single partition is attempted to add

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36990/#review93877
-----------------------------------------------------------


Can you include unit tests for the new classes added?

- Amareshwari Sriramadasu


On July 31, 2015, 3:28 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36990/
> -----------------------------------------------------------
> 
> (Updated July 31, 2015, 3:28 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-681
>     https://issues.apache.org/jira/browse/LENS-681
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/APIResult.java 6b734a9627414d7282b1319b02bd13f508e3fb45 
>   lens-api/src/main/java/org/apache/lens/api/LensSessionHandle.java b3aa584f18a207036a5f42817f03fb586c1f029f 
>   lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 06343c2f3ba0d127cae6a7dd1ca8422e3c2fbc40 
>   lens-api/src/main/java/org/apache/lens/api/jaxb/LensJAXBContext.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/jaxb/LensJAXBContextResolver.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/jaxb/LensJAXBParseException.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/jaxb/XMLValidationException.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/result/LensJAXBContextResolver.java 5b48578e077462cb96944919b3a38b867e4613ae 
>   lens-api/src/main/resources/lens-errors.conf 6130ad78c2871f78ff9bc11cca5702a538639bbf 
>   lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 169170c350e5eaac6b952752026628affebac07d 
>   lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 4699dbb1cc3243cf0e5dedcfa16ddce3c617d24a 
>   lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 6a2bc6b4775c18752049d884e5a523ae27b15a9c 
>   lens-server/src/main/java/org/apache/lens/server/LensServer.java 0da37ad944c426dcce046bd5443428e7b4438c39 
>   lens-server/src/main/java/org/apache/lens/server/error/XMLExceptionMapper.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7ef804624711e89ef981b83a6576cbc9dc00fb0 
>   lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 91e908139ca556d8611dff9eb109d9620a513352 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 4b9962a9cda22002cdc4826ebce3db4c77216223 
> 
> Diff: https://reviews.apache.org/r/36990/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>