You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Abhishek Rawat (Code Review)" <ge...@cloudera.org> on 2022/03/21 22:45:26 UTC
[Impala-ASF-CR] IMPALA-11126: impala-shell: Set reasonable timeout for http client
Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18336
Change subject: IMPALA-11126: impala-shell: Set reasonable timeout for http client
......................................................................
IMPALA-11126: impala-shell: Set reasonable timeout for http client
In hs2-http mode, the connection timeout is None, which could cause
hang like symptoms in case of a problematic remote server. Setting
the default connection timeout to a reasonable value (300s), so that
client can retry, in such cases, when possible.
Testing: Ran e2e shell tests.
Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
---
M shell/ImpalaHttpClient.py
M shell/impala_client.py
M shell/impala_shell_config_defaults.py
3 files changed, 12 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/18336/2
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18336/6/shell/impala_shell.py
File shell/impala_shell.py:
http://gerrit.cloudera.org:8080/#/c/18336/6/shell/impala_shell.py@2072
PS6, Line 2072:
flake8: E129 visually indented line with same indent as next logical line
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 08:49:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 19:04:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 9:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10353/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 9
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Mar 2022 14:41:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 11: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 11
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Mar 2022 23:59:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 10
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Mar 2022 14:23:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 10: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7979/
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 10
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Mar 2022 18:55:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 19:17:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 10: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 10
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Mar 2022 14:54:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 12:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7987/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 12
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Mar 2022 00:00:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 6:
Did you run testing with problematic remote endpoint?
Code change looks good to me.
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 17:27:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 11:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10367/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 11
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Mar 2022 00:09:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 12: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 12
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Mar 2022 15:55:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 12
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Apr 2022 12:46:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 7: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7975/
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 20:42:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 8
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 23:35:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Set reasonable timeout for http client
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Set reasonable timeout for http client
......................................................................
IMPALA-11126: impala-shell: Set reasonable timeout for http client
In hs2-http mode, the connection timeout is None, which could cause
hang like symptoms in case of a problematic remote server. Setting
the default connection timeout to a reasonable value (300s), so that
client can retry, in such cases, when possible.
Testing: Ran e2e shell tests.
Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
---
M shell/ImpalaHttpClient.py
M shell/impala_client.py
M shell/impala_shell_config_defaults.py
3 files changed, 12 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/18336/4
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11126: impala-shell: Set reasonable timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Set reasonable timeout for http client
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10318/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Mar 2022 23:06:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10334/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 08:49:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 8:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7977/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 8
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 23:35:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 12: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7987/
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 12
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Mar 2022 04:44:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 9:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18336/9/shell/impala_shell.py
File shell/impala_shell.py:
http://gerrit.cloudera.org:8080/#/c/18336/9/shell/impala_shell.py@199
PS9, Line 199: !
flake8: E711 comparison to None should be 'if cond is not None:'
http://gerrit.cloudera.org:8080/#/c/18336/9/shell/impala_shell.py@2072
PS9, Line 2072:
flake8: E129 visually indented line with same indent as next logical line
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 9
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Mar 2022 14:23:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 10:
Oops, the GVO was started while I was reviewing :)
Though I would prefer to have some kind of test, I am ok with the current state being merged.
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 10
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Mar 2022 14:38:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Set reasonable timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Set reasonable timeout for http client
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18336/2/shell/impala_client.py
File shell/impala_client.py:
http://gerrit.cloudera.org:8080/#/c/18336/2/shell/impala_client.py@406
PS2, Line 406: /
flake8: E226 missing whitespace around arithmetic operator
http://gerrit.cloudera.org:8080/#/c/18336/2/shell/impala_client.py@410
PS2, Line 410: /
flake8: E226 missing whitespace around arithmetic operator
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Mar 2022 22:46:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11126: impala-shell: Set reasonable timeout for http client
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has removed a vote on this change.
Change subject: IMPALA-11126: impala-shell: Set reasonable timeout for http client
......................................................................
Removed Code-Review+2 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/18336/5/shell/impala_shell.py
File shell/impala_shell.py:
http://gerrit.cloudera.org:8080/#/c/18336/5/shell/impala_shell.py@2070
PS5, Line 2070: !
flake8: E711 comparison to None should be 'if cond is not None:'
http://gerrit.cloudera.org:8080/#/c/18336/5/shell/impala_shell.py@2071
PS5, Line 2071: 0
flake8: E501 line too long (92 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18336/5/shell/option_parser.py
File shell/option_parser.py:
http://gerrit.cloudera.org:8080/#/c/18336/5/shell/option_parser.py@276
PS5, Line 276: b
flake8: E501 line too long (98 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 08:31:12 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 8: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7977/
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 8
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Mar 2022 01:14:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 6:
I'll try to simulate a problematic remote server with and without None timeout. Also, think about if we can add a testcase somehow.
Re, the default value for '-http_socket_timeout_s', I think it will be a bit of a tuning exercise and also depends on other timeouts in the system, for instance a load balancer timeout. Some RPCs could take longer compared to others. I originally wanted to pick a default, but also don't know what a good default is :-)
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 19:14:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 10: Code-Review+1
Sure will add some tests.
The http_socket_timeout_s applies to every http connection, but we still have the behavior from before where every flush operation does a Close() and Open(), due to THRIFT-4600.
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 10
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Mar 2022 15:47:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Set reasonable timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Set reasonable timeout for http client
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10323/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Mar 2022 16:19:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Set reasonable timeout for http client
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Set reasonable timeout for http client
......................................................................
Patch Set 4:
Thanks, let me create a new config for setting timeout for http transport.
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Mar 2022 18:09:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
IMPALA-11126: impala-shell: Support configurable socket timeout for http
client
In 'hs2-http' mode, the socket timeout is None, which could cause
hang like symptoms in case of a problematic remote server.
Added support for configurable socket timeout using the new impala-shell
config option '--http_socket_timeout_s'. If a reasonable timeout is
set, impala-shell client can retry in case of connection issues, when
possible. The default value of '--http_socket_timeout_s' is set to None,
to prevent behavior changes for existing clients.
More details on socket timeout here:
https://docs.python.org/3/library/socket.html#socket-timeouts
Testing: Ran e2e shell tests.
Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
---
M shell/ImpalaHttpClient.py
M shell/impala_client.py
M shell/impala_shell.py
M shell/impala_shell_config_defaults.py
M shell/option_parser.py
5 files changed, 32 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/18336/6
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 9: Code-Review+2
carrying forward +2
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 9
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Mar 2022 14:22:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7975/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 19:04:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 7:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7976/
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 23:18:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 6:
I like the split of the options, thanks for doing that.
Code looks clean.
Regarding "The default value of '--http_socket_timeout_s' is set
to None, to prevent behavior changes for existing clients."
I understand the caution, this is definitely the safest change, but overall would users be happier if it was non-zero?
I don't know the answer, I am just asking :-)
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 18:57:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7976/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 21:38:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
IMPALA-11126: impala-shell: Support configurable socket timeout for http
client
In 'hs2-http' mode, the socket timeout is None, which could cause
hang like symptoms in case of a problematic remote server.
Added support for configurable socket timeout using the new impala-shell
config option '--http_socket_timeout_s'. If a reasonable timeout is
set, impala-shell client can retry in case of connection issues, when
possible. The default value of '--http_socket_timeout_s' is set to None,
to prevent behavior changes for existing clients.
More details on socket timeout here:
https://docs.python.org/3/library/socket.html#socket-timeouts
Testing:
- Added tests for various timeout values in test_shell_commandline.py
- Ran e2e shell tests.
Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
---
M shell/ImpalaHttpClient.py
M shell/impala_client.py
M shell/impala_shell.py
M shell/impala_shell_config_defaults.py
M shell/option_parser.py
M tests/shell/test_shell_commandline.py
6 files changed, 70 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/18336/11
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 11
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18336/8//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18336/8//COMMIT_MSG@22
PS8, Line 22: Testing: Ran e2e shell tests.
http_socket_timeout_s is None by default - can you add a test where it is set to some value?
Looked around for similar tests, and I have bumped into https://github.com/apache/impala/blob/ff21728838acd79d451959149f9adb8fdbf2798d/tests/shell/test_shell_commandline.py#L994 , which is skipped for hs2-http. Should the http_socket_timeout_s also solve the connection timeout issue?
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 8
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Mar 2022 14:34:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 6: Code-Review+2
As discussed, you will add test case later.
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 19:03:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
IMPALA-11126: impala-shell: Support configurable socket timeout for http
client
In 'hs2-http' mode, the socket timeout is None, which could cause
hang like symptoms in case of a problematic remote server.
Added support for configurable socket timeout using the new impala-shell
config option '--http_socket_timeout_s'. If a reasonable timeout is
set, impala-shell client can retry in case of connection issues, when
possible. The default value of '--http_socket_timeout_s' is set to None,
to prevent behavior changes for existing clients.
More details on socket timeout here:
https://docs.python.org/3/library/socket.html#socket-timeouts
Testing:
- Added tests for various timeout values in test_shell_commandline.py
- Ran e2e shell tests.
Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Reviewed-on: http://gerrit.cloudera.org:8080/18336
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
---
M shell/ImpalaHttpClient.py
M shell/impala_client.py
M shell/impala_shell.py
M shell/impala_shell_config_defaults.py
M shell/option_parser.py
M tests/shell/test_shell_commandline.py
6 files changed, 70 insertions(+), 9 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Wenzhe Zhou: Looks good to me, but someone else must approve
Csaba Ringhofer: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 13
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
IMPALA-11126: impala-shell: Support configurable socket timeout for http
client
In 'hs2-http' mode, the socket timeout is None, which could cause
hang like symptoms in case of a problematic remote server.
Added support for configurable socket timeout using the new impala-shell
config option '--http_socket_timeout_s'. If a reasonable timeout is
set, impala-shell client can retry in case of connection issues, when
possible. The default value of '--http_socket_timeout_s' is set to None,
to prevent behavior changes for existing clients.
More details on socket timeout here:
https://docs.python.org/3/library/socket.html#socket-timeouts
Testing: Ran e2e shell tests.
Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
---
M shell/ImpalaHttpClient.py
M shell/impala_client.py
M shell/impala_shell.py
M shell/impala_shell_config_defaults.py
M shell/option_parser.py
5 files changed, 32 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/18336/9
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 9
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 10:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7979/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 10
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Mar 2022 14:23:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 12: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 12
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Mar 2022 09:35:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 12:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7990/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 12
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Mar 2022 05:05:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Set reasonable timeout for http client
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Set reasonable timeout for http client
......................................................................
Patch Set 4: Code-Review+2
The change inside ImpalaHttpClient looks safe and isolated.
My only worry would be about changing the default value of client_connect_timeout_ms.
What do we think client_connect_timeout_ms means?
The description is "Timeout in milliseconds after which impala-shell will time out if it fails to connect to Impala server. Set to 0 to disable any timeout."
In the hs2 case this means setting a socket timeout.
And it looks like setting it to 0 should still work.
in hs2-http it mean something a bit different, in that it it is now the time that we wait for a (virtual) connection to be established. And retry is layered on top of this I think. Together these make the "time for server to startup"
So if we expect hs2-http to be the most important protocol going forward we could consider having separate parameters for hs2-http that more exactly match what we are doing.
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Mar 2022 17:53:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
IMPALA-11126: impala-shell: Support configurable socket timeout for http
client
In 'hs2-http' mode, the socket timeout is None, which could cause
hang like symptoms in case of a problematic remote server.
Added support for configurable socket timeout using the new impala-shell
config option '--http_socket_timeout_s'. If a reasonable timeout is
set, impala-shell client can retry in case of connection issues, when
possible. The default value of '--http_socket_timeout_s' is set to None,
to prevent behavior changes for existing clients.
More details on socket timeout here:
https://docs.python.org/3/library/socket.html#socket-timeouts
Testing: Ran e2e shell tests.
Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
---
M shell/ImpalaHttpClient.py
M shell/impala_client.py
M shell/impala_shell.py
M shell/impala_shell_config_defaults.py
M shell/option_parser.py
5 files changed, 31 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/18336/5
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10335/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 09:04:00 +0000
Gerrit-HasComments: No