[GitHub] [fineract] galovics commented on a diff in pull request #2505: FINERACT-1670: Rework command source to store dates in UTC

[GitBox <gi...@apache.org>]

galovics commented on code in PR #2505:
URL: https://github.com/apache/fineract/pull/2505#discussion_r943739542


##########
fineract-provider/src/main/java/org/apache/fineract/commands/domain/CommandSource.java:
##########
@@ -72,16 +71,24 @@ public class CommandSource extends AbstractPersistableCustom {
     @JoinColumn(name = "maker_id", nullable = false)
     private AppUser maker;
 
-    @Column(name = "made_on_date", nullable = false)
-    private LocalDateTime madeOnDate;
+    /*
+     * Deprecated: Columns and data left untouched to help migration.
+     *
+     * @Column(name = "made_on_date", nullable = false) private LocalDateTime madeOnDate;
+     *
+     * @Column(name = "checked_on_date", nullable = true) private LocalDateTime checkedOnDate;
+     */
+
+    @Column(name = "made_on_utc", nullable = false)
+    private OffsetDateTime madeOnDate;
+
+    @Column(name = "checked_on_utc")

Review Comment:
   Same as above.



##########
fineract-provider/src/main/java/org/apache/fineract/commands/domain/CommandSource.java:
##########
@@ -72,16 +71,24 @@ public class CommandSource extends AbstractPersistableCustom {
     @JoinColumn(name = "maker_id", nullable = false)
     private AppUser maker;
 
-    @Column(name = "made_on_date", nullable = false)
-    private LocalDateTime madeOnDate;
+    /*
+     * Deprecated: Columns and data left untouched to help migration.
+     *
+     * @Column(name = "made_on_date", nullable = false) private LocalDateTime madeOnDate;
+     *
+     * @Column(name = "checked_on_date", nullable = true) private LocalDateTime checkedOnDate;
+     */
+
+    @Column(name = "made_on_utc", nullable = false)

Review Comment:
   Since in the native query you're referring to this column as madeOnDateUtc, do you think it would make sense to name it appropriately?
   Instead of `made_on_utc` it could be `made_on_date_utc`.
   Thoughts?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org