You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:52:06 UTC

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

rhtyd commented on a change in pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#discussion_r515808469



##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
##########
@@ -824,7 +824,7 @@ private DiskProfile allocateTemplatedVolume(Type type, String name, DiskOffering
         int volumesNumber = 1;
         List<DatadiskTO> templateAsIsDisks = null;
         String configurationId = null;
-        if (template.isDeployAsIs()) {
+        if (template.isDeployAsIs() && vm.getType() != VirtualMachine.Type.SecondaryStorageVm) {

Review comment:
       Good point; @nvazquez can you check for CPVM and other systemvm types as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org