[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4431: Misc fix for controller tests

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #4431: Misc fix for controller tests
URL: https://github.com/apache/incubator-pinot/pull/4431#discussion_r303183828
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
 ##########
 @@ -1087,9 +1086,6 @@ public void addTable(@Nonnull TableConfig tableConfig)
         // lets add table configs
         ZKMetadataProvider.setOfflineTableConfig(_propertyStore, tableNameWithType, tableConfig.toZNRecord());
 
-        _propertyStore.create(ZKMetadataProvider.constructPropertyStorePathForResource(tableNameWithType),
 
 Review comment:
   We don't need to initialize this directory because it will be automatically created when the first segment gets pushed. Real-time table does not initialize this directory, so keep them consistent

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org