You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/19 07:45:53 UTC
[GitHub] [arrow-ballista] jiangzhx opened a new pull request, #572: add test_util to make examples work well
jiangzhx opened a new pull request, #572:
URL: https://github.com/apache/arrow-ballista/pull/572
# Which issue does this PR close?
add test_util to make examples work well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] jiangzhx commented on a diff in pull request #572: add test_util to make examples work well
Posted by "jiangzhx (via GitHub)" <gi...@apache.org>.
jiangzhx commented on code in PR #572:
URL: https://github.com/apache/arrow-ballista/pull/572#discussion_r1096953481
##########
ballista/core/src/lib.rs:
##########
@@ -29,6 +29,7 @@ pub mod event_loop;
pub mod execution_plans;
/// some plugins
pub mod plugin;
+pub mod test_util;
Review Comment:
thanks, i moved test_util to ballista-examples package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] jiangzhx closed pull request #572: add test_util to make examples work well
Posted by "jiangzhx (via GitHub)" <gi...@apache.org>.
jiangzhx closed pull request #572: add test_util to make examples work well
URL: https://github.com/apache/arrow-ballista/pull/572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] jiangzhx commented on pull request #572: add test_util to make examples work well
Posted by "jiangzhx (via GitHub)" <gi...@apache.org>.
jiangzhx commented on PR #572:
URL: https://github.com/apache/arrow-ballista/pull/572#issuecomment-1418529138
Check Cargo.toml got error;who can help to me to fix it.
_
Run # if you encounter error, try rerun the command below, finally run 'git diff' to
+ find . -mindepth 2 -name Cargo.toml -exec cargo tomlfmt -p '{}' ';'
INFO 2023-02-06T04:21:24Z: cargo_tomlfmt: no problem found. good job! :)
INFO 2023-02-06T04:21:24Z: cargo_tomlfmt: no problem found. good job! :)
INFO 2023-02-06T04:21:24Z: cargo_tomlfmt: no problem found. good job! :)
INFO 2023-02-06T04:21:24Z: cargo_tomlfmt: no problem found. good job! :)
INFO 2023-02-06T04:21:24Z: cargo_tomlfmt: no problem found. good job! :)
INFO 2023-02-06T04:21:24Z: cargo_tomlfmt: no problem found. good job! :)
INFO [20](https://github.com/apache/arrow-ballista/actions/runs/4100201689/jobs/7071044470#step:8:21)23-02-06T04:[21](https://github.com/apache/arrow-ballista/actions/runs/4100201689/jobs/7071044470#step:8:22):24Z: cargo_tomlfmt: no problem found. good job! :)
warning: Not a git repository. Use --no-index to compare two paths outside a working tree
usage: git diff --no-index [<options>] <path> <path>
Diff output format options
_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] avantgardnerio commented on a diff in pull request #572: add test_util to make examples work well
Posted by GitBox <gi...@apache.org>.
avantgardnerio commented on code in PR #572:
URL: https://github.com/apache/arrow-ballista/pull/572#discussion_r1081883509
##########
ballista/core/src/lib.rs:
##########
@@ -29,6 +29,7 @@ pub mod event_loop;
pub mod execution_plans;
/// some plugins
pub mod plugin;
+pub mod test_util;
Review Comment:
It seems questionable to export test dependencies as part of the main artifact. Perhaps a `#[cfg(test)]` would resolve that?
##########
examples/Cargo.toml:
##########
@@ -35,6 +35,7 @@ required-features = ["ballista/standalone"]
[dependencies]
ballista = { path = "../ballista/client", version = "0.10.0" }
+ballista-core = { path = "../ballista/core", version = "0.10.0" }
Review Comment:
Same... but `[test-dependencies]`... or maybe we need a `datafusion-test` package. I'm curious to hear what others think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org