You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/06/27 15:07:03 UTC
[GitHub] john-bodley commented on a change in pull request #5281: [SQL lab]
Fixed limit issue
john-bodley commented on a change in pull request #5281: [SQL lab] Fixed limit issue
URL: https://github.com/apache/incubator-superset/pull/5281#discussion_r198531180
##########
File path: superset/db_engine_specs.py
##########
@@ -127,8 +126,7 @@ def get_query_without_limit(cls, sql):
(?ix) # case insensitive, verbose
\s+ # whitespace
LIMIT\s+\d+ # LIMIT $ROWS
- ;? # optional semi-colon
- (\s|;)*$ # remove trailing spaces tabs or semicolons
+ (\s|;|.)*$ # remove the reset of the chars
Review comment:
https://github.com/apache/incubator-superset/pull/5295
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org