You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/12/24 08:24:56 UTC
[Bug 121544] New: [AWT] Clean-up MessageBox API
https://issues.apache.org/ooo/show_bug.cgi?id=121544
Bug ID: 121544
Issue Type: DEFECT
Summary: [AWT] Clean-up MessageBox API
Classification: Code
Product: framework
Version: AOO 3.4.1
Hardware: All
OS: All
Status: CONFIRMED
Severity: normal
Priority: P3
Component: code
Assignee: issues@openoffice.apache.org
Reporter: arielch@apache.org
CC: issues@openoffice.apache.org
Besides the IDL errors described in bug 74095 the MessageBox API has some other
shortcomings:
a) css.awt.XMessageBox is deprecated, though it is returned by
css.awt.XMessageBoxFactory.createMessageBox
b) css.awt.MessageBoxCommand is deprecated, it can be removed
c) the return type of css.awt.XMessageBox.execute() should be document with its
own constants group
d) css.awt.XMessageBoxFactory.createMessageBox() takes a css.awt.Rectangle
defining the position and size of the message box, this is completely useless
as it is ignored. The message box is always positioned in the center of its
parent window, and the size is determined by the internal implementation
e) the type of the message box in css.awt.XMessageBoxFactory.createMessageBox()
is defined by strings, what makes it rather error prone. This should be
replaced by an enumeration
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121544] [AWT] Clean-up MessageBox API
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121544
--- Comment #7 from Ariel Constenla-Haile <ar...@apache.org> ---
(In reply to hanya from comment #5)
> following files contains illegal value for preprocessor instructions:
IIRC you opened a new bug for this one, but I cannot find it right now. Please
resolve it as fixed or make it depend on this one.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121544] [AWT] Clean-up MessageBox API
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121544
brinzing <ol...@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |oliver.brinzing@gmx.de
--- Comment #4 from brinzing <ol...@gmx.de> ---
.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121544] [AWT] Clean-up MessageBox API
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121544
--- Comment #3 from SVN Robot <sv...@dev.null.org> ---
"arielch" committed SVN revision 1425715 into trunk:
i121544 - Clean-up MessageBox API (post fix)
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121544] [AWT] Clean-up MessageBox API
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121544
--- Comment #1 from SVN Robot <sv...@dev.null.org> ---
"arielch" committed SVN revision 1425608 into trunk:
i121544 - Clean-up MessageBox API
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121544] [AWT] Clean-up MessageBox API
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121544
Ariel Constenla-Haile <ar...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |74095
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121544] [AWT] Clean-up MessageBox API
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121544
Ariel Constenla-Haile <ar...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |ACCEPTED
Blocks|74095 |
Assignee|issues@openoffice.apache.or |arielch@apache.org
|g |
Target Milestone|--- |AOO 4.0
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121544] [AWT] Clean-up MessageBox API
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121544
hdu@apache.org <hd...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |122988
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 121544] [AWT] Clean-up MessageBox API
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121544
--- Comment #8 from hanya <ha...@gmail.com> ---
(In reply to Ariel Constenla-Haile from comment #7)
> (In reply to hanya from comment #5)
> > following files contains illegal value for preprocessor instructions:
>
> IIRC you opened a new bug for this one, but I cannot find it right now.
> Please resolve it as fixed or make it depend on this one.
Done in issue 121951. Thanks.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121544] [AWT] Clean-up MessageBox API
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121544
Ariel Constenla-Haile <ar...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ACCEPTED |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from Ariel Constenla-Haile <ar...@apache.org> ---
a) css.awt.MessageBoxCommand has been removed
b) css.awt.MessageBoxResults has been introduced to specify a result of
executing a css.awt.XMessageBox
c) css.awt.MessageBoxType has been introduced to specify the type of a
css.awt.XMessageBox on css.awt.XMessageBoxFactory.createMessageBox()
d) in css.awt.XMessageBox the getters and setters have been replaced by
interface attributes: CaptionText and MessageText
e) css.awt.XMessageBoxFactory.createMessageBox() no longer takes a
css.awt.Rectangle defining the position and size of the message box
f) the type of the message box in css.awt.XMessageBoxFactory.createMessageBox()
is no longer defined by strings, use css.awt.MessageBoxType instead
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121544] [AWT] Clean-up MessageBox API
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121544
--- Comment #6 from SVN Robot <sv...@dev.null.org> ---
"arielch" committed SVN revision 1487143 into trunk:
i121544 - Fix header guards
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121544] [AWT] Clean-up MessageBox API
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121544
Ariel Constenla-Haile <ar...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |74095
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121544] [AWT] Clean-up MessageBox API
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121544
hanya <ha...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hanya.runo@gmail.com
--- Comment #5 from hanya <ha...@gmail.com> ---
following files contains illegal value for preprocessor instructions:
Index: offapi/com/sun/star/awt/MessageBoxType.idl
===================================================================
--- offapi/com/sun/star/awt/MessageBoxType.idl (revision 1430225)
+++ offapi/com/sun/star/awt/MessageBoxType.idl (working copy)
@@ -19,8 +19,8 @@
*
*************************************************************/
-#ifndef __com_sun_star_awt_MessageBoxCommand_idl__
-#define __com_sun_star_awt_MessageBoxCommand_idl__
+#ifndef __com_sun_star_awt_MessageBoxType_idl__
+#define __com_sun_star_awt_MessageBoxType_idl__
module com { module sun { module star { module awt {
Index: offapi/com/sun/star/awt/MessageBoxResults.idl
===================================================================
--- offapi/com/sun/star/awt/MessageBoxResults.idl (revision 1430225)
+++ offapi/com/sun/star/awt/MessageBoxResults.idl (working copy)
@@ -19,8 +19,8 @@
*
*************************************************************/
-#ifndef __com_sun_star_awt_MessageBoxCommand_idl__
-#define __com_sun_star_awt_MessageBoxCommand_idl__
+#ifndef __com_sun_star_awt_MessageBoxResults_idl__
+#define __com_sun_star_awt_MessageBoxResults_idl__
module com { module sun { module star { module awt {
--
You are receiving this mail because:
You are on the CC list for the bug.