You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by achristianson <gi...@git.apache.org> on 2018/05/11 18:02:48 UTC

[GitHub] nifi-minifi-cpp pull request #328: MINIFICPP-474 Added getDelimitedField EL ...

GitHub user achristianson opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/328

    MINIFICPP-474 Added getDelimitedField EL function

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [x] If applicable, have you updated the LICENSE file?
    - [x] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-474

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/328.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #328
    
----
commit b17252fb09f13fefde79d61baf1555b21c0817e9
Author: Andrew I. Christianson <an...@...>
Date:   2018-05-11T14:46:55Z

    MINIFICPP-474 Added getDelimitedField EL function

----


---

[GitHub] nifi-minifi-cpp issue #328: MINIFICPP-474 Added getDelimitedField EL functio...

Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/328
  
    @phrocker Also rm -rf thirdparty/flex. It might have some junk from another PR that is no longer in git.


---

[GitHub] nifi-minifi-cpp issue #328: MINIFICPP-474 Added getDelimitedField EL functio...

Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/328
  
    @phrocker 
    
    Try deleting the following generated files & trying again:
    
    /extensions/expression-language/Parser.*
    /extensions/expression-language/Scanner.cpp
    /extensions/expression-language/location.hh
    /extensions/expression-language/position.hh
    /extensions/expression-language/stack.hh



---

[GitHub] nifi-minifi-cpp pull request #328: MINIFICPP-474 Added getDelimitedField EL ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi-minifi-cpp/pull/328


---