You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/04/09 19:52:37 UTC

[kudu-CR] KUDU-2612: Java client failover scenarios for TxnManager

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17297


Change subject: KUDU-2612: Java client failover scenarios for TxnManager
......................................................................

KUDU-2612: Java client failover scenarios for TxnManager

Added a couple of test scenarios to verify that Java client
automatically switches to other available TxnManager for performing
txn-related operations.  Sending txn keep-alive messages isn't covered
yet: I'm planning to address these separately since some extra changes
are needed there which would be easier to review in a separate patch.

I also updated the inline doc for KuduTransaction.isCommitComplete()
to be more explicit about possible exceptions thrown.

Change-Id: I9c7d73ce4a74d426286facbf02dff6e48b46a7c0
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java
3 files changed, 177 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/17297/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c7d73ce4a74d426286facbf02dff6e48b46a7c0
Gerrit-Change-Number: 17297
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] KUDU-2612: Java client failover scenarios for TxnManager

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: KUDU-2612: Java client failover scenarios for TxnManager
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/17297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I9c7d73ce4a74d426286facbf02dff6e48b46a7c0
Gerrit-Change-Number: 17297
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-2612: Java client failover scenarios for TxnManager

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17297 )

Change subject: KUDU-2612: Java client failover scenarios for TxnManager
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17297/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java:

http://gerrit.cloudera.org:8080/#/c/17297/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java@852
PS1, Line 852:           harness.startAllMasterServers();
> Since we're restarting all the masters, we're not guaranteed that we'll act
The other test scenario uses harness.killLeaderMasterServer() and it works as expected.

I can add something like that for this scenario as well.



-- 
To view, visit http://gerrit.cloudera.org:8080/17297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c7d73ce4a74d426286facbf02dff6e48b46a7c0
Gerrit-Change-Number: 17297
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 09 Apr 2021 22:22:06 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2612: Java client failover scenarios for TxnManager

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17297 )

Change subject: KUDU-2612: Java client failover scenarios for TxnManager
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17297/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java:

http://gerrit.cloudera.org:8080/#/c/17297/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java@852
PS1, Line 852:           harness.startAllMasterServers();
Since we're restarting all the masters, we're not guaranteed that we'll actually go to a different master, right? Won't the master just continue sending requests to the same master once it's restarted? Same with the other test?



-- 
To view, visit http://gerrit.cloudera.org:8080/17297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c7d73ce4a74d426286facbf02dff6e48b46a7c0
Gerrit-Change-Number: 17297
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 09 Apr 2021 21:10:36 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2612: Java client failover scenarios for TxnManager

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17297 )

Change subject: KUDU-2612: Java client failover scenarios for TxnManager
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17297/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java:

http://gerrit.cloudera.org:8080/#/c/17297/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java@852
PS1, Line 852:           harness.startAllMasterServers();
> We discussed this in person and I missed that the above case kills the lead
Thank you for the clarification.  I think I'll use "master round-robin stop and start" scheme for txn keepalive-related scenarios I'm working on :)



-- 
To view, visit http://gerrit.cloudera.org:8080/17297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c7d73ce4a74d426286facbf02dff6e48b46a7c0
Gerrit-Change-Number: 17297
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 09 Apr 2021 23:01:29 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2612: Java client failover scenarios for TxnManager

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17297 )

Change subject: KUDU-2612: Java client failover scenarios for TxnManager
......................................................................

KUDU-2612: Java client failover scenarios for TxnManager

Added a couple of test scenarios to verify that Java client
automatically switches to other available TxnManager for performing
txn-related operations.  Sending txn keep-alive messages isn't covered
yet: I'm planning to address these separately since some extra changes
are needed there which would be easier to review in a separate patch.

I also updated the inline doc for KuduTransaction.isCommitComplete()
to be more explicit about possible exceptions thrown.

Change-Id: I9c7d73ce4a74d426286facbf02dff6e48b46a7c0
Reviewed-on: http://gerrit.cloudera.org:8080/17297
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java
3 files changed, 177 insertions(+), 5 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Andrew Wong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/17297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c7d73ce4a74d426286facbf02dff6e48b46a7c0
Gerrit-Change-Number: 17297
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-2612: Java client failover scenarios for TxnManager

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17297 )

Change subject: KUDU-2612: Java client failover scenarios for TxnManager
......................................................................


Patch Set 1: Verified+1

unrelated test failure in AuthTokenExpireITest.RestartCluster


-- 
To view, visit http://gerrit.cloudera.org:8080/17297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c7d73ce4a74d426286facbf02dff6e48b46a7c0
Gerrit-Change-Number: 17297
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 09 Apr 2021 20:54:26 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2612: Java client failover scenarios for TxnManager

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17297 )

Change subject: KUDU-2612: Java client failover scenarios for TxnManager
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17297/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java:

http://gerrit.cloudera.org:8080/#/c/17297/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java@852
PS1, Line 852:           harness.startAllMasterServers();
> The other test scenario uses harness.killLeaderMasterServer() and it works 
We discussed this in person and I missed that the above case kills the leader master and leaves it dead, which does test what I mention here. I'm all for spicier tests, but I'm also fine with this test as is.



-- 
To view, visit http://gerrit.cloudera.org:8080/17297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c7d73ce4a74d426286facbf02dff6e48b46a7c0
Gerrit-Change-Number: 17297
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 09 Apr 2021 22:35:16 +0000
Gerrit-HasComments: Yes