You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/18 02:32:51 UTC
[GitHub] [incubator-tvm] masahi opened a new pull request #5089: [Torch,
QNN] Add missing upcast to uint8 avg_pool conversion
masahi opened a new pull request #5089: [Torch, QNN] Add missing upcast to uint8 avg_pool conversion
URL: https://github.com/apache/incubator-tvm/pull/5089
Previously we were missing an upcast to int32 for avg_pool2d, fixed now. It seems avg_pool is used in inception v3, but I don't know why our accuracy is not affected by the missing upcast.
Beside the accuracy issue, without upcast it also causes a mysterious typing problem for inception v3 when compiling for AVX512. For AVX2 and other, there have been no issue.
cc @anijain2305
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] anijain2305 merged pull request #5089: [Torch,
QNN] Add missing upcast to uint8 avg_pool conversion
Posted by GitBox <gi...@apache.org>.
anijain2305 merged pull request #5089: [Torch, QNN] Add missing upcast to uint8 avg_pool conversion
URL: https://github.com/apache/incubator-tvm/pull/5089
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] anijain2305 commented on issue #5089: [Torch,
QNN] Add missing upcast to uint8 avg_pool conversion
Posted by GitBox <gi...@apache.org>.
anijain2305 commented on issue #5089: [Torch, QNN] Add missing upcast to uint8 avg_pool conversion
URL: https://github.com/apache/incubator-tvm/pull/5089#issuecomment-600765263
Thanks @masahi This is merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services