You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/22 02:08:18 UTC
[GitHub] [incubator-nuttx] zyfeier opened a new pull request, #7159: sched: merge waitsem and msgwaitq
zyfeier opened a new pull request, #7159:
URL: https://github.com/apache/incubator-nuttx/pull/7159
## Summary
1. Combine waitsem and msgwaitq in struct tcb_s;
2. Indicate wait is over after tcb removed from block list;
## Impact
NA
## Testing
sabre-6quad:nsh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7159: sched: merge waitsem and msgwaitq
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #7159:
URL: https://github.com/apache/incubator-nuttx/pull/7159#issuecomment-1254520453
@zyfeier
What is your intention for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7159: sched: merge waitsem and msgwaitq
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7159:
URL: https://github.com/apache/incubator-nuttx/pull/7159#discussion_r977269758
##########
sched/semaphore/sem_waitirq.c:
##########
@@ -97,10 +97,6 @@ void nxsem_wait_irq(FAR struct tcb_s *wtcb, int errcode)
sem->semcount++;
- /* Indicate that the semaphore wait is over. */
-
- wtcb->waitsem = NULL;
Review Comment:
Don't we need to set waitobj to NULL here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7159: sched: merge waitsem and msgwaitq
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7159:
URL: https://github.com/apache/incubator-nuttx/pull/7159#issuecomment-1254557804
> @zyfeier What is your intention for this PR?
https://github.com/apache/incubator-nuttx/pull/6987 depends on this PR, the major objective is replacing global wait list(g_waitingforsemaphore, g_waitingformqnotempty and g_waitingformqnotfull) with per sem/mqueue list, which could improve the performance when the system has many sem/mqueue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7159: sched: merge waitsem and msgwaitq
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #7159:
URL: https://github.com/apache/incubator-nuttx/pull/7159#issuecomment-1254602836
Saving the word number of bytes is always a good idea :)
Regarding another change that moves the global list to sync objects, that goes in conflict with my PR that is intended to fix priority restoration when priority inheritance is enabled. I would need to take a look if an approach that I propose can be implemented with this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7159: sched: merge waitsem and msgwaitq
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7159:
URL: https://github.com/apache/incubator-nuttx/pull/7159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7159: sched: merge waitsem and msgwaitq
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7159:
URL: https://github.com/apache/incubator-nuttx/pull/7159#issuecomment-1254583467
So, @masayuki2009 how about we merge this PR and focus on the real change(https://github.com/apache/incubator-nuttx/pull/6987)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7159: sched: merge waitsem and msgwaitq
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7159:
URL: https://github.com/apache/incubator-nuttx/pull/7159#issuecomment-1254625082
> Saving the word number of bytes is always a good idea :) Regarding another change that moves the global list to sync objects, that goes in conflict with my PR that is intended to fix priority restoration when priority inheritance is enabled. I would need to take a look if an approach that I propose can be implemented with this change
Sure, the change will become more simple after we merge this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] zyfeier commented on a diff in pull request #7159: sched: merge waitsem and msgwaitq
Posted by GitBox <gi...@apache.org>.
zyfeier commented on code in PR #7159:
URL: https://github.com/apache/incubator-nuttx/pull/7159#discussion_r977284150
##########
sched/semaphore/sem_waitirq.c:
##########
@@ -97,10 +97,6 @@ void nxsem_wait_irq(FAR struct tcb_s *wtcb, int errcode)
sem->semcount++;
- /* Indicate that the semaphore wait is over. */
-
- wtcb->waitsem = NULL;
Review Comment:
waitobj will set to NULL in nxsched_remove_blocked() function which will be called later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org