You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Maxim Muzafarov <mm...@apache.org> on 2021/11/20 00:17:53 UTC
Re: [DISCUSSION][IEP-80] Breaking changes in Ignite-2.x
Folks,
I've prepared the changes related to the legacy Service Grid removal
for the 2.13 release. Here is the issue [1] and the PR [2] of these
changes.
Some important notes:
- Removed GridServiceProcessor legacy implementation (internal)
- The IGNITE_EVENT_DRIVEN_SERVICE_PROCESSOR_ENABLED system property
was removed (this is a breaking change)
- The ATTR_EVENT_DRIVEN_SERVICE_PROCESSOR_ENABLED node attribute was
removed (this is a breaking change)
- The node with 2.13 won't be able to connect to 2.12 (assume Ignite
services are used)
The legacy test suite [3] will be removed after the [1] issue will be merged.
Who can take a look at this PR?
[1] https://issues.apache.org/jira/browse/IGNITE-15758
[2] https://github.com/apache/ignite/pull/9577/files
[3] https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_ServiceGridLegacyMode
On Fri, 22 Oct 2021 at 12:43, Nikolay Izhikov <ni...@apache.org> wrote:
>
> Hello.
>
> In the scope of IEP-80 Breaking changes in Ignite-2.x PR for the following API are prepared:
>
> 1. MVCC
> - https://issues.apache.org/jira/browse/IGNITE-15757
> - https://github.com/apache/ignite/pull/9516
>
> 2. LOCAL caches
> - https://issues.apache.org/jira/browse/IGNITE-15756
> - https://github.com/apache/ignite/pull/9515
>
> 3. CacheConfiguration#rebalanceDelay
> - https://issues.apache.org/jira/browse/IGNITE-15764
> - https://github.com/apache/ignite/pull/9515
>
> Please, review.
>
> > 15 окт. 2021 г., в 16:23, Nikolay Izhikov <ni...@gmail.com> написал(а):
> >
> > THanks, Maksim.
> >
> > Tickets included in IEP scope and marked for d&r in 2.12-2.13
> >
> >> 15 окт. 2021 г., в 16:03, Maxim Muzafarov <mm...@apache.org> написал(а):
> >>
> >> Let's deprecate RebalanceDelay and RebalanceMode=NONE also.
> >>
> >> [1] https://issues.apache.org/jira/browse/IGNITE-12662
> >> [2] https://issues.apache.org/jira/browse/IGNITE-14613
> >>
> >> On Fri, 15 Oct 2021 at 15:46, Anton Vinogradov <av...@apache.org> wrote:
> >>>
> >>> +1
> >>>
> >>> On Fri, Oct 15, 2021 at 3:41 PM Nikita Amelchev <na...@apache.org>
> >>> wrote:
> >>>
> >>>> +1 for deprecation in the 2.12 release
> >>>>
> >>>> пт, 15 окт. 2021 г. в 15:35, Nikolay Izhikov <ni...@apache.org>:
> >>>>>
> >>>>> Hello, Igniters.
> >>>>>
> >>>>> I’ve prepared IEP-80 [1] to track breaking changes that should be done
> >>>> in Ignite 2.x.
> >>>>>
> >>>>> We agreed on the following algorithm to deal with breaking changes:
> >>>>>
> >>>>> - Ignite 2.[x] - deprecate the API + notification of the users.
> >>>>> - Ignite 2.[x+1] - API removal.
> >>>>>
> >>>>>
> >>>>> I propose to start these improvements with the d&r (depuration &
> >>>> removal) of the following features:
> >>>>>
> >>>>> - LOCAL caches
> >>>>> - MVCC caches
> >>>>> - legacy service grid implementation
> >>>>> - legacy JMX metrics beans.
> >>>>>
> >>>>> Deprecation in 2.12
> >>>>> Removal in 2.13
> >>>>>
> >>>>> Please, share your opinion.
> >>>>>
> >>>>> [1]
> >>>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=191334475
> >>>>
> >>>>
> >>>>
> >>>> --
> >>>> Best wishes,
> >>>> Amelchev Nikita
> >>>>
> >
>
Re: [DISCUSSION][IEP-80] Breaking changes in Ignite-2.x
Posted by Ivan Daschinsky <iv...@gmail.com>.
It is the last point in the wishlist that probably nobody cares about.
I see no discussion at all, no @Deprecation annotations and a lot of
abandoned and broken code only.
пт, 3 дек. 2021 г. в 11:01, Maxim Muzafarov <mm...@apache.org>:
> Ivan,
>
> It seems shmem is already in the remove list [1].
>
> [1]
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+3.0+Wishlist
>
> On Fri, 3 Dec 2021 at 10:42, Ivan Daschinsky <iv...@gmail.com> wrote:
> >
> > So if nobody wants it to resurrect, maybe it is worth removing it?
> >
> >
> > пт, 3 дек. 2021 г. в 09:25, Ivan Pavlukhin <vo...@gmail.com>:
> >
> > > Latest that I heard that it literally was never in use.
> > >
> > > 2021-11-29 19:44 GMT+03:00, Ivan Daschinsky <iv...@gmail.com>:
> > > > There is JNI library in ipc/shmem directory. It even compiles with
> > > minimal
> > > > modification on modern gcc (9.3.0)
> > > > But there is no script to build jar with native library.
> > > >
> > > > May be it is possible to create separate module, refactor it a bit,
> > > change
> > > > build process (CMake)?
> > > > Is there a technical reason why it is abandoned?
> > > >
> > > > пн, 29 нояб. 2021 г. в 19:24, Ivan Daschinsky <iv...@gmail.com>:
> > > >
> > > >> Guys, what is the status of ignite-shmem and TcpCommunication
> through
> > > it?
> > > >>
> > > >> 1. Native part has not been built at all since 2015
> > > >> 2. It is currently broken in master -- I've fixed some NPE and
> metrics
> > > >> conversion locally and it works for me. It is broken for almost a
> year.
> > > >> 3. GridShmemCommunicationClient is not covered by tests.
> > > >>
> > > >> What do you think we should do with this?
> > > >>
> > > >> сб, 27 нояб. 2021 г. в 23:32, Vyacheslav Daradur <
> daradurvs@gmail.com>:
> > > >>
> > > >>> LGTM. Merged to master.
> > > >>>
> > > >>> Thank you for your contribution!
> > > >>>
> > > >>> On Fri, Nov 26, 2021 at 12:20 PM Maxim Muzafarov <
> mmuzaf@apache.org>
> > > >>> wrote:
> > > >>>
> > > >>> > Folks,
> > > >>> >
> > > >>> > This is a friendly reminder :-)
> > > >>> > PR [1] is ready for review. Will anyone take a look?
> > > >>> >
> > > >>> > [1] https://github.com/apache/ignite/pull/9577/files
> > > >>> >
> > > >>> > On Sat, 20 Nov 2021 at 03:17, Maxim Muzafarov <mmuzaf@apache.org
> >
> > > >>> wrote:
> > > >>> > >
> > > >>> > > Folks,
> > > >>> > >
> > > >>> > >
> > > >>> > > I've prepared the changes related to the legacy Service Grid
> > > removal
> > > >>> > > for the 2.13 release. Here is the issue [1] and the PR [2] of
> these
> > > >>> > > changes.
> > > >>> > >
> > > >>> > > Some important notes:
> > > >>> > >
> > > >>> > > - Removed GridServiceProcessor legacy implementation (internal)
> > > >>> > > - The IGNITE_EVENT_DRIVEN_SERVICE_PROCESSOR_ENABLED system
> property
> > > >>> > > was removed (this is a breaking change)
> > > >>> > > - The ATTR_EVENT_DRIVEN_SERVICE_PROCESSOR_ENABLED node
> attribute
> > > was
> > > >>> > > removed (this is a breaking change)
> > > >>> > > - The node with 2.13 won't be able to connect to 2.12 (assume
> > > Ignite
> > > >>> > > services are used)
> > > >>> > >
> > > >>> > > The legacy test suite [3] will be removed after the [1] issue
> will
> > > >>> > > be
> > > >>> > merged.
> > > >>> > >
> > > >>> > >
> > > >>> > > Who can take a look at this PR?
> > > >>> > >
> > > >>> > >
> > > >>> > > [1] https://issues.apache.org/jira/browse/IGNITE-15758
> > > >>> > > [2] https://github.com/apache/ignite/pull/9577/files
> > > >>> > > [3]
> > > >>> >
> > > >>>
> > >
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_ServiceGridLegacyMode
> > > >>> > >
> > > >>> > > On Fri, 22 Oct 2021 at 12:43, Nikolay Izhikov <
> nizhikov@apache.org
> > > >
> > > >>> > wrote:
> > > >>> > > >
> > > >>> > > > Hello.
> > > >>> > > >
> > > >>> > > > In the scope of IEP-80 Breaking changes in Ignite-2.x PR for
> the
> > > >>> > following API are prepared:
> > > >>> > > >
> > > >>> > > > 1. MVCC
> > > >>> > > > - https://issues.apache.org/jira/browse/IGNITE-15757
> > > >>> > > > - https://github.com/apache/ignite/pull/9516
> > > >>> > > >
> > > >>> > > > 2. LOCAL caches
> > > >>> > > > - https://issues.apache.org/jira/browse/IGNITE-15756
> > > >>> > > > - https://github.com/apache/ignite/pull/9515
> > > >>> > > >
> > > >>> > > > 3. CacheConfiguration#rebalanceDelay
> > > >>> > > > - https://issues.apache.org/jira/browse/IGNITE-15764
> > > >>> > > > - https://github.com/apache/ignite/pull/9515
> > > >>> > > >
> > > >>> > > > Please, review.
> > > >>> > > >
> > > >>> > > > > 15 окт. 2021 г., в 16:23, Nikolay Izhikov
> > > >>> > > > > <nizhikov.dev@gmail.com
> > > >>> >
> > > >>> > написал(а):
> > > >>> > > > >
> > > >>> > > > > THanks, Maksim.
> > > >>> > > > >
> > > >>> > > > > Tickets included in IEP scope and marked for d&r in
> 2.12-2.13
> > > >>> > > > >
> > > >>> > > > >> 15 окт. 2021 г., в 16:03, Maxim Muzafarov <
> mmuzaf@apache.org>
> > > >>> > написал(а):
> > > >>> > > > >>
> > > >>> > > > >> Let's deprecate RebalanceDelay and RebalanceMode=NONE
> also.
> > > >>> > > > >>
> > > >>> > > > >> [1] https://issues.apache.org/jira/browse/IGNITE-12662
> > > >>> > > > >> [2] https://issues.apache.org/jira/browse/IGNITE-14613
> > > >>> > > > >>
> > > >>> > > > >> On Fri, 15 Oct 2021 at 15:46, Anton Vinogradov <
> av@apache.org
> > > >
> > > >>> > wrote:
> > > >>> > > > >>>
> > > >>> > > > >>> +1
> > > >>> > > > >>>
> > > >>> > > > >>> On Fri, Oct 15, 2021 at 3:41 PM Nikita Amelchev <
> > > >>> > namelchev@apache.org>
> > > >>> > > > >>> wrote:
> > > >>> > > > >>>
> > > >>> > > > >>>> +1 for deprecation in the 2.12 release
> > > >>> > > > >>>>
> > > >>> > > > >>>> пт, 15 окт. 2021 г. в 15:35, Nikolay Izhikov <
> > > >>> nizhikov@apache.org
> > > >>> > >:
> > > >>> > > > >>>>>
> > > >>> > > > >>>>> Hello, Igniters.
> > > >>> > > > >>>>>
> > > >>> > > > >>>>> I’ve prepared IEP-80 [1] to track breaking changes that
> > > >>> > > > >>>>> should
> > > >>> > be done
> > > >>> > > > >>>> in Ignite 2.x.
> > > >>> > > > >>>>>
> > > >>> > > > >>>>> We agreed on the following algorithm to deal with
> breaking
> > > >>> > changes:
> > > >>> > > > >>>>>
> > > >>> > > > >>>>> - Ignite 2.[x] - deprecate the API + notification of
> the
> > > >>> users.
> > > >>> > > > >>>>> - Ignite 2.[x+1] - API removal.
> > > >>> > > > >>>>>
> > > >>> > > > >>>>>
> > > >>> > > > >>>>> I propose to start these improvements with the d&r
> > > >>> (depuration &
> > > >>> > > > >>>> removal) of the following features:
> > > >>> > > > >>>>>
> > > >>> > > > >>>>> - LOCAL caches
> > > >>> > > > >>>>> - MVCC caches
> > > >>> > > > >>>>> - legacy service grid implementation
> > > >>> > > > >>>>> - legacy JMX metrics beans.
> > > >>> > > > >>>>>
> > > >>> > > > >>>>> Deprecation in 2.12
> > > >>> > > > >>>>> Removal in 2.13
> > > >>> > > > >>>>>
> > > >>> > > > >>>>> Please, share your opinion.
> > > >>> > > > >>>>>
> > > >>> > > > >>>>> [1]
> > > >>> > > > >>>>
> > > >>> >
> > > >>>
> > >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=191334475
> > > >>> > > > >>>>
> > > >>> > > > >>>>
> > > >>> > > > >>>>
> > > >>> > > > >>>> --
> > > >>> > > > >>>> Best wishes,
> > > >>> > > > >>>> Amelchev Nikita
> > > >>> > > > >>>>
> > > >>> > > > >
> > > >>> > > >
> > > >>> >
> > > >>>
> > > >>>
> > > >>> --
> > > >>> Best Regards,
> > > >>> Vyacheslav D.
> > > >>>
> > > >>
> > > >>
> > > >> --
> > > >> Sincerely yours, Ivan Daschinskiy
> > > >>
> > > >
> > > >
> > > > --
> > > > Sincerely yours, Ivan Daschinskiy
> > > >
> > >
> > >
> > > --
> > >
> > > Best regards,
> > > Ivan Pavlukhin
> > >
> >
> >
> > --
> > Sincerely yours, Ivan Daschinskiy
>
--
Sincerely yours, Ivan Daschinskiy
Re: [DISCUSSION][IEP-80] Breaking changes in Ignite-2.x
Posted by Maxim Muzafarov <mm...@apache.org>.
Ivan,
It seems shmem is already in the remove list [1].
[1] https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+3.0+Wishlist
On Fri, 3 Dec 2021 at 10:42, Ivan Daschinsky <iv...@gmail.com> wrote:
>
> So if nobody wants it to resurrect, maybe it is worth removing it?
>
>
> пт, 3 дек. 2021 г. в 09:25, Ivan Pavlukhin <vo...@gmail.com>:
>
> > Latest that I heard that it literally was never in use.
> >
> > 2021-11-29 19:44 GMT+03:00, Ivan Daschinsky <iv...@gmail.com>:
> > > There is JNI library in ipc/shmem directory. It even compiles with
> > minimal
> > > modification on modern gcc (9.3.0)
> > > But there is no script to build jar with native library.
> > >
> > > May be it is possible to create separate module, refactor it a bit,
> > change
> > > build process (CMake)?
> > > Is there a technical reason why it is abandoned?
> > >
> > > пн, 29 нояб. 2021 г. в 19:24, Ivan Daschinsky <iv...@gmail.com>:
> > >
> > >> Guys, what is the status of ignite-shmem and TcpCommunication through
> > it?
> > >>
> > >> 1. Native part has not been built at all since 2015
> > >> 2. It is currently broken in master -- I've fixed some NPE and metrics
> > >> conversion locally and it works for me. It is broken for almost a year.
> > >> 3. GridShmemCommunicationClient is not covered by tests.
> > >>
> > >> What do you think we should do with this?
> > >>
> > >> сб, 27 нояб. 2021 г. в 23:32, Vyacheslav Daradur <da...@gmail.com>:
> > >>
> > >>> LGTM. Merged to master.
> > >>>
> > >>> Thank you for your contribution!
> > >>>
> > >>> On Fri, Nov 26, 2021 at 12:20 PM Maxim Muzafarov <mm...@apache.org>
> > >>> wrote:
> > >>>
> > >>> > Folks,
> > >>> >
> > >>> > This is a friendly reminder :-)
> > >>> > PR [1] is ready for review. Will anyone take a look?
> > >>> >
> > >>> > [1] https://github.com/apache/ignite/pull/9577/files
> > >>> >
> > >>> > On Sat, 20 Nov 2021 at 03:17, Maxim Muzafarov <mm...@apache.org>
> > >>> wrote:
> > >>> > >
> > >>> > > Folks,
> > >>> > >
> > >>> > >
> > >>> > > I've prepared the changes related to the legacy Service Grid
> > removal
> > >>> > > for the 2.13 release. Here is the issue [1] and the PR [2] of these
> > >>> > > changes.
> > >>> > >
> > >>> > > Some important notes:
> > >>> > >
> > >>> > > - Removed GridServiceProcessor legacy implementation (internal)
> > >>> > > - The IGNITE_EVENT_DRIVEN_SERVICE_PROCESSOR_ENABLED system property
> > >>> > > was removed (this is a breaking change)
> > >>> > > - The ATTR_EVENT_DRIVEN_SERVICE_PROCESSOR_ENABLED node attribute
> > was
> > >>> > > removed (this is a breaking change)
> > >>> > > - The node with 2.13 won't be able to connect to 2.12 (assume
> > Ignite
> > >>> > > services are used)
> > >>> > >
> > >>> > > The legacy test suite [3] will be removed after the [1] issue will
> > >>> > > be
> > >>> > merged.
> > >>> > >
> > >>> > >
> > >>> > > Who can take a look at this PR?
> > >>> > >
> > >>> > >
> > >>> > > [1] https://issues.apache.org/jira/browse/IGNITE-15758
> > >>> > > [2] https://github.com/apache/ignite/pull/9577/files
> > >>> > > [3]
> > >>> >
> > >>>
> > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_ServiceGridLegacyMode
> > >>> > >
> > >>> > > On Fri, 22 Oct 2021 at 12:43, Nikolay Izhikov <nizhikov@apache.org
> > >
> > >>> > wrote:
> > >>> > > >
> > >>> > > > Hello.
> > >>> > > >
> > >>> > > > In the scope of IEP-80 Breaking changes in Ignite-2.x PR for the
> > >>> > following API are prepared:
> > >>> > > >
> > >>> > > > 1. MVCC
> > >>> > > > - https://issues.apache.org/jira/browse/IGNITE-15757
> > >>> > > > - https://github.com/apache/ignite/pull/9516
> > >>> > > >
> > >>> > > > 2. LOCAL caches
> > >>> > > > - https://issues.apache.org/jira/browse/IGNITE-15756
> > >>> > > > - https://github.com/apache/ignite/pull/9515
> > >>> > > >
> > >>> > > > 3. CacheConfiguration#rebalanceDelay
> > >>> > > > - https://issues.apache.org/jira/browse/IGNITE-15764
> > >>> > > > - https://github.com/apache/ignite/pull/9515
> > >>> > > >
> > >>> > > > Please, review.
> > >>> > > >
> > >>> > > > > 15 окт. 2021 г., в 16:23, Nikolay Izhikov
> > >>> > > > > <nizhikov.dev@gmail.com
> > >>> >
> > >>> > написал(а):
> > >>> > > > >
> > >>> > > > > THanks, Maksim.
> > >>> > > > >
> > >>> > > > > Tickets included in IEP scope and marked for d&r in 2.12-2.13
> > >>> > > > >
> > >>> > > > >> 15 окт. 2021 г., в 16:03, Maxim Muzafarov <mm...@apache.org>
> > >>> > написал(а):
> > >>> > > > >>
> > >>> > > > >> Let's deprecate RebalanceDelay and RebalanceMode=NONE also.
> > >>> > > > >>
> > >>> > > > >> [1] https://issues.apache.org/jira/browse/IGNITE-12662
> > >>> > > > >> [2] https://issues.apache.org/jira/browse/IGNITE-14613
> > >>> > > > >>
> > >>> > > > >> On Fri, 15 Oct 2021 at 15:46, Anton Vinogradov <av@apache.org
> > >
> > >>> > wrote:
> > >>> > > > >>>
> > >>> > > > >>> +1
> > >>> > > > >>>
> > >>> > > > >>> On Fri, Oct 15, 2021 at 3:41 PM Nikita Amelchev <
> > >>> > namelchev@apache.org>
> > >>> > > > >>> wrote:
> > >>> > > > >>>
> > >>> > > > >>>> +1 for deprecation in the 2.12 release
> > >>> > > > >>>>
> > >>> > > > >>>> пт, 15 окт. 2021 г. в 15:35, Nikolay Izhikov <
> > >>> nizhikov@apache.org
> > >>> > >:
> > >>> > > > >>>>>
> > >>> > > > >>>>> Hello, Igniters.
> > >>> > > > >>>>>
> > >>> > > > >>>>> I’ve prepared IEP-80 [1] to track breaking changes that
> > >>> > > > >>>>> should
> > >>> > be done
> > >>> > > > >>>> in Ignite 2.x.
> > >>> > > > >>>>>
> > >>> > > > >>>>> We agreed on the following algorithm to deal with breaking
> > >>> > changes:
> > >>> > > > >>>>>
> > >>> > > > >>>>> - Ignite 2.[x] - deprecate the API + notification of the
> > >>> users.
> > >>> > > > >>>>> - Ignite 2.[x+1] - API removal.
> > >>> > > > >>>>>
> > >>> > > > >>>>>
> > >>> > > > >>>>> I propose to start these improvements with the d&r
> > >>> (depuration &
> > >>> > > > >>>> removal) of the following features:
> > >>> > > > >>>>>
> > >>> > > > >>>>> - LOCAL caches
> > >>> > > > >>>>> - MVCC caches
> > >>> > > > >>>>> - legacy service grid implementation
> > >>> > > > >>>>> - legacy JMX metrics beans.
> > >>> > > > >>>>>
> > >>> > > > >>>>> Deprecation in 2.12
> > >>> > > > >>>>> Removal in 2.13
> > >>> > > > >>>>>
> > >>> > > > >>>>> Please, share your opinion.
> > >>> > > > >>>>>
> > >>> > > > >>>>> [1]
> > >>> > > > >>>>
> > >>> >
> > >>>
> > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=191334475
> > >>> > > > >>>>
> > >>> > > > >>>>
> > >>> > > > >>>>
> > >>> > > > >>>> --
> > >>> > > > >>>> Best wishes,
> > >>> > > > >>>> Amelchev Nikita
> > >>> > > > >>>>
> > >>> > > > >
> > >>> > > >
> > >>> >
> > >>>
> > >>>
> > >>> --
> > >>> Best Regards,
> > >>> Vyacheslav D.
> > >>>
> > >>
> > >>
> > >> --
> > >> Sincerely yours, Ivan Daschinskiy
> > >>
> > >
> > >
> > > --
> > > Sincerely yours, Ivan Daschinskiy
> > >
> >
> >
> > --
> >
> > Best regards,
> > Ivan Pavlukhin
> >
>
>
> --
> Sincerely yours, Ivan Daschinskiy
Re: [DISCUSSION][IEP-80] Breaking changes in Ignite-2.x
Posted by Ivan Daschinsky <iv...@gmail.com>.
So if nobody wants it to resurrect, maybe it is worth removing it?
пт, 3 дек. 2021 г. в 09:25, Ivan Pavlukhin <vo...@gmail.com>:
> Latest that I heard that it literally was never in use.
>
> 2021-11-29 19:44 GMT+03:00, Ivan Daschinsky <iv...@gmail.com>:
> > There is JNI library in ipc/shmem directory. It even compiles with
> minimal
> > modification on modern gcc (9.3.0)
> > But there is no script to build jar with native library.
> >
> > May be it is possible to create separate module, refactor it a bit,
> change
> > build process (CMake)?
> > Is there a technical reason why it is abandoned?
> >
> > пн, 29 нояб. 2021 г. в 19:24, Ivan Daschinsky <iv...@gmail.com>:
> >
> >> Guys, what is the status of ignite-shmem and TcpCommunication through
> it?
> >>
> >> 1. Native part has not been built at all since 2015
> >> 2. It is currently broken in master -- I've fixed some NPE and metrics
> >> conversion locally and it works for me. It is broken for almost a year.
> >> 3. GridShmemCommunicationClient is not covered by tests.
> >>
> >> What do you think we should do with this?
> >>
> >> сб, 27 нояб. 2021 г. в 23:32, Vyacheslav Daradur <da...@gmail.com>:
> >>
> >>> LGTM. Merged to master.
> >>>
> >>> Thank you for your contribution!
> >>>
> >>> On Fri, Nov 26, 2021 at 12:20 PM Maxim Muzafarov <mm...@apache.org>
> >>> wrote:
> >>>
> >>> > Folks,
> >>> >
> >>> > This is a friendly reminder :-)
> >>> > PR [1] is ready for review. Will anyone take a look?
> >>> >
> >>> > [1] https://github.com/apache/ignite/pull/9577/files
> >>> >
> >>> > On Sat, 20 Nov 2021 at 03:17, Maxim Muzafarov <mm...@apache.org>
> >>> wrote:
> >>> > >
> >>> > > Folks,
> >>> > >
> >>> > >
> >>> > > I've prepared the changes related to the legacy Service Grid
> removal
> >>> > > for the 2.13 release. Here is the issue [1] and the PR [2] of these
> >>> > > changes.
> >>> > >
> >>> > > Some important notes:
> >>> > >
> >>> > > - Removed GridServiceProcessor legacy implementation (internal)
> >>> > > - The IGNITE_EVENT_DRIVEN_SERVICE_PROCESSOR_ENABLED system property
> >>> > > was removed (this is a breaking change)
> >>> > > - The ATTR_EVENT_DRIVEN_SERVICE_PROCESSOR_ENABLED node attribute
> was
> >>> > > removed (this is a breaking change)
> >>> > > - The node with 2.13 won't be able to connect to 2.12 (assume
> Ignite
> >>> > > services are used)
> >>> > >
> >>> > > The legacy test suite [3] will be removed after the [1] issue will
> >>> > > be
> >>> > merged.
> >>> > >
> >>> > >
> >>> > > Who can take a look at this PR?
> >>> > >
> >>> > >
> >>> > > [1] https://issues.apache.org/jira/browse/IGNITE-15758
> >>> > > [2] https://github.com/apache/ignite/pull/9577/files
> >>> > > [3]
> >>> >
> >>>
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_ServiceGridLegacyMode
> >>> > >
> >>> > > On Fri, 22 Oct 2021 at 12:43, Nikolay Izhikov <nizhikov@apache.org
> >
> >>> > wrote:
> >>> > > >
> >>> > > > Hello.
> >>> > > >
> >>> > > > In the scope of IEP-80 Breaking changes in Ignite-2.x PR for the
> >>> > following API are prepared:
> >>> > > >
> >>> > > > 1. MVCC
> >>> > > > - https://issues.apache.org/jira/browse/IGNITE-15757
> >>> > > > - https://github.com/apache/ignite/pull/9516
> >>> > > >
> >>> > > > 2. LOCAL caches
> >>> > > > - https://issues.apache.org/jira/browse/IGNITE-15756
> >>> > > > - https://github.com/apache/ignite/pull/9515
> >>> > > >
> >>> > > > 3. CacheConfiguration#rebalanceDelay
> >>> > > > - https://issues.apache.org/jira/browse/IGNITE-15764
> >>> > > > - https://github.com/apache/ignite/pull/9515
> >>> > > >
> >>> > > > Please, review.
> >>> > > >
> >>> > > > > 15 окт. 2021 г., в 16:23, Nikolay Izhikov
> >>> > > > > <nizhikov.dev@gmail.com
> >>> >
> >>> > написал(а):
> >>> > > > >
> >>> > > > > THanks, Maksim.
> >>> > > > >
> >>> > > > > Tickets included in IEP scope and marked for d&r in 2.12-2.13
> >>> > > > >
> >>> > > > >> 15 окт. 2021 г., в 16:03, Maxim Muzafarov <mm...@apache.org>
> >>> > написал(а):
> >>> > > > >>
> >>> > > > >> Let's deprecate RebalanceDelay and RebalanceMode=NONE also.
> >>> > > > >>
> >>> > > > >> [1] https://issues.apache.org/jira/browse/IGNITE-12662
> >>> > > > >> [2] https://issues.apache.org/jira/browse/IGNITE-14613
> >>> > > > >>
> >>> > > > >> On Fri, 15 Oct 2021 at 15:46, Anton Vinogradov <av@apache.org
> >
> >>> > wrote:
> >>> > > > >>>
> >>> > > > >>> +1
> >>> > > > >>>
> >>> > > > >>> On Fri, Oct 15, 2021 at 3:41 PM Nikita Amelchev <
> >>> > namelchev@apache.org>
> >>> > > > >>> wrote:
> >>> > > > >>>
> >>> > > > >>>> +1 for deprecation in the 2.12 release
> >>> > > > >>>>
> >>> > > > >>>> пт, 15 окт. 2021 г. в 15:35, Nikolay Izhikov <
> >>> nizhikov@apache.org
> >>> > >:
> >>> > > > >>>>>
> >>> > > > >>>>> Hello, Igniters.
> >>> > > > >>>>>
> >>> > > > >>>>> I’ve prepared IEP-80 [1] to track breaking changes that
> >>> > > > >>>>> should
> >>> > be done
> >>> > > > >>>> in Ignite 2.x.
> >>> > > > >>>>>
> >>> > > > >>>>> We agreed on the following algorithm to deal with breaking
> >>> > changes:
> >>> > > > >>>>>
> >>> > > > >>>>> - Ignite 2.[x] - deprecate the API + notification of the
> >>> users.
> >>> > > > >>>>> - Ignite 2.[x+1] - API removal.
> >>> > > > >>>>>
> >>> > > > >>>>>
> >>> > > > >>>>> I propose to start these improvements with the d&r
> >>> (depuration &
> >>> > > > >>>> removal) of the following features:
> >>> > > > >>>>>
> >>> > > > >>>>> - LOCAL caches
> >>> > > > >>>>> - MVCC caches
> >>> > > > >>>>> - legacy service grid implementation
> >>> > > > >>>>> - legacy JMX metrics beans.
> >>> > > > >>>>>
> >>> > > > >>>>> Deprecation in 2.12
> >>> > > > >>>>> Removal in 2.13
> >>> > > > >>>>>
> >>> > > > >>>>> Please, share your opinion.
> >>> > > > >>>>>
> >>> > > > >>>>> [1]
> >>> > > > >>>>
> >>> >
> >>>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=191334475
> >>> > > > >>>>
> >>> > > > >>>>
> >>> > > > >>>>
> >>> > > > >>>> --
> >>> > > > >>>> Best wishes,
> >>> > > > >>>> Amelchev Nikita
> >>> > > > >>>>
> >>> > > > >
> >>> > > >
> >>> >
> >>>
> >>>
> >>> --
> >>> Best Regards,
> >>> Vyacheslav D.
> >>>
> >>
> >>
> >> --
> >> Sincerely yours, Ivan Daschinskiy
> >>
> >
> >
> > --
> > Sincerely yours, Ivan Daschinskiy
> >
>
>
> --
>
> Best regards,
> Ivan Pavlukhin
>
--
Sincerely yours, Ivan Daschinskiy
Re: [DISCUSSION][IEP-80] Breaking changes in Ignite-2.x
Posted by Ivan Pavlukhin <vo...@gmail.com>.
Latest that I heard that it literally was never in use.
2021-11-29 19:44 GMT+03:00, Ivan Daschinsky <iv...@gmail.com>:
> There is JNI library in ipc/shmem directory. It even compiles with minimal
> modification on modern gcc (9.3.0)
> But there is no script to build jar with native library.
>
> May be it is possible to create separate module, refactor it a bit, change
> build process (CMake)?
> Is there a technical reason why it is abandoned?
>
> пн, 29 нояб. 2021 г. в 19:24, Ivan Daschinsky <iv...@gmail.com>:
>
>> Guys, what is the status of ignite-shmem and TcpCommunication through it?
>>
>> 1. Native part has not been built at all since 2015
>> 2. It is currently broken in master -- I've fixed some NPE and metrics
>> conversion locally and it works for me. It is broken for almost a year.
>> 3. GridShmemCommunicationClient is not covered by tests.
>>
>> What do you think we should do with this?
>>
>> сб, 27 нояб. 2021 г. в 23:32, Vyacheslav Daradur <da...@gmail.com>:
>>
>>> LGTM. Merged to master.
>>>
>>> Thank you for your contribution!
>>>
>>> On Fri, Nov 26, 2021 at 12:20 PM Maxim Muzafarov <mm...@apache.org>
>>> wrote:
>>>
>>> > Folks,
>>> >
>>> > This is a friendly reminder :-)
>>> > PR [1] is ready for review. Will anyone take a look?
>>> >
>>> > [1] https://github.com/apache/ignite/pull/9577/files
>>> >
>>> > On Sat, 20 Nov 2021 at 03:17, Maxim Muzafarov <mm...@apache.org>
>>> wrote:
>>> > >
>>> > > Folks,
>>> > >
>>> > >
>>> > > I've prepared the changes related to the legacy Service Grid removal
>>> > > for the 2.13 release. Here is the issue [1] and the PR [2] of these
>>> > > changes.
>>> > >
>>> > > Some important notes:
>>> > >
>>> > > - Removed GridServiceProcessor legacy implementation (internal)
>>> > > - The IGNITE_EVENT_DRIVEN_SERVICE_PROCESSOR_ENABLED system property
>>> > > was removed (this is a breaking change)
>>> > > - The ATTR_EVENT_DRIVEN_SERVICE_PROCESSOR_ENABLED node attribute was
>>> > > removed (this is a breaking change)
>>> > > - The node with 2.13 won't be able to connect to 2.12 (assume Ignite
>>> > > services are used)
>>> > >
>>> > > The legacy test suite [3] will be removed after the [1] issue will
>>> > > be
>>> > merged.
>>> > >
>>> > >
>>> > > Who can take a look at this PR?
>>> > >
>>> > >
>>> > > [1] https://issues.apache.org/jira/browse/IGNITE-15758
>>> > > [2] https://github.com/apache/ignite/pull/9577/files
>>> > > [3]
>>> >
>>> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_ServiceGridLegacyMode
>>> > >
>>> > > On Fri, 22 Oct 2021 at 12:43, Nikolay Izhikov <ni...@apache.org>
>>> > wrote:
>>> > > >
>>> > > > Hello.
>>> > > >
>>> > > > In the scope of IEP-80 Breaking changes in Ignite-2.x PR for the
>>> > following API are prepared:
>>> > > >
>>> > > > 1. MVCC
>>> > > > - https://issues.apache.org/jira/browse/IGNITE-15757
>>> > > > - https://github.com/apache/ignite/pull/9516
>>> > > >
>>> > > > 2. LOCAL caches
>>> > > > - https://issues.apache.org/jira/browse/IGNITE-15756
>>> > > > - https://github.com/apache/ignite/pull/9515
>>> > > >
>>> > > > 3. CacheConfiguration#rebalanceDelay
>>> > > > - https://issues.apache.org/jira/browse/IGNITE-15764
>>> > > > - https://github.com/apache/ignite/pull/9515
>>> > > >
>>> > > > Please, review.
>>> > > >
>>> > > > > 15 окт. 2021 г., в 16:23, Nikolay Izhikov
>>> > > > > <nizhikov.dev@gmail.com
>>> >
>>> > написал(а):
>>> > > > >
>>> > > > > THanks, Maksim.
>>> > > > >
>>> > > > > Tickets included in IEP scope and marked for d&r in 2.12-2.13
>>> > > > >
>>> > > > >> 15 окт. 2021 г., в 16:03, Maxim Muzafarov <mm...@apache.org>
>>> > написал(а):
>>> > > > >>
>>> > > > >> Let's deprecate RebalanceDelay and RebalanceMode=NONE also.
>>> > > > >>
>>> > > > >> [1] https://issues.apache.org/jira/browse/IGNITE-12662
>>> > > > >> [2] https://issues.apache.org/jira/browse/IGNITE-14613
>>> > > > >>
>>> > > > >> On Fri, 15 Oct 2021 at 15:46, Anton Vinogradov <av...@apache.org>
>>> > wrote:
>>> > > > >>>
>>> > > > >>> +1
>>> > > > >>>
>>> > > > >>> On Fri, Oct 15, 2021 at 3:41 PM Nikita Amelchev <
>>> > namelchev@apache.org>
>>> > > > >>> wrote:
>>> > > > >>>
>>> > > > >>>> +1 for deprecation in the 2.12 release
>>> > > > >>>>
>>> > > > >>>> пт, 15 окт. 2021 г. в 15:35, Nikolay Izhikov <
>>> nizhikov@apache.org
>>> > >:
>>> > > > >>>>>
>>> > > > >>>>> Hello, Igniters.
>>> > > > >>>>>
>>> > > > >>>>> I’ve prepared IEP-80 [1] to track breaking changes that
>>> > > > >>>>> should
>>> > be done
>>> > > > >>>> in Ignite 2.x.
>>> > > > >>>>>
>>> > > > >>>>> We agreed on the following algorithm to deal with breaking
>>> > changes:
>>> > > > >>>>>
>>> > > > >>>>> - Ignite 2.[x] - deprecate the API + notification of the
>>> users.
>>> > > > >>>>> - Ignite 2.[x+1] - API removal.
>>> > > > >>>>>
>>> > > > >>>>>
>>> > > > >>>>> I propose to start these improvements with the d&r
>>> (depuration &
>>> > > > >>>> removal) of the following features:
>>> > > > >>>>>
>>> > > > >>>>> - LOCAL caches
>>> > > > >>>>> - MVCC caches
>>> > > > >>>>> - legacy service grid implementation
>>> > > > >>>>> - legacy JMX metrics beans.
>>> > > > >>>>>
>>> > > > >>>>> Deprecation in 2.12
>>> > > > >>>>> Removal in 2.13
>>> > > > >>>>>
>>> > > > >>>>> Please, share your opinion.
>>> > > > >>>>>
>>> > > > >>>>> [1]
>>> > > > >>>>
>>> >
>>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=191334475
>>> > > > >>>>
>>> > > > >>>>
>>> > > > >>>>
>>> > > > >>>> --
>>> > > > >>>> Best wishes,
>>> > > > >>>> Amelchev Nikita
>>> > > > >>>>
>>> > > > >
>>> > > >
>>> >
>>>
>>>
>>> --
>>> Best Regards,
>>> Vyacheslav D.
>>>
>>
>>
>> --
>> Sincerely yours, Ivan Daschinskiy
>>
>
>
> --
> Sincerely yours, Ivan Daschinskiy
>
--
Best regards,
Ivan Pavlukhin
Re: [DISCUSSION][IEP-80] Breaking changes in Ignite-2.x
Posted by Ivan Daschinsky <iv...@gmail.com>.
There is JNI library in ipc/shmem directory. It even compiles with minimal
modification on modern gcc (9.3.0)
But there is no script to build jar with native library.
May be it is possible to create separate module, refactor it a bit, change
build process (CMake)?
Is there a technical reason why it is abandoned?
пн, 29 нояб. 2021 г. в 19:24, Ivan Daschinsky <iv...@gmail.com>:
> Guys, what is the status of ignite-shmem and TcpCommunication through it?
>
> 1. Native part has not been built at all since 2015
> 2. It is currently broken in master -- I've fixed some NPE and metrics
> conversion locally and it works for me. It is broken for almost a year.
> 3. GridShmemCommunicationClient is not covered by tests.
>
> What do you think we should do with this?
>
> сб, 27 нояб. 2021 г. в 23:32, Vyacheslav Daradur <da...@gmail.com>:
>
>> LGTM. Merged to master.
>>
>> Thank you for your contribution!
>>
>> On Fri, Nov 26, 2021 at 12:20 PM Maxim Muzafarov <mm...@apache.org>
>> wrote:
>>
>> > Folks,
>> >
>> > This is a friendly reminder :-)
>> > PR [1] is ready for review. Will anyone take a look?
>> >
>> > [1] https://github.com/apache/ignite/pull/9577/files
>> >
>> > On Sat, 20 Nov 2021 at 03:17, Maxim Muzafarov <mm...@apache.org>
>> wrote:
>> > >
>> > > Folks,
>> > >
>> > >
>> > > I've prepared the changes related to the legacy Service Grid removal
>> > > for the 2.13 release. Here is the issue [1] and the PR [2] of these
>> > > changes.
>> > >
>> > > Some important notes:
>> > >
>> > > - Removed GridServiceProcessor legacy implementation (internal)
>> > > - The IGNITE_EVENT_DRIVEN_SERVICE_PROCESSOR_ENABLED system property
>> > > was removed (this is a breaking change)
>> > > - The ATTR_EVENT_DRIVEN_SERVICE_PROCESSOR_ENABLED node attribute was
>> > > removed (this is a breaking change)
>> > > - The node with 2.13 won't be able to connect to 2.12 (assume Ignite
>> > > services are used)
>> > >
>> > > The legacy test suite [3] will be removed after the [1] issue will be
>> > merged.
>> > >
>> > >
>> > > Who can take a look at this PR?
>> > >
>> > >
>> > > [1] https://issues.apache.org/jira/browse/IGNITE-15758
>> > > [2] https://github.com/apache/ignite/pull/9577/files
>> > > [3]
>> >
>> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_ServiceGridLegacyMode
>> > >
>> > > On Fri, 22 Oct 2021 at 12:43, Nikolay Izhikov <ni...@apache.org>
>> > wrote:
>> > > >
>> > > > Hello.
>> > > >
>> > > > In the scope of IEP-80 Breaking changes in Ignite-2.x PR for the
>> > following API are prepared:
>> > > >
>> > > > 1. MVCC
>> > > > - https://issues.apache.org/jira/browse/IGNITE-15757
>> > > > - https://github.com/apache/ignite/pull/9516
>> > > >
>> > > > 2. LOCAL caches
>> > > > - https://issues.apache.org/jira/browse/IGNITE-15756
>> > > > - https://github.com/apache/ignite/pull/9515
>> > > >
>> > > > 3. CacheConfiguration#rebalanceDelay
>> > > > - https://issues.apache.org/jira/browse/IGNITE-15764
>> > > > - https://github.com/apache/ignite/pull/9515
>> > > >
>> > > > Please, review.
>> > > >
>> > > > > 15 окт. 2021 г., в 16:23, Nikolay Izhikov <nizhikov.dev@gmail.com
>> >
>> > написал(а):
>> > > > >
>> > > > > THanks, Maksim.
>> > > > >
>> > > > > Tickets included in IEP scope and marked for d&r in 2.12-2.13
>> > > > >
>> > > > >> 15 окт. 2021 г., в 16:03, Maxim Muzafarov <mm...@apache.org>
>> > написал(а):
>> > > > >>
>> > > > >> Let's deprecate RebalanceDelay and RebalanceMode=NONE also.
>> > > > >>
>> > > > >> [1] https://issues.apache.org/jira/browse/IGNITE-12662
>> > > > >> [2] https://issues.apache.org/jira/browse/IGNITE-14613
>> > > > >>
>> > > > >> On Fri, 15 Oct 2021 at 15:46, Anton Vinogradov <av...@apache.org>
>> > wrote:
>> > > > >>>
>> > > > >>> +1
>> > > > >>>
>> > > > >>> On Fri, Oct 15, 2021 at 3:41 PM Nikita Amelchev <
>> > namelchev@apache.org>
>> > > > >>> wrote:
>> > > > >>>
>> > > > >>>> +1 for deprecation in the 2.12 release
>> > > > >>>>
>> > > > >>>> пт, 15 окт. 2021 г. в 15:35, Nikolay Izhikov <
>> nizhikov@apache.org
>> > >:
>> > > > >>>>>
>> > > > >>>>> Hello, Igniters.
>> > > > >>>>>
>> > > > >>>>> I’ve prepared IEP-80 [1] to track breaking changes that should
>> > be done
>> > > > >>>> in Ignite 2.x.
>> > > > >>>>>
>> > > > >>>>> We agreed on the following algorithm to deal with breaking
>> > changes:
>> > > > >>>>>
>> > > > >>>>> - Ignite 2.[x] - deprecate the API + notification of the
>> users.
>> > > > >>>>> - Ignite 2.[x+1] - API removal.
>> > > > >>>>>
>> > > > >>>>>
>> > > > >>>>> I propose to start these improvements with the d&r
>> (depuration &
>> > > > >>>> removal) of the following features:
>> > > > >>>>>
>> > > > >>>>> - LOCAL caches
>> > > > >>>>> - MVCC caches
>> > > > >>>>> - legacy service grid implementation
>> > > > >>>>> - legacy JMX metrics beans.
>> > > > >>>>>
>> > > > >>>>> Deprecation in 2.12
>> > > > >>>>> Removal in 2.13
>> > > > >>>>>
>> > > > >>>>> Please, share your opinion.
>> > > > >>>>>
>> > > > >>>>> [1]
>> > > > >>>>
>> >
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=191334475
>> > > > >>>>
>> > > > >>>>
>> > > > >>>>
>> > > > >>>> --
>> > > > >>>> Best wishes,
>> > > > >>>> Amelchev Nikita
>> > > > >>>>
>> > > > >
>> > > >
>> >
>>
>>
>> --
>> Best Regards,
>> Vyacheslav D.
>>
>
>
> --
> Sincerely yours, Ivan Daschinskiy
>
--
Sincerely yours, Ivan Daschinskiy
Re: [DISCUSSION][IEP-80] Breaking changes in Ignite-2.x
Posted by Ivan Daschinsky <iv...@gmail.com>.
Guys, what is the status of ignite-shmem and TcpCommunication through it?
1. Native part has not been built at all since 2015
2. It is currently broken in master -- I've fixed some NPE and metrics
conversion locally and it works for me. It is broken for almost a year.
3. GridShmemCommunicationClient is not covered by tests.
What do you think we should do with this?
сб, 27 нояб. 2021 г. в 23:32, Vyacheslav Daradur <da...@gmail.com>:
> LGTM. Merged to master.
>
> Thank you for your contribution!
>
> On Fri, Nov 26, 2021 at 12:20 PM Maxim Muzafarov <mm...@apache.org>
> wrote:
>
> > Folks,
> >
> > This is a friendly reminder :-)
> > PR [1] is ready for review. Will anyone take a look?
> >
> > [1] https://github.com/apache/ignite/pull/9577/files
> >
> > On Sat, 20 Nov 2021 at 03:17, Maxim Muzafarov <mm...@apache.org> wrote:
> > >
> > > Folks,
> > >
> > >
> > > I've prepared the changes related to the legacy Service Grid removal
> > > for the 2.13 release. Here is the issue [1] and the PR [2] of these
> > > changes.
> > >
> > > Some important notes:
> > >
> > > - Removed GridServiceProcessor legacy implementation (internal)
> > > - The IGNITE_EVENT_DRIVEN_SERVICE_PROCESSOR_ENABLED system property
> > > was removed (this is a breaking change)
> > > - The ATTR_EVENT_DRIVEN_SERVICE_PROCESSOR_ENABLED node attribute was
> > > removed (this is a breaking change)
> > > - The node with 2.13 won't be able to connect to 2.12 (assume Ignite
> > > services are used)
> > >
> > > The legacy test suite [3] will be removed after the [1] issue will be
> > merged.
> > >
> > >
> > > Who can take a look at this PR?
> > >
> > >
> > > [1] https://issues.apache.org/jira/browse/IGNITE-15758
> > > [2] https://github.com/apache/ignite/pull/9577/files
> > > [3]
> >
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_ServiceGridLegacyMode
> > >
> > > On Fri, 22 Oct 2021 at 12:43, Nikolay Izhikov <ni...@apache.org>
> > wrote:
> > > >
> > > > Hello.
> > > >
> > > > In the scope of IEP-80 Breaking changes in Ignite-2.x PR for the
> > following API are prepared:
> > > >
> > > > 1. MVCC
> > > > - https://issues.apache.org/jira/browse/IGNITE-15757
> > > > - https://github.com/apache/ignite/pull/9516
> > > >
> > > > 2. LOCAL caches
> > > > - https://issues.apache.org/jira/browse/IGNITE-15756
> > > > - https://github.com/apache/ignite/pull/9515
> > > >
> > > > 3. CacheConfiguration#rebalanceDelay
> > > > - https://issues.apache.org/jira/browse/IGNITE-15764
> > > > - https://github.com/apache/ignite/pull/9515
> > > >
> > > > Please, review.
> > > >
> > > > > 15 окт. 2021 г., в 16:23, Nikolay Izhikov <ni...@gmail.com>
> > написал(а):
> > > > >
> > > > > THanks, Maksim.
> > > > >
> > > > > Tickets included in IEP scope and marked for d&r in 2.12-2.13
> > > > >
> > > > >> 15 окт. 2021 г., в 16:03, Maxim Muzafarov <mm...@apache.org>
> > написал(а):
> > > > >>
> > > > >> Let's deprecate RebalanceDelay and RebalanceMode=NONE also.
> > > > >>
> > > > >> [1] https://issues.apache.org/jira/browse/IGNITE-12662
> > > > >> [2] https://issues.apache.org/jira/browse/IGNITE-14613
> > > > >>
> > > > >> On Fri, 15 Oct 2021 at 15:46, Anton Vinogradov <av...@apache.org>
> > wrote:
> > > > >>>
> > > > >>> +1
> > > > >>>
> > > > >>> On Fri, Oct 15, 2021 at 3:41 PM Nikita Amelchev <
> > namelchev@apache.org>
> > > > >>> wrote:
> > > > >>>
> > > > >>>> +1 for deprecation in the 2.12 release
> > > > >>>>
> > > > >>>> пт, 15 окт. 2021 г. в 15:35, Nikolay Izhikov <
> nizhikov@apache.org
> > >:
> > > > >>>>>
> > > > >>>>> Hello, Igniters.
> > > > >>>>>
> > > > >>>>> I’ve prepared IEP-80 [1] to track breaking changes that should
> > be done
> > > > >>>> in Ignite 2.x.
> > > > >>>>>
> > > > >>>>> We agreed on the following algorithm to deal with breaking
> > changes:
> > > > >>>>>
> > > > >>>>> - Ignite 2.[x] - deprecate the API + notification of the
> users.
> > > > >>>>> - Ignite 2.[x+1] - API removal.
> > > > >>>>>
> > > > >>>>>
> > > > >>>>> I propose to start these improvements with the d&r (depuration
> &
> > > > >>>> removal) of the following features:
> > > > >>>>>
> > > > >>>>> - LOCAL caches
> > > > >>>>> - MVCC caches
> > > > >>>>> - legacy service grid implementation
> > > > >>>>> - legacy JMX metrics beans.
> > > > >>>>>
> > > > >>>>> Deprecation in 2.12
> > > > >>>>> Removal in 2.13
> > > > >>>>>
> > > > >>>>> Please, share your opinion.
> > > > >>>>>
> > > > >>>>> [1]
> > > > >>>>
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=191334475
> > > > >>>>
> > > > >>>>
> > > > >>>>
> > > > >>>> --
> > > > >>>> Best wishes,
> > > > >>>> Amelchev Nikita
> > > > >>>>
> > > > >
> > > >
> >
>
>
> --
> Best Regards,
> Vyacheslav D.
>
--
Sincerely yours, Ivan Daschinskiy
Re: [DISCUSSION][IEP-80] Breaking changes in Ignite-2.x
Posted by Vyacheslav Daradur <da...@gmail.com>.
LGTM. Merged to master.
Thank you for your contribution!
On Fri, Nov 26, 2021 at 12:20 PM Maxim Muzafarov <mm...@apache.org> wrote:
> Folks,
>
> This is a friendly reminder :-)
> PR [1] is ready for review. Will anyone take a look?
>
> [1] https://github.com/apache/ignite/pull/9577/files
>
> On Sat, 20 Nov 2021 at 03:17, Maxim Muzafarov <mm...@apache.org> wrote:
> >
> > Folks,
> >
> >
> > I've prepared the changes related to the legacy Service Grid removal
> > for the 2.13 release. Here is the issue [1] and the PR [2] of these
> > changes.
> >
> > Some important notes:
> >
> > - Removed GridServiceProcessor legacy implementation (internal)
> > - The IGNITE_EVENT_DRIVEN_SERVICE_PROCESSOR_ENABLED system property
> > was removed (this is a breaking change)
> > - The ATTR_EVENT_DRIVEN_SERVICE_PROCESSOR_ENABLED node attribute was
> > removed (this is a breaking change)
> > - The node with 2.13 won't be able to connect to 2.12 (assume Ignite
> > services are used)
> >
> > The legacy test suite [3] will be removed after the [1] issue will be
> merged.
> >
> >
> > Who can take a look at this PR?
> >
> >
> > [1] https://issues.apache.org/jira/browse/IGNITE-15758
> > [2] https://github.com/apache/ignite/pull/9577/files
> > [3]
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_ServiceGridLegacyMode
> >
> > On Fri, 22 Oct 2021 at 12:43, Nikolay Izhikov <ni...@apache.org>
> wrote:
> > >
> > > Hello.
> > >
> > > In the scope of IEP-80 Breaking changes in Ignite-2.x PR for the
> following API are prepared:
> > >
> > > 1. MVCC
> > > - https://issues.apache.org/jira/browse/IGNITE-15757
> > > - https://github.com/apache/ignite/pull/9516
> > >
> > > 2. LOCAL caches
> > > - https://issues.apache.org/jira/browse/IGNITE-15756
> > > - https://github.com/apache/ignite/pull/9515
> > >
> > > 3. CacheConfiguration#rebalanceDelay
> > > - https://issues.apache.org/jira/browse/IGNITE-15764
> > > - https://github.com/apache/ignite/pull/9515
> > >
> > > Please, review.
> > >
> > > > 15 окт. 2021 г., в 16:23, Nikolay Izhikov <ni...@gmail.com>
> написал(а):
> > > >
> > > > THanks, Maksim.
> > > >
> > > > Tickets included in IEP scope and marked for d&r in 2.12-2.13
> > > >
> > > >> 15 окт. 2021 г., в 16:03, Maxim Muzafarov <mm...@apache.org>
> написал(а):
> > > >>
> > > >> Let's deprecate RebalanceDelay and RebalanceMode=NONE also.
> > > >>
> > > >> [1] https://issues.apache.org/jira/browse/IGNITE-12662
> > > >> [2] https://issues.apache.org/jira/browse/IGNITE-14613
> > > >>
> > > >> On Fri, 15 Oct 2021 at 15:46, Anton Vinogradov <av...@apache.org>
> wrote:
> > > >>>
> > > >>> +1
> > > >>>
> > > >>> On Fri, Oct 15, 2021 at 3:41 PM Nikita Amelchev <
> namelchev@apache.org>
> > > >>> wrote:
> > > >>>
> > > >>>> +1 for deprecation in the 2.12 release
> > > >>>>
> > > >>>> пт, 15 окт. 2021 г. в 15:35, Nikolay Izhikov <nizhikov@apache.org
> >:
> > > >>>>>
> > > >>>>> Hello, Igniters.
> > > >>>>>
> > > >>>>> I’ve prepared IEP-80 [1] to track breaking changes that should
> be done
> > > >>>> in Ignite 2.x.
> > > >>>>>
> > > >>>>> We agreed on the following algorithm to deal with breaking
> changes:
> > > >>>>>
> > > >>>>> - Ignite 2.[x] - deprecate the API + notification of the users.
> > > >>>>> - Ignite 2.[x+1] - API removal.
> > > >>>>>
> > > >>>>>
> > > >>>>> I propose to start these improvements with the d&r (depuration &
> > > >>>> removal) of the following features:
> > > >>>>>
> > > >>>>> - LOCAL caches
> > > >>>>> - MVCC caches
> > > >>>>> - legacy service grid implementation
> > > >>>>> - legacy JMX metrics beans.
> > > >>>>>
> > > >>>>> Deprecation in 2.12
> > > >>>>> Removal in 2.13
> > > >>>>>
> > > >>>>> Please, share your opinion.
> > > >>>>>
> > > >>>>> [1]
> > > >>>>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=191334475
> > > >>>>
> > > >>>>
> > > >>>>
> > > >>>> --
> > > >>>> Best wishes,
> > > >>>> Amelchev Nikita
> > > >>>>
> > > >
> > >
>
--
Best Regards,
Vyacheslav D.
Re: [DISCUSSION][IEP-80] Breaking changes in Ignite-2.x
Posted by Maxim Muzafarov <mm...@apache.org>.
Folks,
This is a friendly reminder :-)
PR [1] is ready for review. Will anyone take a look?
[1] https://github.com/apache/ignite/pull/9577/files
On Sat, 20 Nov 2021 at 03:17, Maxim Muzafarov <mm...@apache.org> wrote:
>
> Folks,
>
>
> I've prepared the changes related to the legacy Service Grid removal
> for the 2.13 release. Here is the issue [1] and the PR [2] of these
> changes.
>
> Some important notes:
>
> - Removed GridServiceProcessor legacy implementation (internal)
> - The IGNITE_EVENT_DRIVEN_SERVICE_PROCESSOR_ENABLED system property
> was removed (this is a breaking change)
> - The ATTR_EVENT_DRIVEN_SERVICE_PROCESSOR_ENABLED node attribute was
> removed (this is a breaking change)
> - The node with 2.13 won't be able to connect to 2.12 (assume Ignite
> services are used)
>
> The legacy test suite [3] will be removed after the [1] issue will be merged.
>
>
> Who can take a look at this PR?
>
>
> [1] https://issues.apache.org/jira/browse/IGNITE-15758
> [2] https://github.com/apache/ignite/pull/9577/files
> [3] https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_ServiceGridLegacyMode
>
> On Fri, 22 Oct 2021 at 12:43, Nikolay Izhikov <ni...@apache.org> wrote:
> >
> > Hello.
> >
> > In the scope of IEP-80 Breaking changes in Ignite-2.x PR for the following API are prepared:
> >
> > 1. MVCC
> > - https://issues.apache.org/jira/browse/IGNITE-15757
> > - https://github.com/apache/ignite/pull/9516
> >
> > 2. LOCAL caches
> > - https://issues.apache.org/jira/browse/IGNITE-15756
> > - https://github.com/apache/ignite/pull/9515
> >
> > 3. CacheConfiguration#rebalanceDelay
> > - https://issues.apache.org/jira/browse/IGNITE-15764
> > - https://github.com/apache/ignite/pull/9515
> >
> > Please, review.
> >
> > > 15 окт. 2021 г., в 16:23, Nikolay Izhikov <ni...@gmail.com> написал(а):
> > >
> > > THanks, Maksim.
> > >
> > > Tickets included in IEP scope and marked for d&r in 2.12-2.13
> > >
> > >> 15 окт. 2021 г., в 16:03, Maxim Muzafarov <mm...@apache.org> написал(а):
> > >>
> > >> Let's deprecate RebalanceDelay and RebalanceMode=NONE also.
> > >>
> > >> [1] https://issues.apache.org/jira/browse/IGNITE-12662
> > >> [2] https://issues.apache.org/jira/browse/IGNITE-14613
> > >>
> > >> On Fri, 15 Oct 2021 at 15:46, Anton Vinogradov <av...@apache.org> wrote:
> > >>>
> > >>> +1
> > >>>
> > >>> On Fri, Oct 15, 2021 at 3:41 PM Nikita Amelchev <na...@apache.org>
> > >>> wrote:
> > >>>
> > >>>> +1 for deprecation in the 2.12 release
> > >>>>
> > >>>> пт, 15 окт. 2021 г. в 15:35, Nikolay Izhikov <ni...@apache.org>:
> > >>>>>
> > >>>>> Hello, Igniters.
> > >>>>>
> > >>>>> I’ve prepared IEP-80 [1] to track breaking changes that should be done
> > >>>> in Ignite 2.x.
> > >>>>>
> > >>>>> We agreed on the following algorithm to deal with breaking changes:
> > >>>>>
> > >>>>> - Ignite 2.[x] - deprecate the API + notification of the users.
> > >>>>> - Ignite 2.[x+1] - API removal.
> > >>>>>
> > >>>>>
> > >>>>> I propose to start these improvements with the d&r (depuration &
> > >>>> removal) of the following features:
> > >>>>>
> > >>>>> - LOCAL caches
> > >>>>> - MVCC caches
> > >>>>> - legacy service grid implementation
> > >>>>> - legacy JMX metrics beans.
> > >>>>>
> > >>>>> Deprecation in 2.12
> > >>>>> Removal in 2.13
> > >>>>>
> > >>>>> Please, share your opinion.
> > >>>>>
> > >>>>> [1]
> > >>>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=191334475
> > >>>>
> > >>>>
> > >>>>
> > >>>> --
> > >>>> Best wishes,
> > >>>> Amelchev Nikita
> > >>>>
> > >
> >