You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/01/16 04:22:53 UTC
[GitHub] [incubator-apisix] lilien1010 opened a new pull request #1068: fix
path error when install with luarocks
lilien1010 opened a new pull request #1068: fix path error when install with luarocks
URL: https://github.com/apache/incubator-apisix/pull/1068
### Summary
fix path error when install with luarocks
### Full changelog
* bin/apisix
### Issues resolved
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request
#1068: fix path error when install with luarocks
Posted by GitBox <gi...@apache.org>.
lilien1010 commented on a change in pull request #1068: fix path error when install with luarocks
URL: https://github.com/apache/incubator-apisix/pull/1068#discussion_r367257797
##########
File path: bin/apisix
##########
@@ -103,8 +103,10 @@ worker_shutdown_timeout 3;
{% if stream_proxy then %}
stream {
lua_package_path "$prefix/deps/share/lua/5.1/?.lua;/usr/share/lua/5.1/apisix/lua/?.lua;]=]
+ .. [=[/usr/local/apisix/deps/share/lua/5.1/apisix/lua/?.lua;]=]
.. [=[{*apisix_lua_home*}/lua/?.lua;;{*lua_path*};";
lua_package_cpath "$prefix/deps/lib64/lua/5.1/?.so;]=]
+ .. [=[/usr/local/apisix/deps/lib/lua/5.1/?.so;]=]
Review comment:
understood
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis merged pull request #1068: fix path
error when install with luarocks
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1068: fix path error when install with luarocks
URL: https://github.com/apache/incubator-apisix/pull/1068
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1068: fix path error when install with luarocks
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1068: fix path error when install with luarocks
URL: https://github.com/apache/incubator-apisix/pull/1068#discussion_r367259469
##########
File path: bin/apisix
##########
@@ -149,8 +150,10 @@ stream {
http {
lua_package_path "$prefix/deps/share/lua/5.1/?.lua;/usr/share/lua/5.1/apisix/lua/?.lua;]=]
+ .. [=[/usr/local/apisix/deps/share/lua/5.1/apisix/lua/?.lua;]=]
.. [=[{*apisix_lua_home*}/lua/?.lua;;{*lua_path*};";
lua_package_cpath "$prefix/deps/lib64/lua/5.1/?.so;]=]
+ .. [=[/usr/local/apisix/deps/lib/lua/5.1/?.so;]=]
Review comment:
useless line, please remove it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1068: fix path error when install with luarocks
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1068: fix path error when install with luarocks
URL: https://github.com/apache/incubator-apisix/pull/1068#discussion_r367246683
##########
File path: bin/apisix
##########
@@ -103,8 +103,10 @@ worker_shutdown_timeout 3;
{% if stream_proxy then %}
stream {
lua_package_path "$prefix/deps/share/lua/5.1/?.lua;/usr/share/lua/5.1/apisix/lua/?.lua;]=]
+ .. [=[/usr/local/apisix/deps/share/lua/5.1/apisix/lua/?.lua;]=]
.. [=[{*apisix_lua_home*}/lua/?.lua;;{*lua_path*};";
lua_package_cpath "$prefix/deps/lib64/lua/5.1/?.so;]=]
+ .. [=[/usr/local/apisix/deps/lib/lua/5.1/?.so;]=]
Review comment:
I do not think this line is useful. We should drop it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1068: fix path error when install with luarocks
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1068: fix path error when install with luarocks
URL: https://github.com/apache/incubator-apisix/pull/1068#discussion_r367259320
##########
File path: bin/apisix
##########
@@ -149,8 +150,10 @@ stream {
http {
lua_package_path "$prefix/deps/share/lua/5.1/?.lua;/usr/share/lua/5.1/apisix/lua/?.lua;]=]
+ .. [=[/usr/local/apisix/deps/share/lua/5.1/apisix/lua/?.lua;]=]
Review comment:
should use `$prefix` too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request
#1068: fix path error when install with luarocks
Posted by GitBox <gi...@apache.org>.
lilien1010 commented on a change in pull request #1068: fix path error when install with luarocks
URL: https://github.com/apache/incubator-apisix/pull/1068#discussion_r367259892
##########
File path: bin/apisix
##########
@@ -149,8 +150,10 @@ stream {
http {
lua_package_path "$prefix/deps/share/lua/5.1/?.lua;/usr/share/lua/5.1/apisix/lua/?.lua;]=]
+ .. [=[/usr/local/apisix/deps/share/lua/5.1/apisix/lua/?.lua;]=]
.. [=[{*apisix_lua_home*}/lua/?.lua;;{*lua_path*};";
lua_package_cpath "$prefix/deps/lib64/lua/5.1/?.so;]=]
+ .. [=[/usr/local/apisix/deps/lib/lua/5.1/?.so;]=]
Review comment:
sorry, remove is done now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request
#1068: fix path error when install with luarocks
Posted by GitBox <gi...@apache.org>.
lilien1010 commented on a change in pull request #1068: fix path error when install with luarocks
URL: https://github.com/apache/incubator-apisix/pull/1068#discussion_r367257715
##########
File path: bin/apisix
##########
@@ -103,8 +103,10 @@ worker_shutdown_timeout 3;
{% if stream_proxy then %}
stream {
lua_package_path "$prefix/deps/share/lua/5.1/?.lua;/usr/share/lua/5.1/apisix/lua/?.lua;]=]
+ .. [=[/usr/local/apisix/deps/share/lua/5.1/apisix/lua/?.lua;]=]
Review comment:
sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1068: fix path error when install with luarocks
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1068: fix path error when install with luarocks
URL: https://github.com/apache/incubator-apisix/pull/1068#discussion_r367246489
##########
File path: bin/apisix
##########
@@ -103,8 +103,10 @@ worker_shutdown_timeout 3;
{% if stream_proxy then %}
stream {
lua_package_path "$prefix/deps/share/lua/5.1/?.lua;/usr/share/lua/5.1/apisix/lua/?.lua;]=]
+ .. [=[/usr/local/apisix/deps/share/lua/5.1/apisix/lua/?.lua;]=]
Review comment:
How about `[=[$prefix/deps/share/lua/5.1/apisix/lua/?.lua;]=]`?
I think this is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request
#1068: fix path error when install with luarocks
Posted by GitBox <gi...@apache.org>.
lilien1010 commented on a change in pull request #1068: fix path error when install with luarocks
URL: https://github.com/apache/incubator-apisix/pull/1068#discussion_r367259844
##########
File path: bin/apisix
##########
@@ -149,8 +150,10 @@ stream {
http {
lua_package_path "$prefix/deps/share/lua/5.1/?.lua;/usr/share/lua/5.1/apisix/lua/?.lua;]=]
+ .. [=[/usr/local/apisix/deps/share/lua/5.1/apisix/lua/?.lua;]=]
Review comment:
sorry, remove is done now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services