You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lordcheng10 (via GitHub)" <gi...@apache.org> on 2023/05/16 03:19:31 UTC

[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #20292: [feat][broker] introduce precise broker publish rate limiting

lordcheng10 commented on code in PR #20292:
URL: https://github.com/apache/pulsar/pull/20292#discussion_r1194562212


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java:
##########
@@ -1116,6 +1116,12 @@ public boolean isBrokerPublishRateExceeded() {
         return  getBrokerPublishRateLimiter().isPublishRateExceeded();
     }
 
+    public boolean isBrokerPublishRateExceeded(int numberMessages, int bytes) {
+        // whether broker publish rate exceed
+        return preciseTopicPublishRateLimitingEnable

Review Comment:
   fixed.
   add config preciseBrokerPublishRateLimiterEnable



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org