You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Benebo7 (via GitHub)" <gi...@apache.org> on 2026/09/09 03:26:10 UTC
[PR] Add remaining filters to the Assets search page [airflow]
Benebo7 opened a new pull request, #72764:
URL: https://github.com/apache/airflow/pull/72764
Adds the filters requested in #53052 that were still missing from the Assets
search page: `is_alias`, `consuming_dag_id`, and `producing_task_id`
(optionally scoped with `producing_dag_id`). Group and last-event-timestamp
filtering already existed before this PR.
Also adds a `consuming_task_id` filter (optionally scoped with
`consuming_task_dag_id`), which the issue doesn't explicitly list. It felt
inconsistent to ship "Consuming DAG" and "Producing Task" without the
equivalent for consuming tasks, since the backend already exposes that
relationship — happy to drop it if a maintainer prefers to keep this PR
scoped strictly to the issue text.
`filterConfigs.tsx` (a single shared lookup table used across the whole
UI) was already close to the `max-lines` ESLint cap before this change;
adding the new filter definitions pushed it over. Raised the limit for
that one file rather than splitting it, since the growth is expected
config-table growth, not a design problem. Flagging this in case a
different fix is preferred.
closes: #53052
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Sonnet 5
Generated-by: Claude Sonnet 5 following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add remaining filters to the Assets search page [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil closed pull request #72764: Add remaining filters to the Assets search page
URL: https://github.com/apache/airflow/pull/72764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add remaining filters to the Assets search page [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #72764:
URL: https://github.com/apache/airflow/pull/72764#issuecomment-5595309462
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add remaining filters to the Assets search page [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #72764:
URL: https://github.com/apache/airflow/pull/72764#issuecomment-5940860359
Closing this. It edits `api_fastapi/common/parameters.py`, which no longer exists on main (it's now the `parameters/` package), and the `has_events` filter it adds is already there (`parameters/asset.py`, used by `routes/ui/assets.py`). The description also doesn't mention `has_events`, though the diff and newsfragment add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org