[GitHub] [spark] cloud-fan commented on a change in pull request #31884: [SPARK-34793][SQL] Prohibit saving of day-time and year-month intervals

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #31884:
URL: https://github.com/apache/spark/pull/31884#discussion_r597391806



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
##########
@@ -510,10 +510,7 @@ case class DataSource(
       physicalPlan: SparkPlan,
       metrics: Map[String, SQLMetric]): BaseRelation = {
     val outputColumns = DataWritingCommand.logicalPlanOutputWithNames(data, outputColumnNames)
-    if (outputColumns.map(_.dataType).exists(_.isInstanceOf[CalendarIntervalType])) {
-      throw QueryCompilationErrors.cannotSaveIntervalIntoExternalStorageError()
-    }
-
+    checkAllowedTypesInWrite(outputColumns.map(_.dataType))

Review comment:
       let's be more specific `disallowWritingIntervals`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org