You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@samza.apache.org by rgroothuijsen <gi...@git.apache.org> on 2018/08/04 19:50:33 UTC

[GitHub] samza pull request #598: SAMZA-1754: Improve validation error messages in St...

GitHub user rgroothuijsen opened a pull request:

    https://github.com/apache/samza/pull/598

    SAMZA-1754: Improve validation error messages in StreamSpec

    Currently, StreamSpec errors report only that an identifier has an invalid value, but they provide no context for the error. This PR includes the stream ID, physical name, system name and partition count in the error message, as requested in the ticket.
    
    Code changes:
    - Validation of the stream ID and system name is done after setting the fields, so that they can be read by the existing toString() method if an error occurs.
    - The output of toString() was prettified to look more pleasant and readable for end users.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rgroothuijsen/samza SAMZA-1754

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/598.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #598
    
----
commit 0bf90e8c346f845f06486e8ff4bcfe375037be0a
Author: Rens Groothuijsen <l....@...>
Date:   2018-08-04T18:54:48Z

    [SAMZA-1754] Add more context to StreamSpec validation exception

----


---