You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/06/03 11:44:54 UTC

[GitHub] [commons-fileupload] astiob commented on pull request #97: Use UploadContext instead deprecated method (RequestContext)

astiob commented on PR #97:
URL: https://github.com/apache/commons-fileupload/pull/97#issuecomment-1145880278

   Um. This code was explicitly intentional for backwards compatibility. The new code makes no sense together with the next line and throws `ClassCastException` if the provided context doesn’t implement `UploadContext`.
   
   This would be fine when `UploadContext` is merged into `RequestContext`, but as far as I can tell, it hasn’t been yet; and when it is, this code should be simplified by removing the next line, anyway.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org