You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2026/01/14 18:03:54 UTC
[PR] fix quoting [iceberg-python]
kevinjqliu opened a new pull request, #2913:
URL: https://github.com/apache/iceberg-python/pull/2913
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Follow up to #2912
CI still fails with
https://github.com/apache/iceberg-python/actions/runs/21004478697/job/60383069033
```
Error: cibuildwheel: Command ['C:\\Users\\runneradmin\\AppData\\Local\\Temp\\cibw-run-0tbpuziz\\cp310-win_amd64\\venv-test\\Scripts\\pip.EXE', 'install', 'pytest==7.4.2', 'moto==5.0.1', 'pytest-lazy-fixture==0.6.3', 'sqlalchemy>=2.0.18,<3'] failed with code 1.
Error: Process completed with exit code 1.
```
This PR fixes the quoting
## Are these changes tested?
## Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix quoting [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#issuecomment-3750916926
I wasnt able to run https://github.com/apache/iceberg-python/pull/2912 since the branch was not on the apache repo. Just pushed this branch to the apache repo and ran the nightly CI with the branch https://github.com/apache/iceberg-python/actions/runs/21004675670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "geruh (via GitHub)" <gi...@apache.org>.
geruh commented on code in PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#discussion_r2692097467
##########
.github/workflows/pypi-build-artifacts.yml:
##########
@@ -70,8 +70,8 @@ jobs:
# Ignore 32 bit architectures
CIBW_ARCHS: "auto64"
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10,<3.14"
- CIBW_TEST_REQUIRES: "pytest==7.4.2 moto==5.0.1 pytest-lazy-fixture==0.6.3 sqlalchemy>=2.0.18,<3"
- CIBW_TEST_COMMAND: "pytest {project}/tests/avro/test_decoder.py"
+ CIBW_BEFORE_TEST: "uv sync --directory {project} --only-group dev --no-install-project"
+ CIBW_TEST_COMMAND: "uv run --directory {project} pytest tests/avro/test_decoder.py"
Review Comment:
I agree, with our current infra today we won't need to figure out the CI deps is missing an entry with nightly if we just build all-extras. If CI runtime ever becomes a concern we can try out something like this.
As for the Makefile, I think the current setup is mostly helpful on the development and release side of things
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#issuecomment-3751210989
good point @jayceslesar let me try that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#discussion_r2708181819
##########
pyproject.toml:
##########
@@ -118,6 +118,7 @@ dev = [
"mypy-boto3-glue>=1.28.18",
"mypy-boto3-dynamodb>=1.28.18",
"pyarrow-stubs>=20.0.0.20251107", # Remove when pyarrow >= 23.0.0 https://github.com/apache/arrow/pull/47609
+ "sqlalchemy>=2.0.18,<3",
Review Comment:
Once the Cython parser is out, we can rip all this out :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "jayceslesar (via GitHub)" <gi...@apache.org>.
jayceslesar commented on PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#issuecomment-3751132826
Why do `uv pip install --group dev` instead of `uv sync --group dev` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#discussion_r2708180934
##########
pyproject.toml:
##########
@@ -118,6 +118,7 @@ dev = [
"mypy-boto3-glue>=1.28.18",
"mypy-boto3-dynamodb>=1.28.18",
"pyarrow-stubs>=20.0.0.20251107", # Remove when pyarrow >= 23.0.0 https://github.com/apache/arrow/pull/47609
+ "sqlalchemy>=2.0.18,<3",
Review Comment:
Yes, but it isn't being used for this specific test:
```
CIBW_TEST_COMMAND: "uv run --directory {project} pytest tests/avro/test_decoder.py"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "nssalian (via GitHub)" <gi...@apache.org>.
nssalian commented on PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#issuecomment-3751049247
Thanks for the fix @kevinjqliu . Looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#issuecomment-3751031711
cc @nssalian
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "geruh (via GitHub)" <gi...@apache.org>.
geruh commented on code in PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#discussion_r2692097467
##########
.github/workflows/pypi-build-artifacts.yml:
##########
@@ -70,8 +70,8 @@ jobs:
# Ignore 32 bit architectures
CIBW_ARCHS: "auto64"
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10,<3.14"
- CIBW_TEST_REQUIRES: "pytest==7.4.2 moto==5.0.1 pytest-lazy-fixture==0.6.3 sqlalchemy>=2.0.18,<3"
- CIBW_TEST_COMMAND: "pytest {project}/tests/avro/test_decoder.py"
+ CIBW_BEFORE_TEST: "uv sync --directory {project} --only-group dev --no-install-project"
+ CIBW_TEST_COMMAND: "uv run --directory {project} pytest tests/avro/test_decoder.py"
Review Comment:
I agree, with our current infra today we won't need to maintain separate lists if we use all dependencies but, If CI runtime ever becomes a concern we can try out something like this.
As for the Makefile, I think the current setup is mostly helpful on the development and release side of things
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#discussion_r2692021933
##########
.github/workflows/pypi-build-artifacts.yml:
##########
@@ -70,8 +70,8 @@ jobs:
# Ignore 32 bit architectures
CIBW_ARCHS: "auto64"
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10,<3.14"
- CIBW_TEST_REQUIRES: "pytest==7.4.2 moto==5.0.1 pytest-lazy-fixture==0.6.3 sqlalchemy>=2.0.18,<3"
- CIBW_TEST_COMMAND: "pytest {project}/tests/avro/test_decoder.py"
+ CIBW_BEFORE_TEST: "uv sync --directory {project} --only-group dev --no-install-project"
+ CIBW_TEST_COMMAND: "uv run --directory {project} pytest tests/avro/test_decoder.py"
Review Comment:
yea good point! on the flip side, we're not currently using the `dev` group for running unit tests 😆 we install all deps
https://github.com/apache/iceberg-python/blob/9ab4f045e2af99d319f8d87637c14009226e15cf/Makefile#L72-L73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#discussion_r2696401528
##########
pyproject.toml:
##########
@@ -118,6 +118,7 @@ dev = [
"mypy-boto3-glue>=1.28.18",
"mypy-boto3-dynamodb>=1.28.18",
"pyarrow-stubs>=20.0.0.20251107", # Remove when pyarrow >= 23.0.0 https://github.com/apache/arrow/pull/47609
+ "sqlalchemy>=2.0.18,<3",
Review Comment:
yep it is, now that we have `SqlCatalog` in conftest.py, this is technically a new "dev dependency"
https://github.com/apache/iceberg-python/blob/8e4d42483bbab92fc76538e32574c0336b3dd9d5/tests/conftest.py#L2965-L2972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#discussion_r2696401528
##########
pyproject.toml:
##########
@@ -118,6 +118,7 @@ dev = [
"mypy-boto3-glue>=1.28.18",
"mypy-boto3-dynamodb>=1.28.18",
"pyarrow-stubs>=20.0.0.20251107", # Remove when pyarrow >= 23.0.0 https://github.com/apache/arrow/pull/47609
+ "sqlalchemy>=2.0.18,<3",
Review Comment:
yep it is for the SqlCatalog. Now that we have `SqlCatalog` in conftest.py, this is technically a new "dev dependency"
https://github.com/apache/iceberg-python/blob/8e4d42483bbab92fc76538e32574c0336b3dd9d5/tests/conftest.py#L2965-L2972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#issuecomment-3757450298
Thanks for the review, everyone!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#discussion_r2695710757
##########
pyproject.toml:
##########
@@ -118,6 +118,7 @@ dev = [
"mypy-boto3-glue>=1.28.18",
"mypy-boto3-dynamodb>=1.28.18",
"pyarrow-stubs>=20.0.0.20251107", # Remove when pyarrow >= 23.0.0 https://github.com/apache/arrow/pull/47609
+ "sqlalchemy>=2.0.18,<3",
Review Comment:
I guess that this is for the SqlCatalog. Wouldn't it be cleaner to see if we can remove those direct imports (probably in the `conftest.py`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "geruh (via GitHub)" <gi...@apache.org>.
geruh commented on code in PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#discussion_r2691995331
##########
.github/workflows/pypi-build-artifacts.yml:
##########
@@ -70,8 +70,8 @@ jobs:
# Ignore 32 bit architectures
CIBW_ARCHS: "auto64"
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10,<3.14"
- CIBW_TEST_REQUIRES: "pytest==7.4.2 moto==5.0.1 pytest-lazy-fixture==0.6.3 sqlalchemy>=2.0.18,<3"
- CIBW_TEST_COMMAND: "pytest {project}/tests/avro/test_decoder.py"
+ CIBW_BEFORE_TEST: "uv sync --directory {project} --only-group dev --no-install-project"
+ CIBW_TEST_COMMAND: "uv run --directory {project} pytest tests/avro/test_decoder.py"
Review Comment:
This uv usage in the build wheels is a great addition! Now the CIBW dependencies won't need to be manually updated and can be kept in sync with the pyproject versions.
I believe this command will use the entire list of dependencies in the dev group. I think here or as a followup we could create a minimal `wheel-test` dependency group in the pyproject file with just pytest, moto, pytest-lazy-fixture, and sqlalchemy. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "jayceslesar (via GitHub)" <gi...@apache.org>.
jayceslesar commented on code in PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#discussion_r2692055893
##########
.github/workflows/pypi-build-artifacts.yml:
##########
@@ -70,8 +70,8 @@ jobs:
# Ignore 32 bit architectures
CIBW_ARCHS: "auto64"
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10,<3.14"
- CIBW_TEST_REQUIRES: "pytest==7.4.2 moto==5.0.1 pytest-lazy-fixture==0.6.3 sqlalchemy>=2.0.18,<3"
- CIBW_TEST_COMMAND: "pytest {project}/tests/avro/test_decoder.py"
+ CIBW_BEFORE_TEST: "uv sync --directory {project} --only-group dev --no-install-project"
+ CIBW_TEST_COMMAND: "uv run --directory {project} pytest tests/avro/test_decoder.py"
Review Comment:
I think it makes sense to use all deps for the make command.
Looking at it more closely there is sort of gray area of what is covered in the `Makefile` vs what is covered in CI. Should build logic be moved to the `Makefile` and then used in CI instead of being defined separately? (not a blocker for this PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#discussion_r2692215857
##########
.github/workflows/pypi-build-artifacts.yml:
##########
@@ -70,8 +70,8 @@ jobs:
# Ignore 32 bit architectures
CIBW_ARCHS: "auto64"
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10,<3.14"
- CIBW_TEST_REQUIRES: "pytest==7.4.2 moto==5.0.1 pytest-lazy-fixture==0.6.3 sqlalchemy>=2.0.18,<3"
- CIBW_TEST_COMMAND: "pytest {project}/tests/avro/test_decoder.py"
+ CIBW_BEFORE_TEST: "uv sync --directory {project} --only-group dev --no-install-project"
+ CIBW_TEST_COMMAND: "uv run --directory {project} pytest tests/avro/test_decoder.py"
Review Comment:
thanks, everyone! just added `--all-extras` to ensure we're using the same env
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#discussion_r2692024628
##########
.github/workflows/pypi-build-artifacts.yml:
##########
@@ -70,8 +70,8 @@ jobs:
# Ignore 32 bit architectures
CIBW_ARCHS: "auto64"
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10,<3.14"
- CIBW_TEST_REQUIRES: "pytest==7.4.2 moto==5.0.1 pytest-lazy-fixture==0.6.3 sqlalchemy>=2.0.18,<3"
- CIBW_TEST_COMMAND: "pytest {project}/tests/avro/test_decoder.py"
+ CIBW_BEFORE_TEST: "uv sync --directory {project} --only-group dev --no-install-project"
+ CIBW_TEST_COMMAND: "uv run --directory {project} pytest tests/avro/test_decoder.py"
Review Comment:
id prefer to sync more deps than less, esp since any deps can be added to conftest.py that will be used here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#issuecomment-3751474859
that works! https://github.com/apache/iceberg-python/actions/runs/21007310527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#discussion_r2692229563
##########
.github/workflows/pypi-build-artifacts.yml:
##########
@@ -70,8 +70,8 @@ jobs:
# Ignore 32 bit architectures
CIBW_ARCHS: "auto64"
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10,<3.14"
- CIBW_TEST_REQUIRES: "pytest==7.4.2 moto==5.0.1 pytest-lazy-fixture==0.6.3 sqlalchemy>=2.0.18,<3"
- CIBW_TEST_COMMAND: "pytest {project}/tests/avro/test_decoder.py"
+ CIBW_BEFORE_TEST: "uv sync --directory {project} --only-group dev --no-install-project"
+ CIBW_TEST_COMMAND: "uv run --directory {project} pytest tests/avro/test_decoder.py"
Review Comment:
looks like we cant use `--all-extras` since some packages are not built for all OS
https://github.com/apache/iceberg-python/actions/runs/21011365111/job/60406789772
```
help: `kerberos` (v1.3.1) was included because `pyiceberg[hive-kerberos]`
(v0.10.0.dev20260114215844) depends on `kerberos`
```
reverting back to just `dev` for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] sync cibuildwheel test env with uv [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#issuecomment-3751030203
Awesome, it worked https://github.com/apache/iceberg-python/actions/runs/21005261083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org