[GitHub] milleruntime commented on a change in pull request #372: ACCUMULO-4779 Improved performance get by prefix in config

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #372: ACCUMULO-4779 Improved performance get by prefix in config
URL: https://github.com/apache/accumulo/pull/372#discussion_r165496083
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java
 ##########
 @@ -33,15 +36,28 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import com.google.common.base.Preconditions;
 import com.google.common.base.Predicate;
 import com.google.common.base.Predicates;
+import com.google.common.collect.ImmutableMap;
 
 /**
  * A configuration object.
  */
 public abstract class AccumuloConfiguration implements Iterable<Entry<String,String>> {
 
+  private static class PrefixProps {
+    final long updateCount;
+    final Map<String,String> props;
+
+    PrefixProps(Map<String,String> props, long updateCount) {
 
 Review comment:
   If the updateCount is an arbitrary counter, why do you need to continue counting when a new Map is generated? Couldn't you just reset it back to 0?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services