You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2015/03/14 14:35:04 UTC

[Bug 57705] New: RemoteAddrValve: no log message no explanation when valve rejects request

https://bz.apache.org/bugzilla/show_bug.cgi?id=57705

            Bug ID: 57705
           Summary: RemoteAddrValve: no log message no explanation when
                    valve rejects request
           Product: Tomcat 7
           Version: 7.0.59
          Hardware: PC
                OS: Mac OS X 10.1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: minfrin@sharp.fm

When the RemoteAddrValve denies a request, no message is logged, and no
explanation appears in the generated HTML page.

There needs to be some indication that the RemoteAddrValve is involved so the
admin isn't sent on a wild goose chase.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 57705] RemoteAddrValve: no log message no explanation when valve rejects request

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57705

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
Patches welcome.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 57705] RemoteAddrValve: no log message no explanation when valve rejects request

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57705

--- Comment #2 from Graham Leggett <mi...@sharp.fm> ---
Created attachment 32570
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=32570&action=edit
Add debug log when request is denied

Patch added as requested, should this message be at debug level or at notice
level?

A rejected request is usually the kind of thing you'd expect to be logged
visibly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 57705] RemoteAddrValve: no log message no explanation when valve rejects request

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57705

Graham Leggett <mi...@sharp.fm> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 57705] RemoteAddrValve: no log message no explanation when valve rejects request

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57705

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Mark Thomas <ma...@apache.org> ---
Thanks for the patch.

I applied a variantion that modified both the Valves and the Filters.

The new debug logging has been implemnted in:
- 9.0.x for 9.0.0.M9 onwards
- 8.5.x for 8.5.4 onwards
- 8.0.x for 8.0.37 onwards
- 7.0.x for 7.0.71 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org