You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/09/19 17:23:37 UTC
[GitHub] [incubator-echarts] SnailSword opened a new pull request #13312: feat(sample): support largest-triangle-three-buckets algo
SnailSword opened a new pull request #13312:
URL: https://github.com/apache/incubator-echarts/pull/13312
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [x] new feature
- [ ] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
Support largest-triangle-three-buckets sampling algorithm.
### Fixed issues
<!--
- #xxxx: ...
-->
#9403
## Usage
### Are there any API changes?
- [x] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
sampling: 'lttb'
### Related test cases or examples to use the new APIs
```
{
type: 'line',
sampling: 'lttb',
data: data
}
```
See **test/line-large.html** line 101.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] SnailSword closed pull request #13312: feat(sample): support largest-triangle-three-buckets algo
Posted by GitBox <gi...@apache.org>.
SnailSword closed pull request #13312:
URL: https://github.com/apache/incubator-echarts/pull/13312
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13312: feat(sample): support largest-triangle-three-buckets algo
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13312:
URL: https://github.com/apache/incubator-echarts/pull/13312#issuecomment-695334694
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
Document changes are required in this PR. Please also make a PR to [apache/incubator-echarts-doc](https://github.com/apache/incubator-echarts-doc) for document changes. When the doc PR is merged, the maintainers will remove the `PR: awaiting doc` label.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] SnailSword commented on pull request #13312: feat(sample): support largest-triangle-three-buckets algo
Posted by GitBox <gi...@apache.org>.
SnailSword commented on pull request #13312:
URL: https://github.com/apache/incubator-echarts/pull/13312#issuecomment-695882203
> Thanks a lot for the work! Do you mind changing the pull request target to the next branch
@pissang OK, I will open a new pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #13312: feat(sample): support largest-triangle-three-buckets algo
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #13312:
URL: https://github.com/apache/incubator-echarts/pull/13312#issuecomment-695739495
Thanks a lot for the work! Do you mind changing the pull request target to the next branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] SnailSword commented on pull request #13312: feat(sample): support largest-triangle-three-buckets algo
Posted by GitBox <gi...@apache.org>.
SnailSword commented on pull request #13312:
URL: https://github.com/apache/incubator-echarts/pull/13312#issuecomment-695882203
> Thanks a lot for the work! Do you mind changing the pull request target to the next branch
@pissang OK, I will open a new pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] SnailSword closed pull request #13312: feat(sample): support largest-triangle-three-buckets algo
Posted by GitBox <gi...@apache.org>.
SnailSword closed pull request #13312:
URL: https://github.com/apache/incubator-echarts/pull/13312
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org