You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/23 04:10:22 UTC
[GitHub] [incubator-nuttx] btashton opened a new pull request #611: Run CI
using image built in incubator-nuttx-testing and enable esp32 build
btashton opened a new pull request #611: Run CI using image built in incubator-nuttx-testing and enable esp32 build
URL: https://github.com/apache/incubator-nuttx/pull/611
This updates the GitHub action to use the container that is built by incubator-nuttx-testing. It also update the ESP32 postbuild step to have the binary blob path be configurable making it easier to use pre-built files rather than expecting the whole esp-idf project to be available.
This does require this PR to be merged first apache/incubator-nuttx-testing#20
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #611: Run CI
using image built in incubator-nuttx-testing and enable esp32 build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #611: Run CI using image built in incubator-nuttx-testing and enable esp32 build
URL: https://github.com/apache/incubator-nuttx/pull/611#issuecomment-605401220
@btashton the path need rebase the latest mainline, because PR:
https://github.com/apache/incubator-nuttx/pull/635
https://github.com/apache/incubator-nuttx-apps/pull/145
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on a change in pull request
#611: Run CI using image built in incubator-nuttx-testing and enable esp32
build
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #611: Run CI using image built in incubator-nuttx-testing and enable esp32 build
URL: https://github.com/apache/incubator-nuttx/pull/611#discussion_r399625018
##########
File path: .github/actions/ci-container/action.yaml
##########
@@ -0,0 +1,7 @@
+name: ci-container
Review comment:
I'll add the copyright, but I will probably just expose an input to the action so that it can have the correct container tag used. I would like to wait until we know how that will work, I have not done windows builds in a container via github actions, I have only done them on the runner directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #611: Run CI
using image built in incubator-nuttx-testing and enable esp32 build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #611: Run CI using image built in incubator-nuttx-testing and enable esp32 build
URL: https://github.com/apache/incubator-nuttx/pull/611
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #611: Run CI using image built in incubator-nuttx-testing and
enable esp32 build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #611: Run CI using image built in incubator-nuttx-testing and enable esp32 build
URL: https://github.com/apache/incubator-nuttx/pull/611#discussion_r399624244
##########
File path: .github/actions/ci-container/action.yaml
##########
@@ -0,0 +1,7 @@
+name: ci-container
Review comment:
Should we add linux into the name to distinguish the upcoming windows doc?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on a change in pull request
#611: Run CI using image built in incubator-nuttx-testing and enable esp32
build
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #611: Run CI using image built in incubator-nuttx-testing and enable esp32 build
URL: https://github.com/apache/incubator-nuttx/pull/611#discussion_r399483624
##########
File path: .github/workflows/main.yml
##########
@@ -60,12 +59,12 @@ jobs:
build:
runs-on: ubuntu-18.04
- container: liuguo09/ubuntu-nuttx:18.04
+ env:
+ DOCKER_BUILDKIT: 1
strategy:
matrix:
- boards: [arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, arm-14, arm-15, mips-riscv-x86, sim]
-
+ boards: [arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, arm-14, arm-15, mips-riscv-x86, sim, xtensa]
Review comment:
Updated to use this instead. Not the CI on this will fail until the PR in testing is merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #611:
Run CI using image built in incubator-nuttx-testing and enable esp32 build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #611: Run CI using image built in incubator-nuttx-testing and enable esp32 build
URL: https://github.com/apache/incubator-nuttx/pull/611#issuecomment-605401220
@btashton the patch need rebase the latest mainline, because PR:
https://github.com/apache/incubator-nuttx/pull/635
https://github.com/apache/incubator-nuttx-apps/pull/145
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on issue #611: Run CI using
image built in incubator-nuttx-testing and enable esp32 build
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #611: Run CI using image built in incubator-nuttx-testing and enable esp32 build
URL: https://github.com/apache/incubator-nuttx/pull/611#issuecomment-605405204
@xiaoxiang781216 Should be good now. Let me know if there is anything else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #611: Run CI using image built in incubator-nuttx-testing and
enable esp32 build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #611: Run CI using image built in incubator-nuttx-testing and enable esp32 build
URL: https://github.com/apache/incubator-nuttx/pull/611#discussion_r399624244
##########
File path: .github/actions/ci-container/action.yaml
##########
@@ -0,0 +1,7 @@
+name: ci-container
Review comment:
Should we add linux into the name to distinguish the upcoming windows doc?
And we need add copyright in this file too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on a change in pull request
#611: Run CI using image built in incubator-nuttx-testing and enable esp32
build
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #611: Run CI using image built in incubator-nuttx-testing and enable esp32 build
URL: https://github.com/apache/incubator-nuttx/pull/611#discussion_r399624892
##########
File path: .github/workflows/main.yml
##########
@@ -91,7 +90,21 @@ jobs:
repository: apache/incubator-nuttx-testing
path: testing
+ - name: Docker Login
+ uses: azure/docker-login@v1
+ with:
+ login-server: docker.pkg.github.com
+ username: ${GITHUB_ACTOR}
+ password: ${{ secrets.GITHUB_TOKEN }}
+
+ - name: Run Pull Container
Review comment:
It is basically zero cost. I left this so that we can see what the time for pull is, I'm worried that this is going to get quite large so I want to be able to keep an eye on it outside of test execution. It will be local after this so the next step does not have to download again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #611: Run CI using image built in incubator-nuttx-testing and
enable esp32 build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #611: Run CI using image built in incubator-nuttx-testing and enable esp32 build
URL: https://github.com/apache/incubator-nuttx/pull/611#discussion_r396211012
##########
File path: .github/workflows/main.yml
##########
@@ -60,12 +59,12 @@ jobs:
build:
runs-on: ubuntu-18.04
- container: liuguo09/ubuntu-nuttx:18.04
+ env:
+ DOCKER_BUILDKIT: 1
strategy:
matrix:
- boards: [arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, arm-14, arm-15, mips-riscv-x86, sim]
-
+ boards: [arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, arm-14, arm-15, mips-riscv-x86, sim, xtensa]
Review comment:
Since xtensa's config is very small, let's merge xtensa into mips-riscv-x86?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #611: Run CI using image built in incubator-nuttx-testing and
enable esp32 build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #611: Run CI using image built in incubator-nuttx-testing and enable esp32 build
URL: https://github.com/apache/incubator-nuttx/pull/611#discussion_r399624168
##########
File path: .github/workflows/main.yml
##########
@@ -91,7 +90,21 @@ jobs:
repository: apache/incubator-nuttx-testing
path: testing
+ - name: Docker Login
+ uses: azure/docker-login@v1
+ with:
+ login-server: docker.pkg.github.com
+ username: ${GITHUB_ACTOR}
+ password: ${{ secrets.GITHUB_TOKEN }}
+
+ - name: Run Pull Container
Review comment:
"Run builds already use ci-container at line 104, why we need another similar "Run Pull Container"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services