You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "JerryCai (via GitHub)" <gi...@apache.org> on 2024/10/22 04:48:49 UTC
[PR] KAFKA-17755 AbstractPartitionAssignor can not enable RackAwareAssignm… [kafka]
JerryCai opened a new pull request, #17571:
URL: https://github.com/apache/kafka/pull/17571
currently rack-aware partition assignor's design have obvious two
*The current implementation has two significant flaws:
1. Rely on the Kafka broker side to enable the configuration: replica.selector.class -> RackAwareReplicaSelector. This breaks the agreement that the Partition Assignor can be customized independently by the client.
2. It destroys the read-write consistency principle of Kafka, leading to load imbalance and many other side effects.
This improvement of merge request is based on the following ideas:
Always read messages from the leader of the broker, that is, do not enable replica.selector.class
, it can be aligned based only on the rack information of the leader, so that balance can be achieved first. In the case of balance, the same rack partition allocation strategy as the leader should be given priority as much as possible.*
*test include regression test and new feature test*
### Committer Checklist (excluded from commit message)
- [* ] Verify design and implementation
- [* ] Verify test coverage and CI build status
- [* ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17755 AbstractPartitionAssignor can not enable RackAwareAssignm… [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17571:
URL: https://github.com/apache/kafka/pull/17571#issuecomment-2728031146
This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17755 AbstractPartitionAssignor can not enable RackAwareAssignm… [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #17571:
URL: https://github.com/apache/kafka/pull/17571#issuecomment-2440904938
Hi @JerryCai. Thanks for the patch. I don't fully understand it and it seems that it does not fully correspond to the description in jira too. Could you please clarify? Side note: We cannot add new assignors without doing a KIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17755 AbstractPartitionAssignor can not enable RackAwareAssignm… [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on code in PR #17571:
URL: https://github.com/apache/kafka/pull/17571#discussion_r1810163822
##########
clients/src/test/java/org/apache/kafka/clients/consumer/AbstractLeaderRackAwareAssignorTest.java:
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.clients.consumer;
+
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+
+import org.apache.kafka.clients.consumer.ConsumerPartitionAssignor.Subscription;
+import org.apache.kafka.clients.consumer.internals.AbstractPartitionAssignor;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.PartitionInfo;
+import org.apache.kafka.common.TopicPartition;
+import org.junit.jupiter.api.Test;
+
+public abstract class AbstractLeaderRackAwareAssignorTest {
+
+ private String topic = "test-leader-rack--aware-topic";
+ public abstract AbstractPartitionAssignor getAssignor();
+ @Test
+ public void testFullBalancedLeaderRackAssign() {
+ Map<String, List<PartitionInfo>> partitionsPerTopic = new HashMap<>();
+ partitionsPerTopic.put(topic, Arrays.asList(
+ new PartitionInfo(topic, 0,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 1,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 2,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 3,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 4,
+ new Node(2, "node-2", 8888, "rack-c"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(1, "node-1", 8888, "rack-b")
+ }, null),
+ new PartitionInfo(topic, 5,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null)
+ ));
+
+ // Simulate two consumers subscribing to the topic
+ Map<String, Subscription> subscriptions = new HashMap<>();
+ subscriptions.put("consumer-a",
+ new Subscription(Collections.singletonList(topic), null, Collections.emptyList(), 1, Optional.of("rack-a")));
+ subscriptions.put("consumer-b",
+ new Subscription(Collections.singletonList(topic), null, Collections.emptyList(), 1, Optional.of("rack-b")));
+ subscriptions.put("consumer-c",
+ new Subscription(Collections.singletonList(topic), null, Collections.emptyList(), 1, Optional.of("rack-c")));
+
+ // Call the assignPartitions method
+ Map<String, List<TopicPartition>> assignment = getAssignor().assignPartitions(partitionsPerTopic,
+ subscriptions);
+
+ assertEquals(assignment.get("consumer-a"), Arrays.asList(new TopicPartition(topic, 0), new TopicPartition(topic, 1)));
+ assertEquals(assignment.get("consumer-b"), Arrays.asList(new TopicPartition(topic, 2), new TopicPartition(topic, 3)));
+ assertEquals(assignment.get("consumer-c"), Arrays.asList(new TopicPartition(topic, 4), new TopicPartition(topic, 5)));
+
+ }
+ @Test
+ public void testUnbalancedLeaderRackAssign() {
+ Map<String, List<PartitionInfo>> partitionsPerTopic = new HashMap<>();
+ partitionsPerTopic.put(topic, Arrays.asList(
+ new PartitionInfo(topic, 0,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 1,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 2,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 3,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 4,
+ new Node(2, "node-2", 8888, "rack-c"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(1, "node-1", 8888, "rack-b")
+ }, null),
+ new PartitionInfo(topic, 5,
+ new Node(1, "node-1", 8888, "rack-c"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-b")
+ }, null)
+ ));
+
+ // Simulate two consumers subscribing to the topic
+ Map<String, Subscription> subscriptions = new HashMap<>();
+ subscriptions.put("consumer-a",
Review Comment:
The `consumer-a` also as same as `assertEquals(assignment.get("consumer-a")`, how about excratct the variable like `String consumerA = "consumer-a"`
##########
clients/src/test/java/org/apache/kafka/clients/consumer/AbstractLeaderRackAwareAssignorTest.java:
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.clients.consumer;
+
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+
+import org.apache.kafka.clients.consumer.ConsumerPartitionAssignor.Subscription;
+import org.apache.kafka.clients.consumer.internals.AbstractPartitionAssignor;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.PartitionInfo;
+import org.apache.kafka.common.TopicPartition;
+import org.junit.jupiter.api.Test;
+
+public abstract class AbstractLeaderRackAwareAssignorTest {
+
+ private String topic = "test-leader-rack--aware-topic";
+ public abstract AbstractPartitionAssignor getAssignor();
+ @Test
+ public void testFullBalancedLeaderRackAssign() {
+ Map<String, List<PartitionInfo>> partitionsPerTopic = new HashMap<>();
+ partitionsPerTopic.put(topic, Arrays.asList(
+ new PartitionInfo(topic, 0,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 1,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 2,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 3,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 4,
+ new Node(2, "node-2", 8888, "rack-c"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(1, "node-1", 8888, "rack-b")
+ }, null),
+ new PartitionInfo(topic, 5,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null)
+ ));
+
+ // Simulate two consumers subscribing to the topic
+ Map<String, Subscription> subscriptions = new HashMap<>();
+ subscriptions.put("consumer-a",
Review Comment:
ditto, extract variable.
##########
clients/src/test/java/org/apache/kafka/clients/consumer/AbstractLeaderRackAwareAssignorTest.java:
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.clients.consumer;
+
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+
+import org.apache.kafka.clients.consumer.ConsumerPartitionAssignor.Subscription;
+import org.apache.kafka.clients.consumer.internals.AbstractPartitionAssignor;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.PartitionInfo;
+import org.apache.kafka.common.TopicPartition;
+import org.junit.jupiter.api.Test;
+
+public abstract class AbstractLeaderRackAwareAssignorTest {
+
+ private String topic = "test-leader-rack--aware-topic";
+ public abstract AbstractPartitionAssignor getAssignor();
+ @Test
+ public void testFullBalancedLeaderRackAssign() {
+ Map<String, List<PartitionInfo>> partitionsPerTopic = new HashMap<>();
+ partitionsPerTopic.put(topic, Arrays.asList(
+ new PartitionInfo(topic, 0,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 1,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 2,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 3,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 4,
+ new Node(2, "node-2", 8888, "rack-c"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(1, "node-1", 8888, "rack-b")
+ }, null),
+ new PartitionInfo(topic, 5,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null)
+ ));
+
+ // Simulate two consumers subscribing to the topic
+ Map<String, Subscription> subscriptions = new HashMap<>();
+ subscriptions.put("consumer-a",
+ new Subscription(Collections.singletonList(topic), null, Collections.emptyList(), 1, Optional.of("rack-a")));
+ subscriptions.put("consumer-b",
+ new Subscription(Collections.singletonList(topic), null, Collections.emptyList(), 1, Optional.of("rack-b")));
+ subscriptions.put("consumer-c",
+ new Subscription(Collections.singletonList(topic), null, Collections.emptyList(), 1, Optional.of("rack-c")));
+
+ // Call the assignPartitions method
+ Map<String, List<TopicPartition>> assignment = getAssignor().assignPartitions(partitionsPerTopic,
+ subscriptions);
+
+ assertEquals(assignment.get("consumer-a"), Arrays.asList(new TopicPartition(topic, 0), new TopicPartition(topic, 1)));
+ assertEquals(assignment.get("consumer-b"), Arrays.asList(new TopicPartition(topic, 2), new TopicPartition(topic, 3)));
+ assertEquals(assignment.get("consumer-c"), Arrays.asList(new TopicPartition(topic, 4), new TopicPartition(topic, 5)));
+
+ }
+ @Test
+ public void testUnbalancedLeaderRackAssign() {
+ Map<String, List<PartitionInfo>> partitionsPerTopic = new HashMap<>();
+ partitionsPerTopic.put(topic, Arrays.asList(
+ new PartitionInfo(topic, 0,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 1,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 2,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 3,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 4,
+ new Node(2, "node-2", 8888, "rack-c"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(1, "node-1", 8888, "rack-b")
+ }, null),
+ new PartitionInfo(topic, 5,
+ new Node(1, "node-1", 8888, "rack-c"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-b")
+ }, null)
+ ));
Review Comment:
ditto, extraxt to property
##########
clients/src/test/java/org/apache/kafka/clients/consumer/AbstractLeaderRackAwareAssignorTest.java:
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.clients.consumer;
+
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+
+import org.apache.kafka.clients.consumer.ConsumerPartitionAssignor.Subscription;
+import org.apache.kafka.clients.consumer.internals.AbstractPartitionAssignor;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.PartitionInfo;
+import org.apache.kafka.common.TopicPartition;
+import org.junit.jupiter.api.Test;
+
+public abstract class AbstractLeaderRackAwareAssignorTest {
+
+ private String topic = "test-leader-rack--aware-topic";
+ public abstract AbstractPartitionAssignor getAssignor();
+ @Test
+ public void testFullBalancedLeaderRackAssign() {
+ Map<String, List<PartitionInfo>> partitionsPerTopic = new HashMap<>();
+ partitionsPerTopic.put(topic, Arrays.asList(
+ new PartitionInfo(topic, 0,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 1,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 2,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 3,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 4,
+ new Node(2, "node-2", 8888, "rack-c"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(1, "node-1", 8888, "rack-b")
+ }, null),
+ new PartitionInfo(topic, 5,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null)
+ ));
+
+ // Simulate two consumers subscribing to the topic
+ Map<String, Subscription> subscriptions = new HashMap<>();
+ subscriptions.put("consumer-a",
+ new Subscription(Collections.singletonList(topic), null, Collections.emptyList(), 1, Optional.of("rack-a")));
+ subscriptions.put("consumer-b",
+ new Subscription(Collections.singletonList(topic), null, Collections.emptyList(), 1, Optional.of("rack-b")));
+ subscriptions.put("consumer-c",
Review Comment:
ditto, extract variable.
##########
clients/src/test/java/org/apache/kafka/clients/consumer/AbstractLeaderRackAwareAssignorTest.java:
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.clients.consumer;
+
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+
+import org.apache.kafka.clients.consumer.ConsumerPartitionAssignor.Subscription;
+import org.apache.kafka.clients.consumer.internals.AbstractPartitionAssignor;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.PartitionInfo;
+import org.apache.kafka.common.TopicPartition;
+import org.junit.jupiter.api.Test;
+
+public abstract class AbstractLeaderRackAwareAssignorTest {
+
+ private String topic = "test-leader-rack--aware-topic";
+ public abstract AbstractPartitionAssignor getAssignor();
+ @Test
+ public void testFullBalancedLeaderRackAssign() {
+ Map<String, List<PartitionInfo>> partitionsPerTopic = new HashMap<>();
+ partitionsPerTopic.put(topic, Arrays.asList(
+ new PartitionInfo(topic, 0,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 1,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 2,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 3,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 4,
+ new Node(2, "node-2", 8888, "rack-c"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(1, "node-1", 8888, "rack-b")
+ }, null),
+ new PartitionInfo(topic, 5,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null)
+ ));
Review Comment:
I think we should extract these `Node` instance to property, like
```
private final Node node0 = new Node(0, "node-0", 8888, "rack-a");
// ...
```
I consider these nodes are same meanings in this test, this code could be more simplify, WDYT?
##########
clients/src/test/java/org/apache/kafka/clients/consumer/LeaderRackAwareRangeAssignorTest.java:
##########
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.clients.consumer;
+
+import org.apache.kafka.clients.consumer.internals.AbstractPartitionAssignor;
+
+public class LeaderRackAwareRangeAssignorTest extends AbstractLeaderRackAwareAssignorTest {
+ @Override
+ public AbstractPartitionAssignor getAssignor() {
+
+ return new LeaderRackAwareRangeAssignor();
+ }
+}
Review Comment:
ditto, use `@ParameterizedTest`
##########
clients/src/test/java/org/apache/kafka/clients/consumer/LeaderRackAwareCooperativeStickyAssignorTest.java:
##########
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.clients.consumer;
+
+import org.apache.kafka.clients.consumer.internals.AbstractStickyAssignor;
+
+public class LeaderRackAwareCooperativeStickyAssignorTest extends AbstractLeaderRackAwareAssignorTest {
+ @Override
+ public AbstractStickyAssignor getAssignor() {
+
+ return new LeaderRackAwareCooperativeStickyAssignor();
+ }
+}
Review Comment:
IMHO, we should avoid to use `extend` on test, we can use `@ParameterizedTest` to test different arguments or classes, WDYT?
##########
clients/src/test/java/org/apache/kafka/clients/consumer/AbstractLeaderRackAwareAssignorTest.java:
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.clients.consumer;
+
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+
+import org.apache.kafka.clients.consumer.ConsumerPartitionAssignor.Subscription;
+import org.apache.kafka.clients.consumer.internals.AbstractPartitionAssignor;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.PartitionInfo;
+import org.apache.kafka.common.TopicPartition;
+import org.junit.jupiter.api.Test;
+
+public abstract class AbstractLeaderRackAwareAssignorTest {
+
+ private String topic = "test-leader-rack--aware-topic";
+ public abstract AbstractPartitionAssignor getAssignor();
+ @Test
+ public void testFullBalancedLeaderRackAssign() {
+ Map<String, List<PartitionInfo>> partitionsPerTopic = new HashMap<>();
+ partitionsPerTopic.put(topic, Arrays.asList(
+ new PartitionInfo(topic, 0,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 1,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 2,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 3,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 4,
+ new Node(2, "node-2", 8888, "rack-c"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(1, "node-1", 8888, "rack-b")
+ }, null),
+ new PartitionInfo(topic, 5,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null)
+ ));
+
+ // Simulate two consumers subscribing to the topic
+ Map<String, Subscription> subscriptions = new HashMap<>();
+ subscriptions.put("consumer-a",
+ new Subscription(Collections.singletonList(topic), null, Collections.emptyList(), 1, Optional.of("rack-a")));
+ subscriptions.put("consumer-b",
Review Comment:
ditto, extract variable.
##########
clients/src/test/java/org/apache/kafka/clients/consumer/AbstractLeaderRackAwareAssignorTest.java:
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.clients.consumer;
+
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+
+import org.apache.kafka.clients.consumer.ConsumerPartitionAssignor.Subscription;
+import org.apache.kafka.clients.consumer.internals.AbstractPartitionAssignor;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.PartitionInfo;
+import org.apache.kafka.common.TopicPartition;
+import org.junit.jupiter.api.Test;
+
+public abstract class AbstractLeaderRackAwareAssignorTest {
+
+ private String topic = "test-leader-rack--aware-topic";
+ public abstract AbstractPartitionAssignor getAssignor();
+ @Test
+ public void testFullBalancedLeaderRackAssign() {
+ Map<String, List<PartitionInfo>> partitionsPerTopic = new HashMap<>();
+ partitionsPerTopic.put(topic, Arrays.asList(
+ new PartitionInfo(topic, 0,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 1,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 2,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 3,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 4,
+ new Node(2, "node-2", 8888, "rack-c"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(1, "node-1", 8888, "rack-b")
+ }, null),
+ new PartitionInfo(topic, 5,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null)
+ ));
+
+ // Simulate two consumers subscribing to the topic
+ Map<String, Subscription> subscriptions = new HashMap<>();
+ subscriptions.put("consumer-a",
+ new Subscription(Collections.singletonList(topic), null, Collections.emptyList(), 1, Optional.of("rack-a")));
+ subscriptions.put("consumer-b",
+ new Subscription(Collections.singletonList(topic), null, Collections.emptyList(), 1, Optional.of("rack-b")));
+ subscriptions.put("consumer-c",
+ new Subscription(Collections.singletonList(topic), null, Collections.emptyList(), 1, Optional.of("rack-c")));
+
+ // Call the assignPartitions method
+ Map<String, List<TopicPartition>> assignment = getAssignor().assignPartitions(partitionsPerTopic,
+ subscriptions);
+
+ assertEquals(assignment.get("consumer-a"), Arrays.asList(new TopicPartition(topic, 0), new TopicPartition(topic, 1)));
+ assertEquals(assignment.get("consumer-b"), Arrays.asList(new TopicPartition(topic, 2), new TopicPartition(topic, 3)));
+ assertEquals(assignment.get("consumer-c"), Arrays.asList(new TopicPartition(topic, 4), new TopicPartition(topic, 5)));
+
+ }
+ @Test
+ public void testUnbalancedLeaderRackAssign() {
+ Map<String, List<PartitionInfo>> partitionsPerTopic = new HashMap<>();
+ partitionsPerTopic.put(topic, Arrays.asList(
+ new PartitionInfo(topic, 0,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 1,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 2,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 3,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 4,
+ new Node(2, "node-2", 8888, "rack-c"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(1, "node-1", 8888, "rack-b")
+ }, null),
+ new PartitionInfo(topic, 5,
+ new Node(1, "node-1", 8888, "rack-c"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-b")
+ }, null)
+ ));
+
+ // Simulate two consumers subscribing to the topic
+ Map<String, Subscription> subscriptions = new HashMap<>();
+ subscriptions.put("consumer-a",
+ new Subscription(Collections.singletonList(topic), null, Collections.emptyList(), 1, Optional.of("rack-a")));
+ subscriptions.put("consumer-b",
Review Comment:
ditto, extract variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17755 AbstractPartitionAssignor can not enable RackAwareAssignm… [kafka]
Posted by "JerryCai (via GitHub)" <gi...@apache.org>.
JerryCai commented on PR #17571:
URL: https://github.com/apache/kafka/pull/17571#issuecomment-2480905045
I created a KIP for this [KIP-1113: Enhancements to Rack-Aware Partition Assignor for Improved Client-Side Independence and Load Balancing](https://cwiki.apache.org/confluence/x/X5CMEw)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17755 AbstractPartitionAssignor can not enable RackAwareAssignm… [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #17571: KAFKA-17755 AbstractPartitionAssignor can not enable RackAwareAssignm…
URL: https://github.com/apache/kafka/pull/17571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17755 AbstractPartitionAssignor can not enable RackAwareAssignm… [kafka]
Posted by "JerryCai (via GitHub)" <gi...@apache.org>.
JerryCai commented on PR #17571:
URL: https://github.com/apache/kafka/pull/17571#issuecomment-2442054595
@dajac Got it, will do, thanks for your feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17755 AbstractPartitionAssignor can not enable RackAwareAssignm… [kafka]
Posted by "JerryCai (via GitHub)" <gi...@apache.org>.
JerryCai commented on code in PR #17571:
URL: https://github.com/apache/kafka/pull/17571#discussion_r1811010843
##########
clients/src/test/java/org/apache/kafka/clients/consumer/AbstractLeaderRackAwareAssignorTest.java:
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.clients.consumer;
+
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+
+import org.apache.kafka.clients.consumer.ConsumerPartitionAssignor.Subscription;
+import org.apache.kafka.clients.consumer.internals.AbstractPartitionAssignor;
+import org.apache.kafka.common.Node;
+import org.apache.kafka.common.PartitionInfo;
+import org.apache.kafka.common.TopicPartition;
+import org.junit.jupiter.api.Test;
+
+public abstract class AbstractLeaderRackAwareAssignorTest {
+
+ private String topic = "test-leader-rack--aware-topic";
+ public abstract AbstractPartitionAssignor getAssignor();
+ @Test
+ public void testFullBalancedLeaderRackAssign() {
+ Map<String, List<PartitionInfo>> partitionsPerTopic = new HashMap<>();
+ partitionsPerTopic.put(topic, Arrays.asList(
+ new PartitionInfo(topic, 0,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 1,
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node[]{
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 2,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 3,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null),
+ new PartitionInfo(topic, 4,
+ new Node(2, "node-2", 8888, "rack-c"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(1, "node-1", 8888, "rack-b")
+ }, null),
+ new PartitionInfo(topic, 5,
+ new Node(1, "node-1", 8888, "rack-b"),
+ new Node[]{
+ new Node(0, "node-0", 8888, "rack-a"),
+ new Node(2, "node-2", 8888, "rack-c")
+ }, null)
+ ));
Review Comment:
@m1a2st thanks for suggestions, but I think for unit test, This has good readability and flexibility, making it easier for everyone to understand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17755 AbstractPartitionAssignor can not enable RackAwareAssignm… [kafka]
Posted by "gharris1727 (via GitHub)" <gi...@apache.org>.
gharris1727 commented on PR #17571:
URL: https://github.com/apache/kafka/pull/17571#issuecomment-2438370160
@JerryCai Thanks for the PR!
I'm not familiar with this area, but I believe that adding new assignors is a change to our public API, and would require a KIP: https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
The ticket description made this sound like it was a backwards-compatible bug-fix, and that doesn't match this PR. Could you update the ticket to explain a bit more of the context for this change, what you've tried, expected and actual behavior, what you think could be improved, etc. That will help people understand the urgency and scope of this change, and make it easier to find reviewers.
Thanks for contributing to Kafka!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17755 AbstractPartitionAssignor can not enable RackAwareAssignm… [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17571:
URL: https://github.com/apache/kafka/pull/17571#issuecomment-2660698514
This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.
<p>
If you are having difficulty finding a reviewer, please reach out on the
[mailing list](https://kafka.apache.org/contact).
<p>
If this PR is no longer valid or desired, please feel free to close it. If no activity
occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org