You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/01/26 08:45:36 UTC
[GitHub] [tvm] chunit-quic opened a new pull request #10072: Revert "[Frontend] Add Span filling for frontends to Relay (#9723)"
chunit-quic opened a new pull request #10072:
URL: https://github.com/apache/tvm/pull/10072
Because of the failure the LSTM conversion from Pyotrch
https://github.com/apache/tvm/pull/9723
This reverts commit ce108c1f53235a483eb11dffffb8770642907642.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius merged pull request #10072: Revert "[Frontend] Add Span filling for frontends to Relay (#9723)"
Posted by GitBox <gi...@apache.org>.
Mousius merged pull request #10072:
URL: https://github.com/apache/tvm/pull/10072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] chunit-quic edited a comment on pull request #10072: Revert "[Frontend] Add Span filling for frontends to Relay (#9723)"
Posted by GitBox <gi...@apache.org>.
chunit-quic edited a comment on pull request #10072:
URL: https://github.com/apache/tvm/pull/10072#issuecomment-1022268740
> Thanks for identifying this and raising the revert quickly @chunit-quic 😸
Hi @Mousius,
No problem, my pleasure. :)
Sorry that didn't identify this at the very begging.
Based on the test_lstm.py, it's very surprising to me that we obtain the same execution result compared with pytorch outputs (using == but not isclose()). Even the RelayIR graph are different.
I am digging into it now. Will update status here once I find any solution or clues. :D
Quick update:
It seems that somewhere "duplicate" certain expressions, which are exactly the same as those span-tagged ones, and put them back to RelayIR.
That's the reason why the outputs are the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on pull request #10072: Revert "[Frontend] Add Span filling for frontends to Relay (#9723)"
Posted by GitBox <gi...@apache.org>.
Mousius commented on pull request #10072:
URL: https://github.com/apache/tvm/pull/10072#issuecomment-1022256640
Thanks for identifying this and raising the revert quickly @chunit-quic :smile_cat:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] chunit-quic edited a comment on pull request #10072: Revert "[Frontend] Add Span filling for frontends to Relay (#9723)"
Posted by GitBox <gi...@apache.org>.
chunit-quic edited a comment on pull request #10072:
URL: https://github.com/apache/tvm/pull/10072#issuecomment-1022268740
> Thanks for identifying this and raising the revert quickly @chunit-quic 😸
Hi @Mousius,
No problem, my pleasure. :)
Sorry that didn't identify this at the very begging.
Based on the test_lstm.py, it's very surprising to me that we obtain the same execution result compared with pytorch outputs (using == but not isclose()). Even the RelayIR graph are different.
I am digging into it now. Will update status here once I find any solution or clues. :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] chunit-quic commented on pull request #10072: Revert "[Frontend] Add Span filling for frontends to Relay (#9723)"
Posted by GitBox <gi...@apache.org>.
chunit-quic commented on pull request #10072:
URL: https://github.com/apache/tvm/pull/10072#issuecomment-1022268740
> Thanks for identifying this and raising the revert quickly @chunit-quic 😸
Hi @Mousius,
No problem, my pleasure. :)
Sorry that didn't identify this at the very begging.
Based on the test_lstm.py, it's very surprising to me that we obtain the same execution result compared with pytorch outputs (using == but not isclose()). Even the RelayIR graph are different.
I am digging into it now. Will update status here once I find any solution or clues. :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org