You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "masayag (via GitHub)" <gi...@apache.org> on 2024/04/10 14:21:25 UTC
[I] Support the same workflow name in different namespaces [incubator-kie-kogito-apps]
masayag opened a new issue, #2031:
URL: https://github.com/apache/incubator-kie-kogito-apps/issues/2031
### Description
In a cloud environment when a workflow is deployed via a sonataflow CR, the identity of a workflow in the context of a k8s cluster is determined by a combination of the workflow's name and namespace.
However, in the Data-Index, there is no concept of a namespace of a workflow.
This might lead to a problem when deploying two workflows on the same cluster into different namespaces.
Having supported the SonataflowClusterPlatform as a method to create a global Data-index that expands over the cluster, we might hit a situation in which two (or more) workflows with the same name will be deployed successfully in their namespace, however only the later workflow definition will be available in the Data-Index.
The implication in this case is not being able to view/list/track workflows from other namespaces via the Data-index, and if relying on the Data-index to expose the endpoint for the workflow, the target workflow might be the undesired one.
A similar issue is reported to the operator: https://github.com/apache/incubator-kie-kogito-serverless-operator/issues/442
### Implementation ideas
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Support the same workflow name in different namespaces [incubator-kie-kogito-apps]
Posted by "nmirasch (via GitHub)" <gi...@apache.org>.
nmirasch commented on issue #2031:
URL: https://github.com/apache/incubator-kie-kogito-apps/issues/2031#issuecomment-2049134973
@ricardozanini @masayag Data index is expecting that each workflow's id is unique at a global level in the ecosystem. Seeing the explained problem when deploying two workflows on the same cluster into different namespaces the first thing that comes to my mind is that is needed some id management(manual) to ensure the uniqueness of that ids if we want Dataindex understand them as a different workflows (invoke different endpoints, serviceUrl,..). If I understood well, we want to add some sort of configuration that allows us to incorporate that context information to the workflow id. Let me try to explore different alternatives to add that 'context' information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Support the same workflow name in different namespaces [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on issue #2031:
URL: https://github.com/apache/incubator-kie-kogito-apps/issues/2031#issuecomment-2047722067
@ricardozanini We should have discussed the namespace concept more thoroughly. In my opinion, we should have enforced that workflow-id is unique per deployment/unique and I think it still should be. If some system like parodos want to use a namepace, that namespace should be included in the workflowid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Support the same workflow name in different namespaces [incubator-kie-kogito-apps]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on issue #2031:
URL: https://github.com/apache/incubator-kie-kogito-apps/issues/2031#issuecomment-2047699948
@nmirasch @wmedvede @fjtirado it seems like the Data Index only uses the workflow/process id as the key identifier. Is it possible to add another key or do we have to do a composite key in a single field like `<namespace>/<workflow-id>`?
@nmirasch can you do an assessment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Support the same workflow name in different namespaces [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on issue #2031:
URL: https://github.com/apache/incubator-kie-kogito-apps/issues/2031#issuecomment-2082318287
@ricardozanini I have created https://github.com/serverlessworkflow/specification/issues/838 in the spec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Support the same workflow name in different namespaces [incubator-kie-kogito-apps]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on issue #2031:
URL: https://github.com/apache/incubator-kie-kogito-apps/issues/2031#issuecomment-2049597572
@nmirasch @fjtirado as discussed offline we should bring this discussion to CNCF as well to add a group/namespace/context parameter to workflows. So a given implementation can use a set of attributes to identify the workflow in the ecosystem such as ID, version, and group. The same idea implemented successfully by many systems, including k8s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org