[GitHub] ctubbsii edited a comment on issue #818: Fix #810

[GitBox <gi...@apache.org>]

ctubbsii edited a comment on issue #818: Fix #810
URL: https://github.com/apache/accumulo/pull/818#issuecomment-446311678
 
 
   `Fix #nnn` is even shorter than `Fixes #nnn -`, useful for trying to have succinct subject lines in the commit log. See also https://chris.beams.io/posts/git-commit/ for solid advice on commit log messages.
   
   For this one, I would have done something like:
   
   ```
   Fix #810 Improve MiniAccumulo STDOUT capture
   
   Use `ProcessBuilder.redirectOutput()` to capture STDOUT from MiniAccumulo processes,
   rather than a custom `LogWriter` class.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services