You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Gary Gregory <ga...@gmail.com> on 2012/01/23 12:43:12 UTC

[IO] release 2.2?

Hi All,

Is trunk ready for a 2.2? It feels to me like we have a nice small
increment in functionality to release (RERO).

Gary

-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: [IO] release 2.2?

Posted by Niall Pemberton <ni...@gmail.com>.
On Mon, Jan 23, 2012 at 5:07 PM, Gary Gregory <ga...@gmail.com> wrote:
> I committed a small refactoring. Please comment and/or continue refactoring.

Looks good to me, thanks for doing this.

Niall

> Thank you,
> Gary
>
> On Mon, Jan 23, 2012 at 11:38 AM, sebb <se...@gmail.com> wrote:
>
>> On 23 January 2012 15:27, Gary Gregory <ga...@gmail.com> wrote:
>> > On Mon, Jan 23, 2012 at 10:11 AM, Niall Pemberton <
>> niall.pemberton@gmail.com
>> >> wrote:
>> >
>> >> I find the behaviour of FileUtils.directoryContains() method very
>> >> strange that it would return true for a file that doesn't exist. Since
>> >> this is a new method that will be released for the first time in the
>> >> next release, then it would be preferable to either move it to
>> >> FilenameUtils or change its behaviour before releasing:
>>
>> +1
>>
>> >>
>> >
>> > I think that, based on the initial request, we should move the method to
>> > FilenameUtils and keep the behavior.
>>
>> Fine by me.
>>
>> > The parameters would need to change from File to String.
>>
>> OK by me.
>>
>> > Thoughts?
>> >
>> > Gary
>> >
>> >
>> >
>> >> https://issues.apache.org/jira/browse/IO-291
>> >>
>> >> Niall
>> >>
>> >> On Mon, Jan 23, 2012 at 11:43 AM, Gary Gregory <ga...@gmail.com>
>> >> wrote:
>> >> > Hi All,
>> >> >
>> >> > Is trunk ready for a 2.2? It feels to me like we have a nice small
>> >> > increment in functionality to release (RERO).
>> >> >
>> >> > Gary
>> >> >
>> >> > --
>> >> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> >> > JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
>> >> > Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
>> >> > Blog: http://garygregory.wordpress.com
>> >> > Home: http://garygregory.com/
>> >> > Tweet! http://twitter.com/GaryGregory
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >> For additional commands, e-mail: dev-help@commons.apache.org
>> >>
>> >>
>> >
>> >
>> > --
>> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> > JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
>> > Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
>> > Blog: http://garygregory.wordpress.com
>> > Home: http://garygregory.com/
>> > Tweet! http://twitter.com/GaryGregory
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [IO] release 2.2?

Posted by Gary Gregory <ga...@gmail.com>.
I committed a small refactoring. Please comment and/or continue refactoring.

Thank you,
Gary

On Mon, Jan 23, 2012 at 11:38 AM, sebb <se...@gmail.com> wrote:

> On 23 January 2012 15:27, Gary Gregory <ga...@gmail.com> wrote:
> > On Mon, Jan 23, 2012 at 10:11 AM, Niall Pemberton <
> niall.pemberton@gmail.com
> >> wrote:
> >
> >> I find the behaviour of FileUtils.directoryContains() method very
> >> strange that it would return true for a file that doesn't exist. Since
> >> this is a new method that will be released for the first time in the
> >> next release, then it would be preferable to either move it to
> >> FilenameUtils or change its behaviour before releasing:
>
> +1
>
> >>
> >
> > I think that, based on the initial request, we should move the method to
> > FilenameUtils and keep the behavior.
>
> Fine by me.
>
> > The parameters would need to change from File to String.
>
> OK by me.
>
> > Thoughts?
> >
> > Gary
> >
> >
> >
> >> https://issues.apache.org/jira/browse/IO-291
> >>
> >> Niall
> >>
> >> On Mon, Jan 23, 2012 at 11:43 AM, Gary Gregory <ga...@gmail.com>
> >> wrote:
> >> > Hi All,
> >> >
> >> > Is trunk ready for a 2.2? It feels to me like we have a nice small
> >> > increment in functionality to release (RERO).
> >> >
> >> > Gary
> >> >
> >> > --
> >> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> >> > JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> >> > Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> >> > Blog: http://garygregory.wordpress.com
> >> > Home: http://garygregory.com/
> >> > Tweet! http://twitter.com/GaryGregory
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> > Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: [IO] release 2.2?

Posted by sebb <se...@gmail.com>.
On 23 January 2012 15:27, Gary Gregory <ga...@gmail.com> wrote:
> On Mon, Jan 23, 2012 at 10:11 AM, Niall Pemberton <niall.pemberton@gmail.com
>> wrote:
>
>> I find the behaviour of FileUtils.directoryContains() method very
>> strange that it would return true for a file that doesn't exist. Since
>> this is a new method that will be released for the first time in the
>> next release, then it would be preferable to either move it to
>> FilenameUtils or change its behaviour before releasing:

+1

>>
>
> I think that, based on the initial request, we should move the method to
> FilenameUtils and keep the behavior.

Fine by me.

> The parameters would need to change from File to String.

OK by me.

> Thoughts?
>
> Gary
>
>
>
>> https://issues.apache.org/jira/browse/IO-291
>>
>> Niall
>>
>> On Mon, Jan 23, 2012 at 11:43 AM, Gary Gregory <ga...@gmail.com>
>> wrote:
>> > Hi All,
>> >
>> > Is trunk ready for a 2.2? It feels to me like we have a nice small
>> > increment in functionality to release (RERO).
>> >
>> > Gary
>> >
>> > --
>> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> > JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
>> > Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
>> > Blog: http://garygregory.wordpress.com
>> > Home: http://garygregory.com/
>> > Tweet! http://twitter.com/GaryGregory
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [IO] release 2.2?

Posted by Gary Gregory <ga...@gmail.com>.
On Mon, Jan 23, 2012 at 10:11 AM, Niall Pemberton <niall.pemberton@gmail.com
> wrote:

> I find the behaviour of FileUtils.directoryContains() method very
> strange that it would return true for a file that doesn't exist. Since
> this is a new method that will be released for the first time in the
> next release, then it would be preferable to either move it to
> FilenameUtils or change its behaviour before releasing:
>

I think that, based on the initial request, we should move the method to
FilenameUtils and keep the behavior. The parameters would need to change
from File to String.

Thoughts?

Gary



> https://issues.apache.org/jira/browse/IO-291
>
> Niall
>
> On Mon, Jan 23, 2012 at 11:43 AM, Gary Gregory <ga...@gmail.com>
> wrote:
> > Hi All,
> >
> > Is trunk ready for a 2.2? It feels to me like we have a nice small
> > increment in functionality to release (RERO).
> >
> > Gary
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> > Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: [IO] release 2.2?

Posted by Niall Pemberton <ni...@gmail.com>.
I find the behaviour of FileUtils.directoryContains() method very
strange that it would return true for a file that doesn't exist. Since
this is a new method that will be released for the first time in the
next release, then it would be preferable to either move it to
FilenameUtils or change its behaviour before releasing:

https://issues.apache.org/jira/browse/IO-291

Niall

On Mon, Jan 23, 2012 at 11:43 AM, Gary Gregory <ga...@gmail.com> wrote:
> Hi All,
>
> Is trunk ready for a 2.2? It feels to me like we have a nice small
> increment in functionality to release (RERO).
>
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org