You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mxm <gi...@git.apache.org> on 2016/05/09 14:56:12 UTC
[GitHub] flink pull request: [FLINK-3880] remove mutex for user accumulator...
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/1976
[FLINK-3880] remove mutex for user accumulators hash map
This has been reported as a performance impact. The synchronized lock is not necessary because Flink doesn't perform concurrent updates on the per-task map. If users want to access concurrently, they could implement their own lock.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-3880
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1976.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1976
----
commit 1821ecbc3fb4866bc44eb2bcb8d4e7464f740416
Author: Maximilian Michels <mx...@apache.org>
Date: 2016-05-06T08:40:51Z
[FLINK-3880] remove mutex for user accumulators hash map
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3880] remove mutex for user accumulator...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1976#issuecomment-217888511
Merging after tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3880] remove mutex for user accumulator...
Posted by mxm <gi...@git.apache.org>.
Github user mxm closed the pull request at:
https://github.com/apache/flink/pull/1976
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---