[GitHub] [dolphinscheduler] caishunfeng commented on a change in pull request #8361: Fix deadlock in master/worker caused by close method

[GitBox <gi...@apache.org>]

caishunfeng commented on a change in pull request #8361:
URL: https://github.com/apache/dolphinscheduler/pull/8361#discussion_r805328449



##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java
##########
@@ -229,16 +229,17 @@ public void close(String cause) {
             // close spring Context and will invoke method with @PreDestroy annotation to destory beans. like ServerNodeManager,HostManager,TaskResponseService,CuratorZookeeperClient,etc
             springApplicationContext.close();
             logger.info("springApplicationContext close");
-        } catch (Exception e) {
-            logger.error("master server stop exception ", e);
-        } finally {
             try {
                 // thread sleep 60 seconds for quietly stop
                 Thread.sleep(60000L);

Review comment:
       Is it need to sleep 60s when there is no exception?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org