You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/10/22 17:44:52 UTC
[GitHub] [fineract] IOhacker opened a new pull request #1925: Make sure that using this pseudorandom number generator is safe (FINERACT-1415)
IOhacker opened a new pull request #1925:
URL: https://github.com/apache/fineract/pull/1925
## Description
Make sure that using this pseudorandom number generator is safe (FINERACT-1415)
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [X] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [X] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [X] Create/update unit or integration tests for verifying the changes made.
- [X] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [X] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [X] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fintecheando commented on pull request #1925: Make sure that using this pseudorandom number generator is safe (FINERACT-1415)
Posted by GitBox <gi...@apache.org>.
fintecheando commented on pull request #1925:
URL: https://github.com/apache/fineract/pull/1925#issuecomment-950045803
I have done this:
Fork the apache/fineract repository, then clone the fork in my local environment
1. Create a bug fix branch from develop
git checkout -b FIX_FINERACT_XXYY develop
2. Do the changes
3. Commit the changes to the bug fix branch (being careful with the -a parameter)
git commit -am "YOU COMMENT (FINERACT-XXYY)"
4. Commit the changes to my FORK repository
git push
5. Send the PR
6. After making the PR work with the checklist, I am squashing the fixes into development branch in my local repository
git checkout develop
git merge --squash FIX_FINERACT_XXYY develop
git commit -am "YOU COMMENT (FINERACT-XXYY)"
4. Commit the changes to my FORK repository
git push
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #1925: Make sure that using this pseudorandom number generator is safe (FINERACT-1415)
Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1925:
URL: https://github.com/apache/fineract/pull/1925#issuecomment-950040767
I will check how to do that in my repo.
Regards
El vie, 22 oct 2021 a las 20:45, Petri Tuomola ***@***.***>)
escribió:
> @IOhacker <https://github.com/IOhacker> please could you squash the
> commits in your PR so that there's only one commit. See
> https://github.com/apache/fineract#merge-strategy for expansion.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1925#issuecomment-950037584>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALD2ZAVXKORHASAXAWAYU23UIIHRXANCNFSM5GRB425Q>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1925: Make sure that using this pseudorandom number generator is safe (FINERACT-1415)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1925:
URL: https://github.com/apache/fineract/pull/1925#issuecomment-950275433
Change looks good and build passes. @IOhacker did you work out how to squash the commits though - could you still do this please, and I can then merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1925: Make sure that using this pseudorandom number generator is safe (FINERACT-1415)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1925:
URL: https://github.com/apache/fineract/pull/1925#issuecomment-950106584
Another option is to do the following on your PR branch - if you want to squash 3 commits to one, for example:
git rebase -i HEAD~x
(where x is the number of commits to include in the squash)
In the editor, mark as “f” in the first column for all the commits except the first one you want to retain
Save editor
Now if you do git log you should only see one commit
Then do “git push -f origin” to push the new history to Github
> On 23 Oct 2021, at 10:54, FINTECHEANDO ***@***.***> wrote:
>
>
> I have done this:
>
> Fork the apache/fineract repository, then clone the fork in my local environment
>
> Create a bug fix branch from develop
> git checkout -b FIX_FINERACT_XXYY develop
> Do the changes
> Commit the changes to the bug fix branch (being careful with the -a parameter)
> git commit -am "YOU COMMENT (FINERACT-XXYY)"
> Commit the changes to my FORK repository
> git push
> Send the PR
> After making the PR work with the checklist, I am squashing the fixes into development branch in my local repository
> git checkout develop
> git merge --squash FIX_FINERACT_XXYY develop
> git commit -am "YOU COMMENT (FINERACT-XXYY)"
> Commit the changes to my FORK repository
> git push
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub <https://github.com/apache/fineract/pull/1925#issuecomment-950045803>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASJVCQXJMHGE7RHHBDHHZ3UIIPUTANCNFSM5GRB425Q>.
> Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1925: Make sure that using this pseudorandom number generator is safe (FINERACT-1415)
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1925:
URL: https://github.com/apache/fineract/pull/1925#issuecomment-951832666
JIRA issue has now been closed as this has been merged. https://issues.apache.org/jira/browse/FINERACT-1415
Thank you All.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola merged pull request #1925: Make sure that using this pseudorandom number generator is safe (FINERACT-1415)
Posted by GitBox <gi...@apache.org>.
ptuomola merged pull request #1925:
URL: https://github.com/apache/fineract/pull/1925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #1925: Make sure that using this pseudorandom number generator is safe (FINERACT-1415)
Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1925:
URL: https://github.com/apache/fineract/pull/1925#issuecomment-951390226
@ptuomola there are two commits, one is from one merge and the other is the squash, I have done a previous failed squas (the one related to the Azul Zulu JDK 11) so I am afraid to make a wrong squashing action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #1925: Make sure that using this pseudorandom number generator is safe (FINERACT-1415)
Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1925:
URL: https://github.com/apache/fineract/pull/1925#issuecomment-949999398
@awasum this is the fix ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola edited a comment on pull request #1925: Make sure that using this pseudorandom number generator is safe (FINERACT-1415)
Posted by GitBox <gi...@apache.org>.
ptuomola edited a comment on pull request #1925:
URL: https://github.com/apache/fineract/pull/1925#issuecomment-950037584
@IOhacker please could you squash the commits in your PR so that there's only one commit. See https://github.com/apache/fineract#merge-strategy for explanation. Please don't merge your commit yourself - just squash the commits so that the PR is unmerged but only contains one commit. Hope this is ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1925: Make sure that using this pseudorandom number generator is safe (FINERACT-1415)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1925:
URL: https://github.com/apache/fineract/pull/1925#issuecomment-950037584
@IOhacker please could you squash the commits in your PR so that there's only one commit. See https://github.com/apache/fineract#merge-strategy for expansion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1925: Make sure that using this pseudorandom number generator is safe (FINERACT-1415)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1925:
URL: https://github.com/apache/fineract/pull/1925#issuecomment-951548330
OK - thanks. I'll merge this as is to avoid any more problems with the squash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org